Skip to content

Commit b2d9351

Browse files
committed
fixup! Clarify that it is logged-out AND admins, not logged-out OR admins
1 parent 59c3258 commit b2d9351

File tree

2 files changed

+13
-13
lines changed

2 files changed

+13
-13
lines changed

plugins/speculation-rules/settings.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,9 +50,9 @@ function plsr_get_eagerness_labels(): array {
5050
*/
5151
function plsr_get_authentication_labels(): array {
5252
return array(
53-
'logged_out' => _x( 'Logged-out visitors only (default)', 'setting label', 'speculation-rules' ),
53+
'logged_out' => _x( 'Logged-out visitors only (default)', 'setting label', 'speculation-rules' ),
5454
'logged_out_and_admins' => _x( 'Administrators and logged-out visitors', 'setting label', 'speculation-rules' ),
55-
'any' => _x( 'Any user (logged-in or logged-out)', 'setting label', 'speculation-rules' ),
55+
'any' => _x( 'Any user (logged-in or logged-out)', 'setting label', 'speculation-rules' ),
5656
);
5757
}
5858

plugins/speculation-rules/tests/test-speculation-rules-settings.php

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -59,19 +59,19 @@ public function data_plsr_sanitize_setting(): array {
5959
);
6060

6161
return array(
62-
'invalid type null' => array(
62+
'invalid type null' => array(
6363
null,
6464
$default_value,
6565
),
66-
'invalid type string' => array(
66+
'invalid type string' => array(
6767
'prerender',
6868
$default_value,
6969
),
70-
'missing fields' => array(
70+
'missing fields' => array(
7171
array(),
7272
$default_value,
7373
),
74-
'missing mode' => array(
74+
'missing mode' => array(
7575
array( 'eagerness' => 'conservative' ),
7676
array_merge(
7777
$default_value,
@@ -80,7 +80,7 @@ public function data_plsr_sanitize_setting(): array {
8080
)
8181
),
8282
),
83-
'missing eagerness' => array(
83+
'missing eagerness' => array(
8484
array( 'mode' => 'prefetch' ),
8585
array_merge(
8686
$default_value,
@@ -89,7 +89,7 @@ public function data_plsr_sanitize_setting(): array {
8989
)
9090
),
9191
),
92-
'invalid mode' => array(
92+
'invalid mode' => array(
9393
array(
9494
'mode' => 'something',
9595
'eagerness' => 'eager',
@@ -102,7 +102,7 @@ public function data_plsr_sanitize_setting(): array {
102102
)
103103
),
104104
),
105-
'invalid eagerness' => array(
105+
'invalid eagerness' => array(
106106
array(
107107
'mode' => 'prefetch',
108108
'eagerness' => 'something',
@@ -115,13 +115,13 @@ public function data_plsr_sanitize_setting(): array {
115115
)
116116
),
117117
),
118-
'invalid authentication' => array(
118+
'invalid authentication' => array(
119119
array(
120120
'authentication' => 'bad',
121121
),
122122
$default_value,
123123
),
124-
'valid auth logged_out' => array(
124+
'valid auth logged_out' => array(
125125
array(
126126
'authentication' => 'logged_out',
127127
),
@@ -143,7 +143,7 @@ public function data_plsr_sanitize_setting(): array {
143143
)
144144
),
145145
),
146-
'valid auth any' => array(
146+
'valid auth any' => array(
147147
array(
148148
'authentication' => 'any',
149149
),
@@ -154,7 +154,7 @@ public function data_plsr_sanitize_setting(): array {
154154
)
155155
),
156156
),
157-
'valid fields' => array(
157+
'valid fields' => array(
158158
array(
159159
'mode' => 'prefetch',
160160
'eagerness' => 'conservative',

0 commit comments

Comments
 (0)