Simplify URL Metric addition logic and remove unnecessary exception handling

Co-authored-by: Weston Ruter <[email protected]>

Author: ShyamGadde

plugins/optimization-detective/tests/class-optimization-detective-test-helpers.php

@@ -185,12 +185,7 @@ public function store_url_metric( string $slug, OD_URL_Metric $new_url_metric )
 			od_get_url_metric_freshness_ttl()
 		);
 
-		try {
-			$group = $group_collection->get_group_for_viewport_width( $new_url_metric->get_viewport_width() );
-			$group->add_url_metric( $new_url_metric );
-		} catch ( InvalidArgumentException $e ) {
-			return new WP_Error( 'invalid_url_metric', $e->getMessage() );
-		}
+		$group_collection->add_url_metric( $new_url_metric );
 
 		return OD_URL_Metrics_Post_Type::update_post( $slug, $group_collection );
 	}

plugins/optimization-detective/tests/storage/test-class-od-url-metrics-post-type.php

@@ -217,8 +217,7 @@ public function test_update_post(): void {
 			)
 		);
 
-		$url_metric_group = $url_metric_group_collection->get_group_for_viewport_width( $validated_url_metric->get_viewport_width() );
-		$url_metric_group->add_url_metric( $validated_url_metric );
+		$url_metric_group = $url_metric_group_collection->add_url_metric( $validated_url_metric );
 		$post_id = OD_URL_Metrics_Post_Type::update_post( $slug, $url_metric_group_collection );
 		$this->assertIsInt( $post_id );
 
@@ -232,8 +231,7 @@ public function test_update_post(): void {
 		$url_metrics = OD_URL_Metrics_Post_Type::get_url_metrics_from_post( $post );
 		$this->assertCount( 1, $url_metrics );
 
-		$url_metric_group = $url_metric_group_collection->get_group_for_viewport_width( $another_validated_url_metric->get_viewport_width() );
-		$url_metric_group->add_url_metric( $another_validated_url_metric );
+		$url_metric_group_collection->add_url_metric( $another_validated_url_metric );
 		$again_post_id = OD_URL_Metrics_Post_Type::update_post( $slug, $url_metric_group_collection );
 		$again_post    = get_post( $again_post_id );
 		$this->assertInstanceOf( WP_Post::class, $again_post );