Skip to content

Commit c17a3a3

Browse files
authored
Merge pull request #1867 from ShyamGadde/update/logic-for-updating-url-metrics
De-duplicate logic between REST API and URL Metrics post type
2 parents 4a79036 + e8cd6bd commit c17a3a3

File tree

35 files changed

+140
-89
lines changed
  • plugins
    • embed-optimizer/tests/test-cases
      • single-twitter-embed-outside-viewport-on-mobile
      • single-wordpress-tv-embed-outside-viewport-on-mobile
      • single-youtube-embed-inside-viewport-with-only-mobile-url-metrics
      • single-youtube-embed-outside-viewport-on-mobile
      • single-youtube-embed-outside-viewport-with-only-mobile-url-metrics
    • image-prioritizer/tests/test-cases
      • background-image-outside-viewport-on-all-breakpoints-but-not-desktop-with-fully-populated-sample-data
      • background-image-outside-viewport-with-desktop-metrics-missing
      • common-lcp-image-and-lazy-loaded-image-outside-viewport-with-fully-populated-sample-data
      • common-lcp-image-with-fully-incomplete-sample-data
      • different-lcp-elements-for-all-breakpoints
      • different-lcp-elements-for-non-consecutive-viewport-groups-with-missing-data-for-middle-group
      • different-lcp-elements-for-two-non-consecutive-breakpoints-and-one-is-stale
      • different-lcp-elements-for-two-non-consecutive-breakpoints
      • fetch-priority-high-on-lcp-image-common-on-mobile-and-desktop-with-url-metrics-missing-in-other-groups
      • images-located-above-or-along-initial-viewport
      • img-non-native-lazy-loading
      • lcp-element-external-background-image-complete-samples-but-element-absent
      • lcp-element-external-background-image-present-in-document-and-fully-populated-samples
      • lcp-element-external-background-image-present-in-document-and-partially-populated-samples
      • multiple-videos-on-all-breakpoints
      • multiple-videos-with-desktop-metrics-missing
      • only-mobile-and-desktop-groups-are-populated
      • picture-element-as-lcp-tablet-and-desktop-metrics-missing
      • responsive-background-images
      • url-metric-only-captured-for-one-breakpoint
      • video-with-large-poster-and-desktop-url-metrics-collected
      • video-with-large-poster-and-desktop-url-metrics-missing
      • video-with-poster-lcp-element-on-all-breakpoints
      • video-with-poster-lcp-element-on-desktop-only
      • video-with-poster-lcp-element-on-mobile-and-desktop-but-not-tablet
      • video-without-poster-lcp-element-on-desktop-only
    • optimization-detective

35 files changed

+140
-89
lines changed

plugins/embed-optimizer/tests/test-cases/single-twitter-embed-outside-viewport-on-mobile/set-up.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717

1818
$sample_size = od_get_url_metrics_breakpoint_sample_size();
1919
for ( $j = 0; $j < $sample_size; $j++ ) {
20-
OD_URL_Metrics_Post_Type::store_url_metric(
20+
$test_case->store_url_metric(
2121
od_get_url_metrics_slug( od_get_normalized_query_vars() ),
2222
$test_case->get_sample_url_metric(
2323
array(

plugins/embed-optimizer/tests/test-cases/single-wordpress-tv-embed-outside-viewport-on-mobile/set-up.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
$elements[0]['isLCP'] = false;
1616
}
1717

18-
OD_URL_Metrics_Post_Type::store_url_metric(
18+
$test_case->store_url_metric(
1919
od_get_url_metrics_slug( od_get_normalized_query_vars() ),
2020
$test_case->get_sample_url_metric(
2121
array(

plugins/embed-optimizer/tests/test-cases/single-youtube-embed-inside-viewport-with-only-mobile-url-metrics/set-up.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?php
22
return static function ( Test_Embed_Optimizer_Optimization_Detective $test_case ): void {
3-
OD_URL_Metrics_Post_Type::store_url_metric(
3+
$test_case->store_url_metric(
44
od_get_url_metrics_slug( od_get_normalized_query_vars() ),
55
$test_case->get_sample_url_metric(
66
array(

plugins/embed-optimizer/tests/test-cases/single-youtube-embed-outside-viewport-on-mobile/set-up.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717

1818
$sample_size = od_get_url_metrics_breakpoint_sample_size();
1919
for ( $i = 0; $i < $sample_size; $i++ ) {
20-
OD_URL_Metrics_Post_Type::store_url_metric(
20+
$test_case->store_url_metric(
2121
od_get_url_metrics_slug( od_get_normalized_query_vars() ),
2222
$test_case->get_sample_url_metric(
2323
array(

plugins/embed-optimizer/tests/test-cases/single-youtube-embed-outside-viewport-with-only-mobile-url-metrics/set-up.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?php
22
return static function ( Test_Embed_Optimizer_Optimization_Detective $test_case ): void {
3-
OD_URL_Metrics_Post_Type::store_url_metric(
3+
$test_case->store_url_metric(
44
od_get_url_metrics_slug( od_get_normalized_query_vars() ),
55
$test_case->get_sample_url_metric(
66
array(

plugins/image-prioritizer/tests/test-cases/background-image-outside-viewport-on-all-breakpoints-but-not-desktop-with-fully-populated-sample-data/set-up.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ static function () use ( $breakpoint_max_widths ) {
1212

1313
foreach ( $breakpoint_max_widths as $non_desktop_viewport_width ) {
1414
for ( $i = 0; $i < $sample_size; $i++ ) {
15-
OD_URL_Metrics_Post_Type::store_url_metric(
15+
$test_case->store_url_metric(
1616
od_get_url_metrics_slug( od_get_normalized_query_vars() ),
1717
$test_case->get_sample_url_metric(
1818
array(
@@ -32,7 +32,7 @@ static function () use ( $breakpoint_max_widths ) {
3232
}
3333

3434
for ( $i = 0; $i < $sample_size; $i++ ) {
35-
OD_URL_Metrics_Post_Type::store_url_metric(
35+
$test_case->store_url_metric(
3636
od_get_url_metrics_slug( od_get_normalized_query_vars() ),
3737
$test_case->get_sample_url_metric(
3838
array(

plugins/image-prioritizer/tests/test-cases/background-image-outside-viewport-with-desktop-metrics-missing/set-up.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ static function () use ( $breakpoint_max_widths ) {
1010
);
1111

1212
foreach ( $breakpoint_max_widths as $non_desktop_viewport_width ) {
13-
OD_URL_Metrics_Post_Type::store_url_metric(
13+
$test_case->store_url_metric(
1414
od_get_url_metrics_slug( od_get_normalized_query_vars() ),
1515
$test_case->get_sample_url_metric(
1616
array(

plugins/image-prioritizer/tests/test-cases/common-lcp-image-and-lazy-loaded-image-outside-viewport-with-fully-populated-sample-data/set-up.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
$sample_size = od_get_url_metrics_breakpoint_sample_size();
55
foreach ( array_merge( od_get_breakpoint_max_widths(), array( 1000 ) ) as $viewport_width ) {
66
for ( $i = 0; $i < $sample_size; $i++ ) {
7-
OD_URL_Metrics_Post_Type::store_url_metric(
7+
$test_case->store_url_metric(
88
$slug,
99
$test_case->get_sample_url_metric(
1010
array(

plugins/image-prioritizer/tests/test-cases/common-lcp-image-with-fully-incomplete-sample-data/set-up.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
// Only populate the largest (desktop) viewport group.
77
for ( $i = 0; $i < $sample_size; $i++ ) {
8-
OD_URL_Metrics_Post_Type::store_url_metric(
8+
$test_case->store_url_metric(
99
$slug,
1010
$test_case->get_sample_url_metric(
1111
array(

plugins/image-prioritizer/tests/test-cases/different-lcp-elements-for-all-breakpoints/set-up.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ static function () use ( $breakpoint_max_widths ) {
3333
),
3434
);
3535
$elements[ $i ]['isLCP'] = true;
36-
OD_URL_Metrics_Post_Type::store_url_metric(
36+
$test_case->store_url_metric(
3737
od_get_url_metrics_slug( od_get_normalized_query_vars() ),
3838
$test_case->get_sample_url_metric(
3939
array(

0 commit comments

Comments
 (0)