Update the class constants to use new names

Author: hbhalodia

plugins/image-prioritizer/helper.php

@@ -297,7 +297,7 @@ function image_prioritizer_filter_rest_request_before_callbacks( $response, arra
 
 	// Check for class existence and use constant or class method calls accordingly.
 	$route_endpoint = class_exists( 'OD_REST_URL_Metrics_Store_Endpoint' )
-						? OD_REST_URL_Metrics_Store_Endpoint::REST_API_NAMESPACE . OD_REST_URL_Metrics_Store_Endpoint::REST_API_ROUTE
+						? OD_REST_URL_Metrics_Store_Endpoint::ROUTE_NAMESPACE . OD_REST_URL_Metrics_Store_Endpoint::ROUTE_BASE
 						: OD_REST_API_NAMESPACE . OD_URL_METRICS_ROUTE; // @phpstan-ignore constant.deprecated, constant.deprecated (To be replaced with class method calls in subsequent release.)
 
 	if (

plugins/image-prioritizer/tests/test-helper.php

@@ -727,7 +727,7 @@ public function data_provider_to_test_image_prioritizer_filter_rest_request_befo
 		};
 
 		$create_request = static function ( array $url_metric_data ): WP_REST_Request {
-			$request = new WP_REST_Request( 'POST', '/' . OD_REST_URL_Metrics_Store_Endpoint::REST_API_NAMESPACE . OD_REST_URL_Metrics_Store_Endpoint::REST_API_ROUTE );
+			$request = new WP_REST_Request( 'POST', '/' . OD_REST_URL_Metrics_Store_Endpoint::ROUTE_NAMESPACE . OD_REST_URL_Metrics_Store_Endpoint::ROUTE_BASE );
 			$request->set_header( 'content-type', 'application/json' );
 			$request->set_body( wp_json_encode( $url_metric_data ) );
 			return $request;

plugins/optimization-detective/deprecated.php

@@ -17,7 +17,7 @@
  *
  * @since 0.1.0
  * @access private
- * @deprecated n.e.x.t This constant should not be used, instead use OD_REST_URL_Metrics_Store_Endpoint::REST_API_NAMESPACE method.
+ * @deprecated n.e.x.t This constant should not be used, instead use OD_REST_URL_Metrics_Store_Endpoint::ROUTE_NAMESPACE method.
  * @var string
  */
 const OD_REST_API_NAMESPACE = 'optimization-detective/v1';
@@ -32,7 +32,7 @@
  * @since 0.1.0
  * @access private
  * @link https://google.aip.dev/136
- * @deprecated n.e.x.t This constant should not be used, instead use OD_REST_URL_Metrics_Store_Endpoint::REST_API_ROUTE method.
+ * @deprecated n.e.x.t This constant should not be used, instead use OD_REST_URL_Metrics_Store_Endpoint::ROUTE_BASE method.
  * @var string
  */
 const OD_URL_METRICS_ROUTE = '/url-metrics:store';

plugins/optimization-detective/detection.php

@@ -121,7 +121,7 @@ function od_get_detection_script( string $slug, OD_URL_Metric_Group_Collection $
 		'maxViewportAspectRatio' => od_get_maximum_viewport_aspect_ratio(),
 		'isDebug'                => WP_DEBUG,
 		'extensionModuleUrls'    => $extension_module_urls,
-		'restApiEndpoint'        => rest_url( OD_REST_URL_Metrics_Store_Endpoint::REST_API_NAMESPACE . OD_REST_URL_Metrics_Store_Endpoint::REST_API_ROUTE ),
+		'restApiEndpoint'        => rest_url( OD_REST_URL_Metrics_Store_Endpoint::ROUTE_NAMESPACE . OD_REST_URL_Metrics_Store_Endpoint::ROUTE_BASE ),
 		'currentETag'            => $current_etag,
 		'currentUrl'             => $current_url,
 		'urlMetricSlug'          => $slug,
@@ -169,8 +169,8 @@ function od_register_rest_url_metric_store_endpoint(): void {
 	$endpoint_controller = new OD_REST_URL_Metrics_Store_Endpoint();
 
 	register_rest_route(
-		$endpoint_controller::REST_API_NAMESPACE,
-		$endpoint_controller::REST_API_ROUTE,
+		$endpoint_controller::ROUTE_NAMESPACE,
+		$endpoint_controller::ROUTE_BASE,
 		$endpoint_controller->get_registration_args()
 	);
 }

plugins/optimization-detective/site-health.php

@@ -91,7 +91,7 @@ function od_compose_site_health_result( $response ): array {
 		sprintf(
 			/* translators: %s is the REST API endpoint */
 			__( 'To collect URL Metrics from visitors the REST API must be available to unauthenticated users. Specifically, visitors must be able to perform a <code>POST</code> request to the <code>%s</code> endpoint.', 'optimization-detective' ),
-			'/' . OD_REST_URL_Metrics_Store_Endpoint::REST_API_NAMESPACE . OD_REST_URL_Metrics_Store_Endpoint::REST_API_ROUTE
+			'/' . OD_REST_URL_Metrics_Store_Endpoint::ROUTE_NAMESPACE . OD_REST_URL_Metrics_Store_Endpoint::ROUTE_BASE
 		),
 		array( 'code' => array() )
 	) . '</p>';
@@ -192,7 +192,7 @@ function od_get_rest_api_health_check_response( bool $use_cached ) {
 	if ( false !== $response ) {
 		return $response;
 	}
-	$rest_url = get_rest_url( null, OD_REST_URL_Metrics_Store_Endpoint::REST_API_NAMESPACE . OD_REST_URL_Metrics_Store_Endpoint::REST_API_ROUTE );
+	$rest_url = get_rest_url( null, OD_REST_URL_Metrics_Store_Endpoint::ROUTE_NAMESPACE . OD_REST_URL_Metrics_Store_Endpoint::ROUTE_BASE );
 	$response = wp_remote_post(
 		$rest_url,
 		array(

plugins/optimization-detective/storage/class-od-rest-url-metrics-store-endpoint.php

@@ -26,7 +26,7 @@ final class OD_REST_URL_Metrics_Store_Endpoint {
 	 * @since n.e.x.t
 	 * @var string
 	 */
-	const REST_API_NAMESPACE = 'optimization-detective/v1';
+	const ROUTE_NAMESPACE = 'optimization-detective/v1';
 
 	/**
 	 * Route for storing a URL Metric.
@@ -39,7 +39,7 @@ final class OD_REST_URL_Metrics_Store_Endpoint {
 	 * @link https://google.aip.dev/136
 	 * @var string
 	 */
-	const REST_API_ROUTE = '/url-metrics:store';
+	const ROUTE_BASE = '/url-metrics:store';
 
 	/**
 	 * Gets the arguments for registering the endpoint.

plugins/optimization-detective/tests/storage/test-class-od-rest-url-metrics-store-endpoint.php

@@ -19,7 +19,7 @@ class Test_OD_REST_URL_Metrics_Store_Endpoint extends WP_UnitTestCase {
 	 * @return string Route.
 	 */
 	private function get_route(): string {
-		return '/' . OD_REST_URL_Metrics_Store_Endpoint::REST_API_NAMESPACE . OD_REST_URL_Metrics_Store_Endpoint::REST_API_ROUTE;
+		return '/' . OD_REST_URL_Metrics_Store_Endpoint::ROUTE_NAMESPACE . OD_REST_URL_Metrics_Store_Endpoint::ROUTE_BASE;
 	}
 
 	/**

plugins/optimization-detective/tests/test-detection.php

@@ -234,7 +234,7 @@ public function test_od_get_detection_script_returns_script( Closure $set_up, ar
 	public function od_register_rest_url_metric_store_endpoint(): void {
 
 		$routes = rest_get_server()->get_routes();
-		$this->assertArrayHasKey( '/' . OD_REST_URL_Metrics_Store_Endpoint::REST_API_NAMESPACE . OD_REST_URL_Metrics_Store_Endpoint::REST_API_ROUTE, $routes );
+		$this->assertArrayHasKey( '/' . OD_REST_URL_Metrics_Store_Endpoint::ROUTE_NAMESPACE . OD_REST_URL_Metrics_Store_Endpoint::ROUTE_BASE, $routes );
 	}
 
 	/**

plugins/optimization-detective/tests/test-site-health.php

@@ -420,7 +420,7 @@ protected function filter_rest_api_response( $mocked_response ): object {
 		add_filter(
 			'pre_http_request',
 			static function ( $pre, array $args, string $url ) use ( $mocked_response, $observer ) {
-				if ( rest_url( OD_REST_URL_Metrics_Store_Endpoint::REST_API_NAMESPACE . OD_REST_URL_Metrics_Store_Endpoint::REST_API_ROUTE ) === $url ) {
+				if ( rest_url( OD_REST_URL_Metrics_Store_Endpoint::ROUTE_NAMESPACE . OD_REST_URL_Metrics_Store_Endpoint::ROUTE_BASE ) === $url ) {
 					$observer->counter++;
 					return $mocked_response;
 				}