Merge pull request #1863 from hbhalodia/fix/issue-1860

Update URL Metric storage REST API endpoint to return status code `423 Locked` instead of `403 Forbidden`

Author: westonruter

plugins/optimization-detective/storage/rest-api.php

@@ -102,7 +102,7 @@ function od_register_endpoint(): void {
 					return new WP_Error(
 						'url_metric_storage_locked',
 						__( 'URL Metric storage is presently locked for the current IP.', 'optimization-detective' ),
-						array( 'status' => 403 ) // TODO: Consider 423 Locked status code.
+						array( 'status' => 423 )
 					);
 				}
 				return true;

plugins/optimization-detective/tests/storage/test-rest-api.php

@@ -635,7 +635,7 @@ public function test_rest_request_locked(): void {
 		$request = $this->create_request( $this->get_valid_params() );
 
 		$response = rest_get_server()->dispatch( $request );
-		$this->assertSame( 403, $response->get_status() );
+		$this->assertSame( 423, $response->get_status() );
 		$this->assertSame( 'url_metric_storage_locked', $response->get_data()['code'] );
 	}