Remove no-cache and max-age=0 from bfcache failure conditions

Author: westonruter

plugins/performance-lab/includes/site-health/bfcache-compatibility-headers/helper.php

@@ -68,7 +68,7 @@ function perflab_bfcache_compatibility_headers_check(): array {
 	foreach ( (array) $cache_control_headers as $cache_control_header ) {
 		$cache_control_header = strtolower( $cache_control_header );
 		$found_directives     = array();
-		foreach ( array( 'no-store', 'no-cache', 'max-age=0' ) as $directive ) {
+		foreach ( array( 'no-store' ) as $directive ) {
 			if ( str_contains( $cache_control_header, $directive ) ) {
 				$found_directives[] = $directive;
 			}

plugins/performance-lab/tests/includes/site-health/bfcache-compatibility-headers/test-bfcache-compatibility-headers.php

@@ -91,18 +91,18 @@ public function data_test_bfcache_compatibility(): array {
 			),
 			'no_cache'           => array(
 				$this->build_response( 200, array( 'cache-control' => 'no-cache' ) ),
-				'recommended',
-				'<p>The <code>Cache-Control</code> response header for an unauthenticated request to the home page includes the following directive: <code>no-cache</code>',
+				'good',
+				'If the <code>Cache-Control</code> page response header includes directives like',
 			),
 			'max_age_0'          => array(
-				$this->build_response( 200, array( 'cache-control' => 'max-age=0' ) ),
-				'recommended',
-				'<p>The <code>Cache-Control</code> response header for an unauthenticated request to the home page includes the following directive: <code>max-age=0</code>',
+				$this->build_response( 200, array( 'cache-control' => 'no-cache' ) ),
+				'good',
+				'If the <code>Cache-Control</code> page response header includes directives like',
 			),
 			'max_age_0_no_store' => array(
 				$this->build_response( 200, array( 'cache-control' => 'max-age=0, no-store' ) ),
 				'recommended',
-				'<p>The <code>Cache-Control</code> response header for an unauthenticated request to the home page includes the following directives: <code>no-store</code>, <code>max-age=0</code>',
+				'<p>The <code>Cache-Control</code> response header for an unauthenticated request to the home page includes the following directive: <code>no-store</code>',
 			),
 			'error'              => array(
 				new WP_Error( 'http_request_failed', 'HTTP request failed' ),