Skip to content

Commit e2eb1f6

Browse files
Rename the admin setting variable
1 parent 148c75e commit e2eb1f6

File tree

2 files changed

+14
-14
lines changed

2 files changed

+14
-14
lines changed

plugins/view-transitions/includes/settings.php

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ function plvt_get_view_transition_animation_labels(): array {
4545
* @since 1.0.0
4646
* @see plvt_sanitize_view_transitions_theme_support()
4747
*
48-
* @return array{ default_transition_animation: non-empty-string, header_selector: non-empty-string, main_selector: non-empty-string, post_title_selector: non-empty-string, post_thumbnail_selector: non-empty-string, post_content_selector: non-empty-string, admin_transition_animation: bool } {
48+
* @return array{ default_transition_animation: non-empty-string, header_selector: non-empty-string, main_selector: non-empty-string, post_title_selector: non-empty-string, post_thumbnail_selector: non-empty-string, post_content_selector: non-empty-string, enable_admin_transitions: bool } {
4949
* Default setting value.
5050
*
5151
* @type string $default_transition_animation Default view transition animation.
@@ -54,7 +54,7 @@ function plvt_get_view_transition_animation_labels(): array {
5454
* @type string $post_title_selector CSS selector for the post title element.
5555
* @type string $post_thumbnail_selector CSS selector for the post thumbnail element.
5656
* @type string $post_content_selector CSS selector for the post content element.
57-
* @type bool $admin_transition_animation Whether to use view transitions in the admin area.
57+
* @type bool $enable_admin_transitions Whether to use view transitions in the admin area.
5858
* }
5959
*/
6060
function plvt_get_setting_default(): array {
@@ -65,7 +65,7 @@ function plvt_get_setting_default(): array {
6565
'post_title_selector' => '.wp-block-post-title, .entry-title',
6666
'post_thumbnail_selector' => '.wp-post-image',
6767
'post_content_selector' => '.wp-block-post-content, .entry-content',
68-
'admin_transition_animation' => false,
68+
'enable_admin_transitions' => false,
6969
);
7070
}
7171

@@ -74,7 +74,7 @@ function plvt_get_setting_default(): array {
7474
*
7575
* @since 1.0.0
7676
*
77-
* @return array{ default_transition_animation: non-empty-string, header_selector: non-empty-string, main_selector: non-empty-string, post_title_selector: non-empty-string, post_thumbnail_selector: non-empty-string, post_content_selector: non-empty-string, admin_transition_animation: bool|non-empty-string } {
77+
* @return array{ default_transition_animation: non-empty-string, header_selector: non-empty-string, main_selector: non-empty-string, post_title_selector: non-empty-string, post_thumbnail_selector: non-empty-string, post_content_selector: non-empty-string, enable_admin_transitions: bool|non-empty-string } {
7878
* Stored setting value.
7979
*
8080
* @type string $default_transition_animation Default view transition animation.
@@ -83,7 +83,7 @@ function plvt_get_setting_default(): array {
8383
* @type string $post_title_selector CSS selector for the post title element.
8484
* @type string $post_thumbnail_selector CSS selector for the post thumbnail element.
8585
* @type string $post_content_selector CSS selector for the post content element.
86-
* @type bool $admin_transition_animation Whether to use view transitions in the admin area.
86+
* @type bool $enable_admin_transitions Whether to use view transitions in the admin area.
8787
* }
8888
*/
8989
function plvt_get_stored_setting_value(): array {
@@ -96,7 +96,7 @@ function plvt_get_stored_setting_value(): array {
9696
* @since 1.0.0
9797
*
9898
* @param mixed $input Setting to sanitize.
99-
* @return array{ default_transition_animation: non-empty-string, header_selector: non-empty-string, main_selector: non-empty-string, post_title_selector: non-empty-string, post_thumbnail_selector: non-empty-string, post_content_selector: non-empty-string, admin_transition_animation: bool|non-empty-string } {
99+
* @return array{ default_transition_animation: non-empty-string, header_selector: non-empty-string, main_selector: non-empty-string, post_title_selector: non-empty-string, post_thumbnail_selector: non-empty-string, post_content_selector: non-empty-string, enable_admin_transitions: bool|non-empty-string } {
100100
* Sanitized setting.
101101
*
102102
* @type string $default_transition_animation Default view transition animation.
@@ -105,7 +105,7 @@ function plvt_get_stored_setting_value(): array {
105105
* @type string $post_title_selector CSS selector for the post title element.
106106
* @type string $post_thumbnail_selector CSS selector for the post thumbnail element.
107107
* @type string $post_content_selector CSS selector for the post content element.
108-
* @type bool $admin_transition_animation Whether to use view transitions in the admin area.
108+
* @type bool $enable_admin_transitions Whether to use view transitions in the admin area.
109109
* }
110110
*/
111111
function plvt_sanitize_setting( $input ): array {
@@ -140,9 +140,9 @@ function plvt_sanitize_setting( $input ): array {
140140
}
141141
}
142142

143-
// Sanitize "admin_transition_animation" as a boolean.
144-
if ( isset( $input['admin_transition_animation'] ) ) {
145-
$value['admin_transition_animation'] = (bool) $input['admin_transition_animation'];
143+
// Sanitize "enable_admin_transitions" as a boolean.
144+
if ( isset( $input['enable_admin_transitions'] ) ) {
145+
$value['enable_admin_transitions'] = (bool) $input['enable_admin_transitions'];
146146
}
147147

148148
return $value;
@@ -279,7 +279,7 @@ static function (): void {
279279
'title' => __( 'Post Content Selector', 'view-transitions' ),
280280
'description' => __( 'Provide the CSS selector to detect the post content element.', 'view-transitions' ),
281281
),
282-
'admin_transition_animation' => array(
282+
'enable_admin_transitions' => array(
283283
'title' => __( 'Use transition in WP Admin', 'view-transitions' ),
284284
'description' => __( 'Enable view transitions in the WordPress admin area.', 'view-transitions' ),
285285
),
@@ -291,7 +291,7 @@ static function (): void {
291291
);
292292

293293
// Remove 'label_for' for checkbox field to avoid duplicate label association.
294-
if ( 'admin_transition_animation' === $slug ) {
294+
if ( 'enable_admin_transitions' === $slug ) {
295295
unset( $additional_args['label_for'] );
296296
}
297297

@@ -332,7 +332,7 @@ function plvt_render_settings_field( array $args ): void {
332332
$type = 'select';
333333
$choices = plvt_get_view_transition_animation_labels();
334334
break;
335-
case 'admin_transition_animation':
335+
case 'enable_admin_transitions':
336336
$type = 'checkbox';
337337
$choices = array(); // Defined just for consistency.
338338
break;

plugins/view-transitions/includes/theme.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -370,7 +370,7 @@ function plvt_print_view_transitions_admin_style(): void {
370370
}
371371

372372
$options = plvt_get_stored_setting_value();
373-
if ( ! isset( $options['admin_transition_animation'] ) || true !== $options['admin_transition_animation'] ) {
373+
if ( ! isset( $options['enable_admin_transitions'] ) || true !== $options['enable_admin_transitions'] ) {
374374
return;
375375
}
376376
?>

0 commit comments

Comments
 (0)