Rename od_handle_trigger_page_cache_invalidation() to od_trigger_post_update_actions()

Author: westonruter

plugins/optimization-detective/detection.php

@@ -179,7 +179,7 @@ function od_register_rest_url_metric_store_endpoint(): void {
 }
 
 /**
- * Triggers actions for page caches to invalidate their caches related to the supplied cache purge post ID.
+ * Triggers post update actions for page caches to invalidate their caches related to the supplied cache purge post ID.
  *
  * This is intended to flush any page cache for the URL after the new URL Metric was submitted so that the optimizations
  * which depend on that URL Metric can start to take effect.
@@ -188,7 +188,7 @@ function od_register_rest_url_metric_store_endpoint(): void {
  *
  * @param positive-int $cache_purge_post_id Cache purge post ID.
  */
-function od_handle_trigger_page_cache_invalidation( int $cache_purge_post_id ): void {
+function od_trigger_post_update_actions( int $cache_purge_post_id ): void {
 
 	$post = get_post( $cache_purge_post_id );
 	if ( ! ( $post instanceof WP_Post ) ) {

plugins/optimization-detective/hooks.php

@@ -25,5 +25,5 @@
 add_action( 'admin_init', 'od_maybe_run_rest_api_health_check' );
 add_action( 'after_plugin_row_meta', 'od_render_rest_api_health_check_admin_notice_in_plugin_row', 30 );
 add_action( 'rest_api_init', 'od_register_rest_url_metric_store_endpoint' );
-add_action( 'od_trigger_page_cache_invalidation', 'od_handle_trigger_page_cache_invalidation' );
+add_action( 'od_trigger_page_cache_invalidation', 'od_trigger_post_update_actions' );
 // @codeCoverageIgnoreEnd

plugins/optimization-detective/tests/storage/test-class-od-rest-url-metrics-store-endpoint.php

@@ -161,7 +161,7 @@ function ( OD_URL_Metric_Store_Request_Context $context ) use ( &$stored_context
 
 		$this->assertInstanceOf( OD_URL_Metric_Store_Request_Context::class, $stored_context );
 
-		// Now check that od_handle_trigger_page_cache_invalidation() cleaned caches as expected.
+		// Now check that od_trigger_post_update_actions() cleaned caches as expected.
 		$this->assertSame( $url_metrics[0]->jsonSerialize(), $stored_context->url_metric->jsonSerialize() );
 		if ( isset( $valid_params['cache_purge_post_id'] ) ) {
 			$cache_purge_post_id = $stored_context->request->get_param( 'cache_purge_post_id' );

plugins/optimization-detective/tests/test-detection.php

@@ -256,9 +256,9 @@ public function od_register_rest_url_metric_store_endpoint(): void {
 	}
 
 	/**
-	 * Test od_handle_trigger_page_cache_invalidation().
+	 * Test od_trigger_post_update_actions().
 	 *
-	 * @covers ::od_handle_trigger_page_cache_invalidation
+	 * @covers ::od_trigger_post_update_actions
 	 */
 	public function test_trigger_page_cache_invalidation(): void {
 		$cache_purge_post_id = self::factory()->post->create();
@@ -273,7 +273,7 @@ static function ( string $hook, ...$args ) use ( &$all_hook_callback_args ): voi
 			PHP_INT_MAX
 		);
 
-		od_handle_trigger_page_cache_invalidation( $cache_purge_post_id );
+		od_trigger_post_update_actions( $cache_purge_post_id );
 
 		$this->assertArrayHasKey( 'clean_post_cache', $all_hook_callback_args );
 		$found = false;
@@ -311,16 +311,16 @@ static function ( string $hook, ...$args ) use ( &$all_hook_callback_args ): voi
 	}
 
 	/**
-	 * Test od_handle_trigger_page_cache_invalidation() for an invalid post.
+	 * Test od_trigger_post_update_actions() for an invalid post.
 	 *
-	 * @covers ::od_handle_trigger_page_cache_invalidation
+	 * @covers ::od_trigger_post_update_actions
 	 */
-	public function test_trigger_page_cache_invalidation_invalid_post_id(): void {
+	public function test_od_trigger_post_update_actions(): void {
 		wp_delete_post( 1, true );
 		$before_clean_post_cache_count       = did_action( 'clean_post_cache' );
 		$before_transition_post_status_count = did_action( 'transition_post_status' );
 		$before_save_post_count              = did_action( 'save_post' );
-		od_handle_trigger_page_cache_invalidation( 1 );
+		od_trigger_post_update_actions( 1 );
 		$this->assertSame( $before_clean_post_cache_count, did_action( 'clean_post_cache' ) );
 		$this->assertSame( $before_transition_post_status_count, did_action( 'transition_post_status' ) );
 		$this->assertSame( $before_save_post_count, did_action( 'save_post' ) );

plugins/optimization-detective/tests/test-hooks.php

@@ -22,6 +22,6 @@ public function test_hooks_added(): void {
 		$this->assertEquals( 10, has_action( 'admin_init', 'od_maybe_run_rest_api_health_check' ) );
 		$this->assertEquals( 30, has_action( 'after_plugin_row_meta', 'od_render_rest_api_health_check_admin_notice_in_plugin_row' ) );
 		$this->assertEquals( 10, has_action( 'rest_api_init', 'od_register_rest_url_metric_store_endpoint' ) );
-		$this->assertEquals( 10, has_action( 'od_trigger_page_cache_invalidation', 'od_handle_trigger_page_cache_invalidation' ) );
+		$this->assertEquals( 10, has_action( 'od_trigger_page_cache_invalidation', 'od_trigger_post_update_actions' ) );
 	}
 }