refactor: removes reason phrase until we have a "reason"...

Author: JasonTheAdams

src/Providers/Http/DTO/Response.php

@@ -18,8 +18,7 @@
  * @phpstan-type ResponseArrayShape array{
  *     statusCode: int,
  *     headers: array<string, list<string>>,
- *     body?: string|null,
- *     reasonPhrase: string
+ *     body?: string|null
  * }
  *
  * @extends AbstractDataTransferObject<ResponseArrayShape>
@@ -29,7 +28,6 @@ class Response extends AbstractDataTransferObject
     public const KEY_STATUS_CODE = 'statusCode';
     public const KEY_HEADERS = 'headers';
     public const KEY_BODY = 'body';
-    public const KEY_REASON_PHRASE = 'reasonPhrase';
 
     /**
      * @var int The HTTP status code.
@@ -51,11 +49,6 @@ class Response extends AbstractDataTransferObject
      */
     protected ?string $body;
 
-    /**
-     * @var string The reason phrase.
-     */
-    protected string $reasonPhrase;
-
     /**
      * Constructor.
      *
@@ -64,11 +57,10 @@ class Response extends AbstractDataTransferObject
      * @param int $statusCode The HTTP status code.
      * @param array<string, string|list<string>> $headers The response headers.
      * @param string|null $body The response body.
-     * @param string $reasonPhrase The reason phrase.
      *
      * @throws InvalidArgumentException If the status code is invalid.
      */
-    public function __construct(int $statusCode, array $headers, ?string $body = null, string $reasonPhrase = '')
+    public function __construct(int $statusCode, array $headers, ?string $body = null)
     {
         if ($statusCode < 100 || $statusCode >= 600) {
             throw new InvalidArgumentException('Invalid HTTP status code: ' . $statusCode);
@@ -78,7 +70,6 @@ public function __construct(int $statusCode, array $headers, ?string $body = nul
         $this->headers = $this->normalizeHeaderValues($headers);
         $this->headersMap = $this->buildHeadersMap($this->headers);
         $this->body = $body;
-        $this->reasonPhrase = $reasonPhrase;
     }
 
     /**
@@ -148,18 +139,6 @@ public function getBody(): ?string
         return $this->body;
     }
 
-    /**
-     * Gets the reason phrase.
-     *
-     * @since n.e.x.t
-     *
-     * @return string The reason phrase.
-     */
-    public function getReasonPhrase(): string
-    {
-        return $this->reasonPhrase;
-    }
-
     /**
      * Checks if the response indicates success.
      *
@@ -260,12 +239,8 @@ public static function getJsonSchema(): array
                     'type' => ['string', 'null'],
                     'description' => 'The response body.',
                 ],
-                self::KEY_REASON_PHRASE => [
-                    'type' => 'string',
-                    'description' => 'The reason phrase.',
-                ],
             ],
-            'required' => [self::KEY_STATUS_CODE, self::KEY_HEADERS, self::KEY_REASON_PHRASE],
+            'required' => [self::KEY_STATUS_CODE, self::KEY_HEADERS],
         ];
     }
 
@@ -281,7 +256,6 @@ public function toArray(): array
         $data = [
             self::KEY_STATUS_CODE => $this->statusCode,
             self::KEY_HEADERS => $this->headers,
-            self::KEY_REASON_PHRASE => $this->reasonPhrase,
         ];
 
         if ($this->body !== null) {
@@ -301,14 +275,12 @@ public static function fromArray(array $array): self
         static::validateFromArrayData($array, [
             self::KEY_STATUS_CODE,
             self::KEY_HEADERS,
-            self::KEY_REASON_PHRASE,
         ]);
 
         return new self(
             $array[self::KEY_STATUS_CODE],
             $array[self::KEY_HEADERS],
-            $array[self::KEY_BODY] ?? null,
-            $array[self::KEY_REASON_PHRASE]
+            $array[self::KEY_BODY] ?? null
         );
     }
 }

src/Providers/Http/HttpTransporter.php

@@ -126,8 +126,7 @@ private function convertFromPsr7Response(ResponseInterface $psr7Response): Respo
         return new Response(
             $psr7Response->getStatusCode(),
             $headers,
-            $body === '' ? null : $body,
-            $psr7Response->getReasonPhrase()
+            $body === '' ? null : $body
         );
     }
 }

tests/unit/Providers/Http/HttpTransporterTest.php

@@ -167,31 +167,6 @@ public function testMultipleHeaderValues(): void
         $this->assertEquals(['single-value'], $sentRequest->getHeader('X-Custom'));
     }
 
-    /**
-     * Tests response with reason phrase.
-     *
-     * @since n.e.x.t
-     *
-     * @covers ::send
-     * @covers ::convertFromPsr7Response
-     *
-     * @return void
-     */
-    public function testResponseReasonPhrase(): void
-    {
-        // Arrange
-        $request = new Request('GET', 'https://api.example.com');
-        $mockResponse = new Psr7Response(404, [], null, '1.1', 'Not Found');
-        $this->mockClient->addResponse($mockResponse);
-
-        // Act
-        $response = $this->transporter->send($request);
-
-        // Assert
-        $this->assertEquals(404, $response->getStatusCode());
-        $this->assertEquals('Not Found', $response->getReasonPhrase());
-    }
-
     /**
      * Tests using discovery when no dependencies provided.
      *