fix: corrects either id or name to be required

Author: JasonTheAdams

src/Tools/DTO/FunctionResponse.php

@@ -113,7 +113,14 @@ public static function getJsonSchema(): array
                     'description' => 'The response data from the function.',
                 ],
             ],
-            'required' => [self::KEY_ID, self::KEY_NAME, self::KEY_RESPONSE],
+            'oneOf' => [
+                [
+                    'required' => [self::KEY_RESPONSE, self::KEY_ID],
+                ],
+                [
+                    'required' => [self::KEY_RESPONSE, self::KEY_NAME],
+                ],
+            ],
         ];
     }
 
@@ -140,11 +147,16 @@ public function toArray(): array
      */
     public static function fromArray(array $array): self
     {
-        static::validateFromArrayData($array, [self::KEY_ID, self::KEY_NAME, self::KEY_RESPONSE]);
+        static::validateFromArrayData($array, [self::KEY_RESPONSE]);
+
+        // Validate that at least one of id or name is provided
+        if (!array_key_exists(self::KEY_ID, $array) && !array_key_exists(self::KEY_NAME, $array)) {
+            throw new \InvalidArgumentException('At least one of id or name must be provided.');
+        }
 
         return new self(
-            $array[self::KEY_ID],
-            $array[self::KEY_NAME],
+            $array[self::KEY_ID] ?? null,
+            $array[self::KEY_NAME] ?? null,
             $array[self::KEY_RESPONSE]
         );
     }

tests/unit/Tools/DTO/FunctionCallTest.php

@@ -123,16 +123,13 @@ public function testJsonSchema(): void
 
         // Check oneOf for required fields
         $this->assertArrayHasKey('oneOf', $schema);
-        $this->assertCount(3, $schema['oneOf']);
+        $this->assertCount(2, $schema['oneOf']);
 
         // First option: only id required
         $this->assertEquals([FunctionCall::KEY_ID], $schema['oneOf'][0]['required']);
 
         // Second option: only name required
         $this->assertEquals([FunctionCall::KEY_NAME], $schema['oneOf'][1]['required']);
-        
-        // Third option: both id and name required
-        $this->assertEquals([FunctionCall::KEY_ID, FunctionCall::KEY_NAME], $schema['oneOf'][2]['required']);
     }
 
     /**

tests/unit/Tools/DTO/FunctionResponseTest.php

@@ -122,9 +122,15 @@ public function testJsonSchema(): void
         $this->assertContains('array', $responseTypes);
         $this->assertContains('null', $responseTypes);
 
-        // Check required fields
-        $this->assertArrayHasKey('required', $schema);
-        $this->assertEquals([FunctionResponse::KEY_ID, FunctionResponse::KEY_NAME, FunctionResponse::KEY_RESPONSE], $schema['required']);
+        // Check oneOf for required fields
+        $this->assertArrayHasKey('oneOf', $schema);
+        $this->assertCount(2, $schema['oneOf']);
+        
+        // First option: response and id required
+        $this->assertEquals([FunctionResponse::KEY_RESPONSE, FunctionResponse::KEY_ID], $schema['oneOf'][0]['required']);
+        
+        // Second option: response and name required
+        $this->assertEquals([FunctionResponse::KEY_RESPONSE, FunctionResponse::KEY_NAME], $schema['oneOf'][1]['required']);
     }
 
     /**