refactor: improves schema accuracy

Author: JasonTheAdams

src/Operations/DTO/GenerativeAiOperation.php

@@ -89,26 +89,47 @@ public function getResult(): ?GenerativeAiResult
     public static function getJsonSchema(): array
     {
         return [
-            'type' => 'object',
-            'properties' => [
-                'id' => [
-                    'type' => 'string',
-                    'description' => 'Unique identifier for this operation.',
-                ],
-                'state' => [
-                    'type' => 'string',
-                    'enum' => ['starting', 'processing', 'succeeded', 'failed', 'canceled'],
-                    'description' => 'The current state of the operation.',
+            'oneOf' => [
+                // Succeeded state - has result
+                [
+                    'type' => 'object',
+                    'properties' => [
+                        'id' => [
+                            'type' => 'string',
+                            'description' => 'Unique identifier for this operation.',
+                        ],
+                        'state' => [
+                            'type' => 'string',
+                            'const' => OperationStateEnum::succeeded()->value,
+                        ],
+                        'result' => GenerativeAiResult::getJsonSchema(),
+                    ],
+                    'required' => ['id', 'state', 'result'],
+                    'additionalProperties' => false,
                 ],
-                'result' => [
-                    'oneOf' => [
-                        ['type' => 'null'],
-                        GenerativeAiResult::getJsonSchema(),
+                // All other states - no result
+                [
+                    'type' => 'object',
+                    'properties' => [
+                        'id' => [
+                            'type' => 'string',
+                            'description' => 'Unique identifier for this operation.',
+                        ],
+                        'state' => [
+                            'type' => 'string',
+                            'enum' => [
+                                OperationStateEnum::starting()->value,
+                                OperationStateEnum::processing()->value,
+                                OperationStateEnum::failed()->value,
+                                OperationStateEnum::canceled()->value,
+                            ],
+                            'description' => 'The current state of the operation.',
+                        ],
                     ],
-                    'description' => 'The result once the operation completes.',
+                    'required' => ['id', 'state'],
+                    'additionalProperties' => false,
                 ],
             ],
-            'required' => ['id', 'state'],
         ];
     }
 }