refactor: enforces method enum in Request constructor

Author: JasonTheAdams

src/Providers/Http/DTO/Request.php

@@ -57,27 +57,20 @@ class Request extends AbstractDataTransferObject
      *
      * @since n.e.x.t
      *
-     * @param HttpMethodEnum|string $method The HTTP method.
+     * @param HttpMethodEnum $method The HTTP method.
      * @param string $uri The request URI.
      * @param array<string, string|list<string>> $headers The request headers.
      * @param string|null $body The request body.
      *
-     * @throws InvalidArgumentException If the URI is empty or method is invalid.
+     * @throws InvalidArgumentException If the URI is empty.
      */
-    public function __construct($method, string $uri, array $headers = [], ?string $body = null)
+    public function __construct(HttpMethodEnum $method, string $uri, array $headers = [], ?string $body = null)
     {
         if (empty($uri)) {
             throw new InvalidArgumentException('URI cannot be empty.');
         }
 
-        if (is_string($method)) {
-            $this->method = HttpMethodEnum::from(strtoupper($method));
-        } elseif ($method instanceof HttpMethodEnum) {
-            $this->method = $method;
-        } else {
-            throw new InvalidArgumentException('Method must be a string or HttpMethodEnum instance.');
-        }
-
+        $this->method = $method;
         $this->uri = $uri;
         $this->headers = $this->normalizeHeaders($headers);
         $this->body = $body;
@@ -283,7 +276,7 @@ public static function fromArray(array $array): self
         static::validateFromArrayData($array, [self::KEY_METHOD, self::KEY_URI, self::KEY_HEADERS]);
 
         return new self(
-            $array[self::KEY_METHOD],
+            HttpMethodEnum::from($array[self::KEY_METHOD]),
             $array[self::KEY_URI],
             $array[self::KEY_HEADERS] ?? [],
             $array[self::KEY_BODY] ?? null

tests/unit/Providers/Http/HttpTransporterTest.php

@@ -9,6 +9,7 @@
 use Psr\Http\Message\ResponseInterface;
 use WordPress\AiClient\Providers\Http\DTO\Request;
 use WordPress\AiClient\Providers\Http\DTO\Response;
+use WordPress\AiClient\Providers\Http\Enums\HttpMethodEnum;
 use WordPress\AiClient\Providers\Http\HttpTransporter;
 use GuzzleHttp\Psr7\Response as Psr7Response;
 use GuzzleHttp\Psr7\HttpFactory;
@@ -65,7 +66,7 @@ protected function setUp(): void
     public function testSendGetRequest(): void
     {
         // Arrange
-        $request = new Request('GET', 'https://api.example.com/data');
+        $request = new Request(HttpMethodEnum::GET(), 'https://api.example.com/data');
         $mockResponse = new Psr7Response(200, ['Content-Type' => 'application/json'], '{"success":true}');
         $this->mockClient->addResponse($mockResponse);
 
@@ -97,7 +98,7 @@ public function testSendPostRequestWithBody(): void
         // Arrange
         $headers = ['Content-Type' => 'application/json'];
         $body = '{"name":"test"}';
-        $request = new Request('POST', 'https://api.example.com/create', $headers, $body);
+        $request = new Request(HttpMethodEnum::POST(), 'https://api.example.com/create', $headers, $body);
 
         $mockResponse = new Psr7Response(201, ['Location' => '/resource/123'], '{"id":123}');
         $this->mockClient->addResponse($mockResponse);
@@ -136,7 +137,7 @@ public function testMultipleHeaderValues(): void
             'Accept' => ['application/json', 'application/xml'],
             'X-Custom' => 'single-value'
         ];
-        $request = new Request('GET', 'https://api.example.com', $headers);
+        $request = new Request(HttpMethodEnum::GET(), 'https://api.example.com', $headers);
 
         $mockResponse = new Psr7Response(200, ['Set-Cookie' => ['cookie1=value1', 'cookie2=value2']]);
         $this->mockClient->addResponse($mockResponse);