refactor: removes type check from File and MessagePart fromArray

Author: JasonTheAdams

src/Files/DTO/File.php

@@ -419,18 +419,15 @@ public function toArray(): array
      */
     public static function fromArray(array $array): File
     {
-        $fileType = FileTypeEnum::from($array['fileType']);
+        // Check which properties are set to determine how to construct the File
+        $mimeType = $array['mimeType'] ?? null;
 
-        if ($fileType->isRemote()) {
-            if (!isset($array['url']) || !isset($array['mimeType'])) {
-                throw new InvalidArgumentException('Remote file requires url and mimeType.');
-            }
-            return new self($array['url'], $array['mimeType']);
+        if (isset($array['url'])) {
+            return new self($array['url'], $mimeType);
+        } elseif (isset($array['base64Data'])) {
+            return new self($array['base64Data'], $mimeType);
         } else {
-            if (!isset($array['mimeType']) || !isset($array['base64Data'])) {
-                throw new InvalidArgumentException('Inline file requires mimeType and base64Data.');
-            }
-            return new self($array['base64Data'], $array['mimeType']);
+            throw new InvalidArgumentException('File requires either url or base64Data.');
         }
     }
 }

src/Messages/DTO/MessagePart.php

@@ -249,32 +249,19 @@ public function toArray(): array
      */
     public static function fromArray(array $array): MessagePart
     {
-        $type = MessagePartTypeEnum::from($array['type']);
-
-        if ($type->isText()) {
-            if (!isset($array['text'])) {
-                throw new InvalidArgumentException('Text message part requires text field.');
-            }
+        // Check which properties are set to determine how to construct the MessagePart
+        if (isset($array['text'])) {
             return new self($array['text']);
-        } elseif ($type->isFile()) {
-            if (!isset($array['file'])) {
-                throw new InvalidArgumentException('File message part requires file field.');
-            }
-            $fileData = $array['file'];
-            return new self(File::fromArray($fileData));
-        } elseif ($type->isFunctionCall()) {
-            if (!isset($array['functionCall'])) {
-                throw new InvalidArgumentException('Function call message part requires functionCall field.');
-            }
-            $functionCallData = $array['functionCall'];
-            return new self(FunctionCall::fromArray($functionCallData));
+        } elseif (isset($array['file'])) {
+            return new self(File::fromArray($array['file']));
+        } elseif (isset($array['functionCall'])) {
+            return new self(FunctionCall::fromArray($array['functionCall']));
+        } elseif (isset($array['functionResponse'])) {
+            return new self(FunctionResponse::fromArray($array['functionResponse']));
         } else {
-            // Function response is the only remaining option
-            if (!isset($array['functionResponse'])) {
-                throw new InvalidArgumentException('Function response message part requires functionResponse field.');
-            }
-            $functionResponseData = $array['functionResponse'];
-            return new self(FunctionResponse::fromArray($functionResponseData));
+            throw new InvalidArgumentException(
+                'MessagePart requires one of: text, file, functionCall, or functionResponse.'
+            );
         }
     }
 }