refactor: adds constants for scheam keys

Author: JasonTheAdams

src/Providers/DTO/ProviderMetadata.php

@@ -25,6 +25,10 @@
  */
 final class ProviderMetadata extends AbstractDataValueObject
 {
+    public const KEY_ID = 'id';
+    public const KEY_NAME = 'name';
+    public const KEY_TYPE = 'type';
+
     /**
      * @var string The provider's unique identifier.
      */
@@ -102,21 +106,21 @@ public static function getJsonSchema(): array
         return [
             'type' => 'object',
             'properties' => [
-                'id' => [
+                self::KEY_ID => [
                     'type' => 'string',
                     'description' => 'The provider\'s unique identifier.',
                 ],
-                'name' => [
+                self::KEY_NAME => [
                     'type' => 'string',
                     'description' => 'The provider\'s display name.',
                 ],
-                'type' => [
+                self::KEY_TYPE => [
                     'type' => 'string',
                     'enum' => ProviderTypeEnum::getValues(),
                     'description' => 'The provider type (cloud, server, or client).',
                 ],
             ],
-            'required' => ['id', 'name', 'type'],
+            'required' => [self::KEY_ID, self::KEY_NAME, self::KEY_TYPE],
         ];
     }
 
@@ -130,9 +134,9 @@ public static function getJsonSchema(): array
     public function toArray(): array
     {
         return [
-            'id' => $this->id,
-            'name' => $this->name,
-            'type' => $this->type->value,
+            self::KEY_ID => $this->id,
+            self::KEY_NAME => $this->name,
+            self::KEY_TYPE => $this->type->value,
         ];
     }
 
@@ -143,12 +147,12 @@ public function toArray(): array
      */
     public static function fromArray(array $array): self
     {
-        static::validateFromArrayData($array, ['id', 'name', 'type']);
+        static::validateFromArrayData($array, [self::KEY_ID, self::KEY_NAME, self::KEY_TYPE]);
 
         return new self(
-            $array['id'],
-            $array['name'],
-            ProviderTypeEnum::from($array['type'])
+            $array[self::KEY_ID],
+            $array[self::KEY_NAME],
+            ProviderTypeEnum::from($array[self::KEY_TYPE])
         );
     }
 }

src/Providers/DTO/ProviderModelsMetadata.php

@@ -27,6 +27,9 @@
  */
 final class ProviderModelsMetadata extends AbstractDataValueObject
 {
+    public const KEY_PROVIDER = 'provider';
+    public const KEY_MODELS = 'models';
+
     /**
      * @var ProviderMetadata The provider metadata.
      */
@@ -85,14 +88,14 @@ public static function getJsonSchema(): array
         return [
             'type' => 'object',
             'properties' => [
-                'provider' => ProviderMetadata::getJsonSchema(),
-                'models' => [
+                self::KEY_PROVIDER => ProviderMetadata::getJsonSchema(),
+                self::KEY_MODELS => [
                     'type' => 'array',
                     'items' => ModelMetadata::getJsonSchema(),
                     'description' => 'The available models for this provider.',
                 ],
             ],
-            'required' => ['provider', 'models'],
+            'required' => [self::KEY_PROVIDER, self::KEY_MODELS],
         ];
     }
 
@@ -106,8 +109,8 @@ public static function getJsonSchema(): array
     public function toArray(): array
     {
         return [
-            'provider' => $this->provider->toArray(),
-            'models' => array_values(
+            self::KEY_PROVIDER => $this->provider->toArray(),
+            self::KEY_MODELS => array_values(
                 array_map(static fn(ModelMetadata $model): array => $model->toArray(), $this->models)
             ),
         ];
@@ -121,10 +124,10 @@ public function toArray(): array
     public static function fromArray(array $array): self
     {
         return new self(
-            ProviderMetadata::fromArray($array['provider']),
+            ProviderMetadata::fromArray($array[self::KEY_PROVIDER]),
             array_map(
                 static fn(array $modelData): ModelMetadata => ModelMetadata::fromArray($modelData),
-                $array['models']
+                $array[self::KEY_MODELS]
             )
         );
     }