Fix invalid input_text type when sending model messages back to OpenAI Responses API
#184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixarntz
added
the
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
JasonTheAdams
approved these changes
Jan 26, 2026
Member
JasonTheAdams
left a comment
JasonTheAdams
left a comment
There was a problem hiding this comment.
Great catch! I'm feeling better and better about these integration tests.
|
@felixarntz Thanks! I actually have not had a chance to test your version. But I assume it works :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #182
Supersedes #183
I've added a basic integration test for multi-turn messages, for the other providers too, just to make sure it works and is covered.
You can verify that this fixes the bug by temporarily changing the
output_textstring in my changed line back toinput_text- this would lead to the original behavior before this PR, and you'll get the exact exception that #182 mentions.