Add test case for classic scripts

westonruter · westonruter · commit 06b5f6ebf72b · 2025-12-21T18:05:23.000-08:00
diff --git a/src/wp-includes/class-wp-scripts.php b/src/wp-includes/class-wp-scripts.php
@@ -1092,7 +1092,7 @@ private function filter_eligible_strategies( $handle, $eligible_strategies = nul
 	 *
 	 * @since 6.9.0
 	 * @see self::filter_eligible_strategies()
-	 * @see WP_Script_Modules::get_highest_fetchpriority_with_dependents()
+	 * @see WP_Script_Modules::get_highest_fetchpriority()
 	 *
 	 * @param string                $handle         Script module ID.
 	 * @param array<string, true>   $checked        Optional. An array of already checked script handles, used to avoid recursive loops.
diff --git a/tests/phpunit/tests/dependencies/scripts.php b/tests/phpunit/tests/dependencies/scripts.php
@@ -1516,6 +1516,30 @@ public function test_highest_fetchpriority_with_dependents_uses_cached_result()
 		);
 	}
 
+	/**
+	 * Tests expected priority is used when a dependent is registered but not enqueued.
+	 *
+	 * @ticket 64429
+	 *
+	 * @covers WP_Scripts::print_scripts
+	 * @covers WP_Scripts::get_highest_fetchpriority_with_dependents
+	 */
+	public function test_priority_of_dependency_for_non_enqueued_dependent() {
+		$wp_scripts = wp_scripts();
+		wp_default_scripts( $wp_scripts );
+
+		$wp_scripts->add( 'not-enqueued', 'https://example.com/not-enqueued.js', array( 'comment-reply' ), null, array( 'priority' => 'high' ) );
+		$wp_scripts->enqueue( 'comment-reply' );
+
+		$actual = $this->normalize_markup_for_snapshot( get_echo( array( $wp_scripts, 'print_scripts' ) ) );
+		$this->assertEqualHTML(
+			'<script type="text/javascript" src="/wp-includes/js/comment-reply.js" id="comment-reply-js" async="async" data-wp-strategy="async" fetchpriority="low"></script>',
+			$actual,
+			'<body>',
+			"Snapshot:\n$actual"
+		);
+	}
+
 	/**
 	 * Tests that printing a script without enqueueing has the same output as when it is enqueued.
 	 *
@@ -4256,4 +4280,26 @@ public function data_varying_versions_handle_args() {
 			),
 		);
 	}
+
+	/**
+	 * Normalizes markup for snapshot.
+	 *
+	 * @param string $markup Markup.
+	 * @return string Normalized markup.
+	 */
+	private function normalize_markup_for_snapshot( string $markup ): string {
+		$processor = new WP_HTML_Tag_Processor( $markup );
+		$clean_url = static function ( string $url ): string {
+			$url = preg_replace( '#^https?://[^/]+#', '', $url );
+			return remove_query_arg( 'ver', $url );
+		};
+		while ( $processor->next_tag() ) {
+			if ( 'LINK' === $processor->get_tag() && is_string( $processor->get_attribute( 'href' ) ) ) {
+				$processor->set_attribute( 'href', $clean_url( $processor->get_attribute( 'href' ) ) );
+			} elseif ( 'SCRIPT' === $processor->get_tag() && is_string( $processor->get_attribute( 'src' ) ) ) {
+				$processor->set_attribute( 'src', $clean_url( $processor->get_attribute( 'src' ) ) );
+			}
+		}
+		return $processor->get_updated_html();
+	}
 }
diff --git a/tests/phpunit/tests/script-modules/wpScriptModules.php b/tests/phpunit/tests/script-modules/wpScriptModules.php
@@ -1864,12 +1864,12 @@ public function test_priority_of_dependency_for_non_enqueued_dependent() {
 		wp_register_script_module( 'not-enqueued', 'https://example.com/not-enqueued.js', array( '@wordpress/a11y' ), null, array( 'priority' => 'high' ) );
 		wp_enqueue_script_module( '@wordpress/a11y' );
 
-		$actual_script_modules = $this->normalize_markup_for_snapshot( get_echo( array( wp_script_modules(), 'print_enqueued_script_modules' ) ) );
+		$actual = $this->normalize_markup_for_snapshot( get_echo( array( wp_script_modules(), 'print_enqueued_script_modules' ) ) );
 		$this->assertEqualHTML(
 			'<script type="module" src="/wp-includes/js/dist/script-modules/a11y/index.min.js" id="@wordpress/a11y-js-module" fetchpriority="low"></script>',
-			$actual_script_modules,
+			$actual,
 			'<body>',
-			"Snapshot:\n$actual_script_modules"
+			"Snapshot:\n$actual"
 		);
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -1092,7 +1092,7 @@ private function filter_eligible_strategies( $handle, $eligible_strategies = nul`
`1092`	`1092`	`*`
`1093`	`1093`	`* @since 6.9.0`
`1094`	`1094`	`* @see self::filter_eligible_strategies()`
`1095`		`- * @see WP_Script_Modules::get_highest_fetchpriority_with_dependents()`
	`1095`	`+ * @see WP_Script_Modules::get_highest_fetchpriority()`
`1096`	`1096`	`*`
`1097`	`1097`	`* @param string $handle Script module ID.`
`1098`	`1098`	`* @param array<string, true> $checked Optional. An array of already checked script handles, used to avoid recursive loops.`