Coding Standards: Remove redundant check in wp_read_image_metadata().

SergeyBiryukov · SergeyBiryukov · commit 0723e8f90911 · 2025-07-16T12:55:59.000Z
This logical branch is only reachable if `$exif_description` is already verified as truthy a few lines above. Follow-up to [57267]. Props justlevine. See #63268. git-svn-id: https://develop.svn.wordpress.org/trunk@60475 602fd350-edb4-49c9-b593-d223f7449a82
diff --git a/src/wp-admin/includes/image.php b/src/wp-admin/includes/image.php
@@ -967,7 +967,7 @@ function wp_read_image_metadata( $file ) {
 			}
 
 			// If both user comments and description are present.
-			if ( empty( $meta['caption'] ) && $exif_description && $exif_usercomment ) {
+			if ( empty( $meta['caption'] ) && $exif_usercomment ) {
 				if ( ! empty( $meta['title'] ) && $exif_description === $meta['title'] ) {
 					$caption = $exif_usercomment;
 				} else {

Original file line number	Diff line number	Diff line change
`@@ -967,7 +967,7 @@ function wp_read_image_metadata( $file ) {`
`967`	`967`	`}`
`968`	`968`
`969`	`969`	`// If both user comments and description are present.`
`970`		`- if ( empty( $meta['caption'] ) && $exif_description && $exif_usercomment ) {`
	`970`	`+ if ( empty( $meta['caption'] ) && $exif_usercomment ) {`
`971`	`971`	`if ( ! empty( $meta['title'] ) && $exif_description === $meta['title'] ) {`
`972`	`972`	`$caption = $exif_usercomment;`
`973`	`973`	`} else {`