Add double quotes around handle/ID in warning

Author: westonruter

src/wp-includes/class-wp-dependencies.php

@@ -557,7 +557,7 @@ public function get_etag( $load ) {
 	protected function get_dependency_warning_message( $handle, $missing_dependency_handles ) {
 		return sprintf(
 			/* translators: 1: Handle, 2: Comma-separated list of missing dependency handles. */
-			__( 'The handle %1$s was enqueued with dependencies that are not registered: %2$s.' ),
+			__( 'The handle "%1$s" was enqueued with dependencies that are not registered: %2$s.' ),
 			$handle,
 			implode( ', ', $missing_dependency_handles )
 		);

src/wp-includes/class-wp-script-modules.php

@@ -728,7 +728,7 @@ private function sort_item_dependencies( string $id, array $import_types, array
 				__METHOD__,
 				sprintf(
 					/* translators: 1: Script module ID, 2: Comma-separated list of missing dependency IDs. */
-					__( 'The script module %1$s was enqueued with dependencies that are not registered: %2$s.' ),
+					__( 'The script module "%1$s" was enqueued with dependencies that are not registered: %2$s.' ),
 					$id,
 					implode( ', ', $missing_dependencies )
 				),

src/wp-includes/class-wp-scripts.php

@@ -1177,7 +1177,7 @@ public function reset() {
 	protected function get_dependency_warning_message( $handle, $missing_dependency_handles ) {
 		return sprintf(
 			/* translators: 1: Script handle, 2: Comma-separated list of missing dependency handles. */
-			__( 'The script with the handle %1$s was enqueued with dependencies that are not registered: %2$s.' ),
+			__( 'The script with the handle "%1$s" was enqueued with dependencies that are not registered: %2$s.' ),
 			$handle,
 			implode( ', ', $missing_dependency_handles )
 		);

src/wp-includes/class-wp-styles.php

@@ -506,7 +506,7 @@ public function reset() {
 	protected function get_dependency_warning_message( $handle, $missing_dependency_handles ) {
 		return sprintf(
 			/* translators: 1: Style handle, 2: Comma-separated list of missing dependency handles. */
-			__( 'The style with the handle %1$s was enqueued with dependencies that are not registered: %2$s.' ),
+			__( 'The style with the handle "%1$s" was enqueued with dependencies that are not registered: %2$s.' ),
 			$handle,
 			implode( ', ', $missing_dependency_handles )
 		);

tests/phpunit/tests/dependencies/scripts.php

@@ -4108,7 +4108,8 @@ public function test_wp_scripts_doing_it_wrong_for_missing_dependencies() {
 		wp_register_script( 'main', '/main.js', array( 'registered-dep', 'missing-dep' ) );
 		wp_enqueue_script( 'main' );
 
-		get_echo( 'wp_print_scripts' );
+		$markup = get_echo( 'wp_print_scripts' );
+		$this->assertStringNotContainsString( 'main.js', $markup, 'Expected script to be absent.' );
 
 		$this->assertArrayHasKey(
 			$expected_key,
@@ -4117,7 +4118,7 @@ public function test_wp_scripts_doing_it_wrong_for_missing_dependencies() {
 		);
 
 		$this->assertStringContainsString(
-			'The script with the handle main was enqueued with dependencies that are not registered: missing-dep',
+			'The script with the handle "main" was enqueued with dependencies that are not registered: missing-dep',
 			$this->caught_doing_it_wrong[ $expected_key ],
 			'Expected _doing_it_wrong() notice to indicate missing dependencies for enqueued script.'
 		);

tests/phpunit/tests/dependencies/styles.php

@@ -833,7 +833,8 @@ public function test_wp_style_doing_it_wrong_for_missing_dependencies() {
 
 		wp_enqueue_style( 'main-style' );
 
-		get_echo( 'wp_print_styles' );
+		$markup = get_echo( 'wp_print_styles' );
+		$this->assertStringNotContainsString( 'main-style.css', $markup, 'Expected style to be absent.' );
 
 		$this->assertArrayHasKey(
 			$expected_key,
@@ -842,7 +843,7 @@ public function test_wp_style_doing_it_wrong_for_missing_dependencies() {
 		);
 
 		$this->assertStringContainsString(
-			'The style with the handle main-style was enqueued with dependencies that are not registered: missing-style-dep',
+			'The style with the handle "main-style" was enqueued with dependencies that are not registered: missing-style-dep',
 			$this->caught_doing_it_wrong[ $expected_key ],
 			'Expected _doing_it_wrong() notice to indicate missing dependencies for enqueued styles.'
 		);

tests/phpunit/tests/script-modules/wpScriptModules.php

@@ -2326,7 +2326,8 @@ public function test_missing_script_module_dependency_triggers_incorrect_usage()
 		$this->script_modules->register( 'main-module', '/main-module.js', array( 'missing-mod-dep' ) );
 		$this->script_modules->enqueue( 'main-module' );
 
-		get_echo( array( $this->script_modules, 'print_enqueued_script_modules' ) );
+		$markup = get_echo( array( $this->script_modules, 'print_enqueued_script_modules' ) );
+		$this->assertStringNotContainsString( 'main-module.js', $markup, 'Expected script module to be absent.' );
 
 		$this->assertArrayHasKey(
 			'WP_Script_Modules::sort_item_dependencies',
@@ -2336,7 +2337,7 @@ public function test_missing_script_module_dependency_triggers_incorrect_usage()
 
 		// Assert the message mentions the missing dependency handle.
 		$this->assertStringContainsString(
-			'The script module main-module was enqueued with dependencies that are not registered: missing-mod-dep',
+			'The script module "main-module" was enqueued with dependencies that are not registered: missing-mod-dep',
 			$this->caught_doing_it_wrong['WP_Script_Modules::sort_item_dependencies']
 		);
 	}