Skip to content

Commit 1446ccf

Browse files
Add assertions for enqueues after registering
Co-authored-by: Peter Wilson <[email protected]>
1 parent 4808feb commit 1446ccf

File tree

2 files changed

+8
-0
lines changed

2 files changed

+8
-0
lines changed

tests/phpunit/tests/dependencies/scripts.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@ public function tear_down() {
7373
* Test versioning
7474
*
7575
* @ticket 11315
76+
* @ticket 64372
7677
*/
7778
public function test_wp_enqueue_script() {
7879
global $wp_version;
@@ -83,13 +84,16 @@ public function test_wp_enqueue_script() {
8384
wp_enqueue_script( 'empty-deps-null-version', 'example.com', array(), null );
8485
wp_enqueue_script( 'empty-deps-arg-in-handle-with-ver?arg1=foo&arg2=bar', 'https://example.com/test.js', array(), '2.0' );
8586
wp_enqueue_script( 'empty-deps-arg-in-handle-without-ver?arg1=foo&arg2=bar', 'https://example.com/test.js', array(), null );
87+
wp_register_script( 'registered-no-qs-handle-null-version-enqueued-with-qs', 'https://example.com/test.js' );
88+
wp_enqueue_script( 'registered-no-qs-handle-null-version-enqueued-with-qs?arg1=foo&arg2=bar' );
8689

8790
$expected = "<script type='text/javascript' src='http://example.com?ver={$wp_version}' id='no-deps-no-version-js'></script>\n";
8891
$expected .= "<script type='text/javascript' src='http://example.com?ver={$wp_version}' id='empty-deps-no-version-js'></script>\n";
8992
$expected .= "<script type='text/javascript' src='http://example.com?ver=1.2' id='empty-deps-version-js'></script>\n";
9093
$expected .= "<script type='text/javascript' src='http://example.com' id='empty-deps-null-version-js'></script>\n";
9194
$expected .= "<script type='text/javascript' src='https://example.com/test.js?ver=2.0&amp;arg1=foo&amp;arg2=bar' id='empty-deps-arg-in-handle-with-ver-js'></script>\n";
9295
$expected .= "<script type='text/javascript' src='https://example.com/test.js?arg1=foo&amp;arg2=bar' id='empty-deps-arg-in-handle-without-ver-js'></script>\n";
96+
$expected .= "<script type='text/javascript' src='https://example.com/test.js?ver={$wp_version}&amp;arg1=foo&amp;arg2=bar' id='registered-no-qs-handle-null-version-enqueued-with-qs-js'></script>\n";
9397

9498
$this->assertEqualHTML( $expected, get_echo( 'wp_print_scripts' ) );
9599

tests/phpunit/tests/dependencies/styles.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ public function tear_down() {
5555
* Test versioning
5656
*
5757
* @ticket 11315
58+
* @ticket 64372
5859
*/
5960
public function test_wp_enqueue_style() {
6061
wp_enqueue_style( 'no-deps-no-version', 'example.com' );
@@ -63,6 +64,8 @@ public function test_wp_enqueue_style() {
6364
wp_enqueue_style( 'no-deps-null-version-print-media', 'example.com', array(), null, 'print' );
6465
wp_enqueue_style( 'no-deps-arg-in-handle-with-ver?arg1=foo&arg2=bar', 'https://example.com/test.css', array(), '2.0' );
6566
wp_enqueue_style( 'no-deps-arg-in-handle-without-ver?arg1=foo&arg2=bar', 'https://example.com/test.css', array(), null );
67+
wp_register_style( 'registered-no-qs-handle-null-version-enqueued-with-qs', 'https://example.com/test.css' );
68+
wp_enqueue_style( 'registered-no-qs-handle-null-version-enqueued-with-qs?arg1=foo&arg2=bar' );
6669

6770
$ver = get_bloginfo( 'version' );
6871
$expected = "<link rel='stylesheet' id='no-deps-no-version-css' href='http://example.com?ver=$ver' type='text/css' media='all' />\n";
@@ -71,6 +74,7 @@ public function test_wp_enqueue_style() {
7174
$expected .= "<link rel='stylesheet' id='no-deps-null-version-print-media-css' href='http://example.com' type='text/css' media='print' />\n";
7275
$expected .= "<link rel='stylesheet' id='no-deps-arg-in-handle-with-ver-css' href='https://example.com/test.css?ver=2.0&#038;arg1=foo&#038;arg2=bar' type='text/css' media='all' />\n";
7376
$expected .= "<link rel='stylesheet' id='no-deps-arg-in-handle-without-ver-css' href='https://example.com/test.css?arg1=foo&#038;arg2=bar' type='text/css' media='all' />\n";
77+
$expected .= "<link rel='stylesheet' id='registered-no-qs-handle-null-version-enqueued-with-qs-css' href='https://example.com/test.css?ver={$ver}&#038;arg1=foo&#038;arg2=bar' type='text/css' media='all' />\n";
7478

7579
$this->assertEqualHTML( $expected, get_echo( 'wp_print_styles' ) );
7680

0 commit comments

Comments
 (0)