Code Modernization: Site Health, Permalinks, I18N, Users, Multisite: Use null coalescing operator instead of isset() ternaries.

westonruter · westonruter · commit 14b647c6b1a2 · 2026-01-06T05:55:33.000Z
Developed as a subset of #10654 Initially developed in #4886 Follow-up to [61443], [61442], [61436], [61435], [61434], [61403], [61433], [61432], [61431], [61430], [61429], [61424], [61404], [61403]. Props costdev, westonruter. See #58874, #63430. git-svn-id: https://develop.svn.wordpress.org/trunk@61444 602fd350-edb4-49c9-b593-d223f7449a82
diff --git a/src/wp-admin/includes/class-wp-debug-data.php b/src/wp-admin/includes/class-wp-debug-data.php
@@ -373,8 +373,8 @@ private static function get_wp_server(): array {
 		);
 		$fields['httpd_software']      = array(
 			'label' => __( 'Web server' ),
-			'value' => ( isset( $_SERVER['SERVER_SOFTWARE'] ) ? $_SERVER['SERVER_SOFTWARE'] : __( 'Unable to determine what web server software is used' ) ),
-			'debug' => ( isset( $_SERVER['SERVER_SOFTWARE'] ) ? $_SERVER['SERVER_SOFTWARE'] : 'unknown' ),
+			'value' => $_SERVER['SERVER_SOFTWARE'] ?? __( 'Unable to determine what web server software is used' ),
+			'debug' => $_SERVER['SERVER_SOFTWARE'] ?? 'unknown',
 		);
 		$fields['php_version']         = array(
 			'label' => __( 'PHP version' ),
diff --git a/src/wp-admin/includes/class-wp-ms-sites-list-table.php b/src/wp-admin/includes/class-wp-ms-sites-list-table.php
@@ -44,7 +44,7 @@ public function __construct( $args = array() ) {
 		parent::__construct(
 			array(
 				'plural' => 'sites',
-				'screen' => isset( $args['screen'] ) ? $args['screen'] : null,
+				'screen' => $args['screen'] ?? null,
 			)
 		);
 	}
@@ -135,7 +135,7 @@ public function prepare_items() {
 			}
 		}
 
-		$order_by = isset( $_REQUEST['orderby'] ) ? $_REQUEST['orderby'] : '';
+		$order_by = $_REQUEST['orderby'] ?? '';
 		if ( 'registered' === $order_by ) {
 			// 'registered' is a valid field name.
 		} elseif ( 'lastupdated' === $order_by ) {
diff --git a/src/wp-admin/includes/class-wp-ms-themes-list-table.php b/src/wp-admin/includes/class-wp-ms-themes-list-table.php
@@ -48,11 +48,11 @@ public function __construct( $args = array() ) {
 		parent::__construct(
 			array(
 				'plural' => 'themes',
-				'screen' => isset( $args['screen'] ) ? $args['screen'] : null,
+				'screen' => $args['screen'] ?? null,
 			)
 		);
 
-		$status = isset( $_REQUEST['theme_status'] ) ? $_REQUEST['theme_status'] : 'all';
+		$status = $_REQUEST['theme_status'] ?? 'all';
 		if ( ! in_array( $status, array( 'all', 'enabled', 'disabled', 'upgrade', 'search', 'broken', 'auto-update-enabled', 'auto-update-disabled' ), true ) ) {
 			$status = 'all';
 		}
@@ -153,7 +153,7 @@ public function prepare_items() {
 			$themes[ $filter ][ $key ] = $themes['all'][ $key ];
 
 			$theme_data = array(
-				'update_supported' => isset( $theme->update_supported ) ? $theme->update_supported : true,
+				'update_supported' => $theme->update_supported ?? true,
 			);
 
 			// Extra info if known. array_merge() ensures $theme_data has precedence if keys collide.
diff --git a/src/wp-admin/includes/class-wp-ms-users-list-table.php b/src/wp-admin/includes/class-wp-ms-users-list-table.php
@@ -41,7 +41,7 @@ public function prepare_items() {
 
 		$users_per_page = $this->get_items_per_page( 'users_network_per_page' );
 
-		$role = isset( $_REQUEST['role'] ) ? $_REQUEST['role'] : '';
+		$role = $_REQUEST['role'] ?? '';
 
 		$paged = $this->get_pagenum();
 
diff --git a/src/wp-admin/includes/class-wp-site-health.php b/src/wp-admin/includes/class-wp-site-health.php
@@ -150,9 +150,9 @@ public function enqueue_scripts() {
 				if ( is_string( $test['test'] ) ) {
 					$health_check_js_variables['site_status']['async'][] = array(
 						'test'      => $test['test'],
-						'has_rest'  => ( isset( $test['has_rest'] ) ? $test['has_rest'] : false ),
+						'has_rest'  => $test['has_rest'] ?? false,
 						'completed' => false,
-						'headers'   => isset( $test['headers'] ) ? $test['headers'] : array(),
+						'headers'   => $test['headers'] ?? array(),
 					);
 				}
 			}
@@ -1052,10 +1052,10 @@ public function get_test_php_extensions() {
 		$failures = array();
 
 		foreach ( $modules as $library => $module ) {
-			$extension_name = ( isset( $module['extension'] ) ? $module['extension'] : null );
-			$function_name  = ( isset( $module['function'] ) ? $module['function'] : null );
-			$constant_name  = ( isset( $module['constant'] ) ? $module['constant'] : null );
-			$class_name     = ( isset( $module['class'] ) ? $module['class'] : null );
+			$extension_name = $module['extension'] ?? null;
+			$function_name  = $module['function'] ?? null;
+			$constant_name  = $module['constant'] ?? null;
+			$class_name     = $module['class'] ?? null;
 
 			// If this module is a fallback for another function, check if that other function passed.
 			if ( isset( $module['fallback_for'] ) ) {
@@ -3023,7 +3023,7 @@ private function get_cron_tasks() {
 						'sig'      => $sig,
 						'args'     => $data['args'],
 						'schedule' => $data['schedule'],
-						'interval' => isset( $data['interval'] ) ? $data['interval'] : null,
+						'interval' => $data['interval'] ?? null,
 					);
 
 				}
diff --git a/src/wp-admin/includes/class-wp-users-list-table.php b/src/wp-admin/includes/class-wp-users-list-table.php
@@ -46,7 +46,7 @@ public function __construct( $args = array() ) {
 			array(
 				'singular' => 'user',
 				'plural'   => 'users',
-				'screen'   => isset( $args['screen'] ) ? $args['screen'] : null,
+				'screen'   => $args['screen'] ?? null,
 			)
 		);
 
@@ -85,7 +85,7 @@ public function prepare_items() {
 
 		$usersearch = isset( $_REQUEST['s'] ) ? wp_unslash( trim( $_REQUEST['s'] ) ) : '';
 
-		$role = isset( $_REQUEST['role'] ) ? $_REQUEST['role'] : '';
+		$role = $_REQUEST['role'] ?? '';
 
 		$per_page       = ( $this->is_site_users ) ? 'site_users_network_per_page' : 'users_per_page';
 		$users_per_page = $this->get_items_per_page( $per_page );
diff --git a/src/wp-admin/includes/user.php b/src/wp-admin/includes/user.php
@@ -62,7 +62,7 @@ function edit_user( $user_id = 0 ) {
 			wp_die( __( 'Sorry, you are not allowed to give users that role.' ), 403 );
 		}
 
-		$potential_role = isset( $wp_roles->role_objects[ $new_role ] ) ? $wp_roles->role_objects[ $new_role ] : false;
+		$potential_role = $wp_roles->role_objects[ $new_role ] ?? false;
 
 		/*
 		 * Don't let anyone with 'promote_users' edit their own role to something without it.
diff --git a/src/wp-admin/my-sites.php b/src/wp-admin/my-sites.php
@@ -17,7 +17,7 @@
 	wp_die( __( 'Sorry, you are not allowed to access this page.' ) );
 }
 
-$action = isset( $_POST['action'] ) ? $_POST['action'] : 'splash';
+$action = $_POST['action'] ?? 'splash';
 
 $blogs = get_blogs_of_user( $current_user->ID );
 
diff --git a/src/wp-admin/network/site-themes.php b/src/wp-admin/network/site-themes.php
@@ -29,7 +29,7 @@
 
 $action = $wp_list_table->current_action();
 
-$s = isset( $_REQUEST['s'] ) ? $_REQUEST['s'] : '';
+$s = $_REQUEST['s'] ?? '';
 
 // Clean up request URI from temporary args for screen options/paging uri's to work as expected.
 $temp_args              = array( 'enabled', 'disabled', 'error' );
diff --git a/src/wp-admin/network/themes.php b/src/wp-admin/network/themes.php
@@ -19,7 +19,7 @@
 
 $action = $wp_list_table->current_action();
 
-$s = isset( $_REQUEST['s'] ) ? $_REQUEST['s'] : '';
+$s = $_REQUEST['s'] ?? '';
 
 // Clean up request URI from temporary args for screen options/paging uri's to work as expected.
 $temp_args = array(
diff --git a/src/wp-admin/network/upgrade.php b/src/wp-admin/network/upgrade.php
@@ -47,7 +47,7 @@
 echo '<div class="wrap">';
 echo '<h1>' . __( 'Upgrade Network' ) . '</h1>';
 
-$action = isset( $_GET['action'] ) ? $_GET['action'] : 'show';
+$action = $_GET['action'] ?? 'show';
 
 switch ( $action ) {
 	case 'upgrade':
diff --git a/src/wp-admin/site-health.php b/src/wp-admin/site-health.php
@@ -36,7 +36,7 @@
 	'tab-count-' . count( $tabs ),
 );
 
-$current_tab = ( isset( $_GET['tab'] ) ? $_GET['tab'] : '' );
+$current_tab = $_GET['tab'] ?? '';
 
 $title = sprintf(
 	// translators: %s: The currently displayed tab.
diff --git a/src/wp-admin/users.php b/src/wp-admin/users.php
@@ -629,7 +629,7 @@
 					break;
 				case 'add':
 					$message = __( 'New user created.' );
-					$user_id = isset( $_GET['id'] ) ? $_GET['id'] : false;
+					$user_id = $_GET['id'] ?? false;
 					if ( $user_id && current_user_can( 'edit_user', $user_id ) ) {
 						$message .= sprintf(
 							' <a href="%1$s">%2$s</a>',
diff --git a/src/wp-includes/capabilities.php b/src/wp-includes/capabilities.php
@@ -471,7 +471,7 @@ function map_meta_cap( $cap, $user_id, ...$args ) {
 
 			$caps = map_meta_cap( "edit_{$object_type}", $user_id, $object_id );
 
-			$meta_key = isset( $args[1] ) ? $args[1] : false;
+			$meta_key = $args[1] ?? false;
 
 			if ( $meta_key ) {
 				$allowed = ! is_protected_meta( $meta_key, $object_type );
diff --git a/src/wp-includes/pomo/po.php b/src/wp-includes/pomo/po.php
@@ -166,7 +166,7 @@ public static function unpoify( $input_string ) {
 						}
 					} else {
 						$previous_is_backslash = false;
-						$unpoified            .= isset( $escapes[ $char ] ) ? $escapes[ $char ] : $char;
+						$unpoified            .= $escapes[ $char ] ?? $char;
 					}
 				}
 			}
diff --git a/src/wp-includes/pomo/translations.php b/src/wp-includes/pomo/translations.php
@@ -119,7 +119,7 @@ public function set_headers( $headers ) {
 		 * @return string|false Header if it exists, false otherwise.
 		 */
 		public function get_header( $header ) {
-			return isset( $this->headers[ $header ] ) ? $this->headers[ $header ] : false;
+			return $this->headers[ $header ] ?? false;
 		}
 
 		/**
@@ -132,7 +132,7 @@ public function get_header( $header ) {
 		 */
 		public function translate_entry( &$entry ) {
 			$key = $entry->key();
-			return isset( $this->entries[ $key ] ) ? $this->entries[ $key ] : false;
+			return $this->entries[ $key ] ?? false;
 		}
 
 		/**
diff --git a/src/wp-includes/rewrite.php b/src/wp-includes/rewrite.php
@@ -577,7 +577,7 @@ function url_to_postid( $url ) {
 	} else {
 		// Chop off /path/to/blog.
 		$home_path = parse_url( home_url( '/' ) );
-		$home_path = isset( $home_path['path'] ) ? $home_path['path'] : '';
+		$home_path = $home_path['path'] ?? '';
 		$url       = preg_replace( sprintf( '#^%s#', preg_quote( $home_path ) ), '', trailingslashit( $url ) );
 	}
 
diff --git a/src/wp-includes/user.php b/src/wp-includes/user.php
@@ -2464,7 +2464,7 @@ function wp_insert_user( $userdata ) {
 
 	$meta['show_admin_bar_front'] = empty( $userdata['show_admin_bar_front'] ) ? 'true' : $userdata['show_admin_bar_front'];
 
-	$meta['locale'] = isset( $userdata['locale'] ) ? $userdata['locale'] : '';
+	$meta['locale'] = $userdata['locale'] ?? '';
 
 	$compacted = compact( 'user_pass', 'user_nicename', 'user_email', 'user_url', 'user_registered', 'user_activation_key', 'display_name' );
 	$data      = wp_unslash( $compacted );
diff --git a/src/wp-signup.php b/src/wp-signup.php
@@ -976,7 +976,7 @@ function signup_get_available_languages() {
 	/* translators: %s: Login URL. */
 	printf( __( 'You must first <a href="%s">log in</a>, and then you can create a new site.' ), $login_url );
 } else {
-	$stage = isset( $_POST['stage'] ) ? $_POST['stage'] : 'default';
+	$stage = $_POST['stage'] ?? 'default';
 	switch ( $stage ) {
 		case 'validate-user-signup':
 			if ( 'all' === $active_signup
@@ -1000,7 +1000,7 @@ function signup_get_available_languages() {
 			break;
 		case 'default':
 		default:
-			$user_email = isset( $_POST['user_email'] ) ? $_POST['user_email'] : '';
+			$user_email = $_POST['user_email'] ?? '';
 			/**
 			 * Fires when the site sign-up form is sent.
 			 *

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ public function __construct( $args = array() ) {`
`44`	`44`	`parent::__construct(`
`45`	`45`	`array(`
`46`	`46`	`'plural' => 'sites',`
`47`		`- 'screen' => isset( $args['screen'] ) ? $args['screen'] : null,`
	`47`	`+ 'screen' => $args['screen'] ?? null,`
`48`	`48`	`)`
`49`	`49`	`);`
`50`	`50`	`}`
`@@ -135,7 +135,7 @@ public function prepare_items() {`
`135`	`135`	`}`
`136`	`136`	`}`
`137`	`137`
`138`		`- $order_by = isset( $_REQUEST['orderby'] ) ? $_REQUEST['orderby'] : '';`
	`138`	`+ $order_by = $_REQUEST['orderby'] ?? '';`
`139`	`139`	`if ( 'registered' === $order_by ) {`
`140`	`140`	`// 'registered' is a valid field name.`
`141`	`141`	`} elseif ( 'lastupdated' === $order_by ) {`
Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,7 @@ function edit_user( $user_id = 0 ) {`
`62`	`62`	`wp_die( __( 'Sorry, you are not allowed to give users that role.' ), 403 );`
`63`	`63`	`}`
`64`	`64`
`65`		`- $potential_role = isset( $wp_roles->role_objects[ $new_role ] ) ? $wp_roles->role_objects[ $new_role ] : false;`
	`65`	`+ $potential_role = $wp_roles->role_objects[ $new_role ] ?? false;`
`66`	`66`
`67`	`67`	`/*`
`68`	`68`	`* Don't let anyone with 'promote_users' edit their own role to something without it.`
Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@`
`17`	`17`	`wp_die( __( 'Sorry, you are not allowed to access this page.' ) );`
`18`	`18`	`}`
`19`	`19`
`20`		`-$action = isset( $_POST['action'] ) ? $_POST['action'] : 'splash';`
	`20`	`+$action = $_POST['action'] ?? 'splash';`
`21`	`21`
`22`	`22`	`$blogs = get_blogs_of_user( $current_user->ID );`
`23`	`23`