Skip to content

Commit 1c02e68

Browse files
committed
Build/Test: Update assertions in AtomParser_Parse_Test::test_parse_sets_handlers
On some instances of Windows, the assertions seem to find additional nodes. As this test is just about verifying that the handlers get called, not about testing the functionality of the handlers, we can adjust the assertion to look for a minimum number of nodes rather than exact number. Follow-up to [59062]. Reviewed by desrosj. Merges [59739] to the 6.7 branch. Props yogeshbhutkar, hellofromTonya, SergeyBiryukov, coquardcyr, jrf, benniledl, desrosj, jorbin. Fixes #62110. See #62061. git-svn-id: https://develop.svn.wordpress.org/branches/6.7@59745 602fd350-edb4-49c9-b593-d223f7449a82
1 parent 2b063ba commit 1c02e68

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

tests/phpunit/tests/atomlib/AtomParser_Parse_Test.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,8 @@ public function _default( $parser, $data ) {
6868
$this->assertSame( 28, $atom->start_element_call_counter, sprintf( $msg, 'start_element' ) );
6969
$this->assertSame( 28, $atom->end_element_call_counter, sprintf( $msg, 'end_element' ) );
7070
$this->assertSame( 2, $atom->start_ns_call_counter, sprintf( $msg, 'start_ns' ) );
71-
$this->assertSame( 0, $atom->end_ns_call_counter, sprintf( $msg, 'end_ns' ) );
72-
$this->assertSame( 57, $atom->cdata_call_counter, sprintf( $msg, 'cdata' ) );
73-
$this->assertSame( 2, $atom->default_call_counter, sprintf( $msg, '_default' ) );
71+
$this->assertGreaterThanOrEqual( 0, $atom->end_ns_call_counter, sprintf( $msg, 'end_ns' ) );
72+
$this->assertGreaterThanOrEqual( 57, $atom->cdata_call_counter, sprintf( $msg, 'cdata' ) );
73+
$this->assertGreaterThanOrEqual( 2, $atom->default_call_counter, sprintf( $msg, '_default' ) );
7474
}
7575
}

0 commit comments

Comments
 (0)