Skip to content

Commit 1cb2ed2

Browse files
committed
Posts, Post Types: Remove title attribute from the_shortlink().
Since [13683], `the_shortlink()` has included a `title` attribute. By default, that gives the sanitized post title, and it does not sanitize custom text. Given the low value of this attribute, this changeset removes it. Props sabernhardt, audrasjb, joedolson. Fixes #62838. See #24766. git-svn-id: https://develop.svn.wordpress.org/trunk@59703 602fd350-edb4-49c9-b593-d223f7449a82
1 parent a3f0f60 commit 1cb2ed2

File tree

1 file changed

+7
-10
lines changed

1 file changed

+7
-10
lines changed

src/wp-includes/link-template.php

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -4247,11 +4247,12 @@ function wp_shortlink_header() {
42474247
* Call like the_shortlink( __( 'Shortlinkage FTW' ) )
42484248
*
42494249
* @since 3.0.0
4250+
* @since 6.8.0 Removed title attribute.
42504251
*
4251-
* @param string $text Optional The link text or HTML to be displayed. Defaults to 'This is the short link.'
4252-
* @param string $title Optional The tooltip for the link. Must be sanitized. Defaults to the sanitized post title.
4253-
* @param string $before Optional HTML to display before the link. Default empty.
4254-
* @param string $after Optional HTML to display after the link. Default empty.
4252+
* @param string $text Optional. The link text or HTML to be displayed. Defaults to 'This is the short link.'
4253+
* @param string $title Unused.
4254+
* @param string $before Optional. HTML to display before the link. Default empty.
4255+
* @param string $after Optional. HTML to display after the link. Default empty.
42554256
*/
42564257
function the_shortlink( $text = '', $title = '', $before = '', $after = '' ) {
42574258
$post = get_post();
@@ -4260,14 +4261,10 @@ function the_shortlink( $text = '', $title = '', $before = '', $after = '' ) {
42604261
$text = __( 'This is the short link.' );
42614262
}
42624263

4263-
if ( empty( $title ) ) {
4264-
$title = the_title_attribute( array( 'echo' => false ) );
4265-
}
4266-
42674264
$shortlink = wp_get_shortlink( $post->ID );
42684265

42694266
if ( ! empty( $shortlink ) ) {
4270-
$link = '<a rel="shortlink" href="' . esc_url( $shortlink ) . '" title="' . $title . '">' . $text . '</a>';
4267+
$link = '<a rel="shortlink" href="' . esc_url( $shortlink ) . '">' . $text . '</a>';
42714268

42724269
/**
42734270
* Filters the short link anchor tag for a post.
@@ -4277,7 +4274,7 @@ function the_shortlink( $text = '', $title = '', $before = '', $after = '' ) {
42774274
* @param string $link Shortlink anchor tag.
42784275
* @param string $shortlink Shortlink URL.
42794276
* @param string $text Shortlink's text.
4280-
* @param string $title Shortlink's title attribute.
4277+
* @param string $title Shortlink's title attribute. Unused.
42814278
*/
42824279
$link = apply_filters( 'the_shortlink', $link, $shortlink, $text, $title );
42834280
echo $before, $link, $after;

0 commit comments

Comments
 (0)