Post Types: Add 'at_a_glance' property and update dashboard widget logic. Refresh: 45035.diff

Author: SirLouen

src/wp-admin/includes/dashboard.php

@@ -302,22 +302,25 @@ function wp_dashboard_right_now() {
 	<div class="main">
 	<ul>
 	<?php
-	// Posts and Pages.
-	foreach ( array( 'post', 'page' ) as $post_type ) {
-		$num_posts = wp_count_posts( $post_type );
-
-		if ( $num_posts && $num_posts->publish ) {
-			if ( 'post' === $post_type ) {
-				/* translators: %s: Number of posts. */
-				$text = _n( '%s Post', '%s Posts', $num_posts->publish );
-			} else {
-				/* translators: %s: Number of pages. */
-				$text = _n( '%s Page', '%s Pages', $num_posts->publish );
-			}
+	// At a Glance Post Types.
+	foreach ( get_post_types( array( 'at_a_glance' => true ) ) as $post_type ) {
+		$num_posts          = wp_count_posts( $post_type );
+		$num_post_published = intval( $num_posts->publish );
 
-			$text             = sprintf( $text, number_format_i18n( $num_posts->publish ) );
+		if ( $num_posts && $num_post_published ) {
 			$post_type_object = get_post_type_object( $post_type );
 
+			if ( ! $post_type_object ) {
+				continue;
+			}
+			if ( 1 === $num_post_published ) {
+				$post_label = $post_type_object->labels->singular_name;
+			} else {
+				$post_label = $post_type_object->labels->name;
+			}
+			/* translators: %d: Number of posts, %s post label. */
+			$text = sprintf( '%d %s', number_format_i18n( $num_post_published ), $post_label );
+
 			if ( $post_type_object && current_user_can( $post_type_object->cap->edit_posts ) ) {
 				printf( '<li class="%1$s-count"><a href="edit.php?post_type=%1$s">%2$s</a></li>', $post_type, $text );
 			} else {

src/wp-includes/class-wp-post-type.php

@@ -147,6 +147,15 @@ final class WP_Post_Type {
 	 */
 	public $show_in_menu = null;
 
+	/**
+	 * Makes this post type visible in the At a Glance dashboard widget.
+	 *
+	 * Default is the value of $show_in_menu.
+	 *
+	 * @var bool $at_a_glance
+	 */
+	public $at_a_glance = null;
+
 	/**
 	 * Makes this post type available for selection in navigation menus.
 	 *
@@ -553,6 +562,7 @@ public function set_props( $args ) {
 			'rest_base'                       => false,
 			'rest_namespace'                  => false,
 			'rest_controller_class'           => false,
+			'at_a_glance'                     => null,
 			'autosave_rest_controller_class'  => false,
 			'revisions_rest_controller_class' => false,
 			'late_route_registration'         => false,
@@ -591,6 +601,11 @@ public function set_props( $args ) {
 			$args['show_in_menu'] = $args['show_ui'];
 		}
 
+		// If not set, default to the setting for show_in_menu
+		if ( null === $args['at_a_glance'] ) {
+			$args['at_a_glance'] = (bool) $args['show_in_menu'];
+		}
+
 		// If not set, default to the setting for 'show_in_menu'.
 		if ( null === $args['show_in_admin_bar'] ) {
 			$args['show_in_admin_bar'] = (bool) $args['show_in_menu'];

src/wp-includes/post.php

@@ -103,6 +103,7 @@ function create_initial_post_types() {
 			),
 			'public'                => true,
 			'show_ui'               => true,
+			'at_a_glance'           => false,
 			'_builtin'              => true, /* internal use only. don't use this when registering your own post type. */
 			'_edit_link'            => 'post.php?post=%d', /* internal use only. don't use this when registering your own post type. */
 			'capability_type'       => 'post',

tests/phpunit/tests/post/types.php

@@ -676,4 +676,24 @@ public function test_register_post_type_override_is_embeddable() {
 		);
 		$this->assertFalse( $post_type->embeddable, 'Post type should not be embeddable even though it is public' );
 	}
+
+	/**
+	 * @ticket 45035
+	 * @covers ::register_post_type()
+	 */
+	public function test_register_post_type_at_a_glance_should_default_to_value_of_show_in_menu() {
+		/*
+		 * 'public'       Default is false
+		 * 'show_ui'      Default is null ('public')
+		 * 'show_in_menu' Default is null ('show_ui' > 'public')
+		 * 'at_a_glance'  Default is null ('show_in_menu' > 'show_ui' > 'public')
+		 */
+		$args = register_post_type( $this->post_type, array( 'public' => $public = false ) );
+		// Should fall back to 'show_in_menu'.
+		$this->assertSame( $args->show_in_menu, $args->at_a_glance );
+		// Should fall back to 'show_ui'.
+		$this->assertSame( $args->show_ui, $args->at_a_glance );
+		// Should fall back to 'public'.
+		$this->assertSame( $public, $args->at_a_glance );
+	}
 }