Skip to content

Commit 268eac2

Browse files
Code Modernization: Rename parameters that use reserved keywords in phpunit/tests/customize/manager.php.
While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names. This commit: * Renames the `$class` parameter to `$setting_class` in: * `Tests_WP_Customize_Manager::return_dynamic_customize_setting_class()` * `Tests_WP_Customize_Manager::return_dynamic_customize_setting_args()` * Amends the `$args` and `$id` parameters in both methods for consistency. * Corrects the DocBlock for `::return_dynamic_customize_setting_args()`. Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192], [53193], [53198], [53203], [53207], [53215], [53216], [53220], [53230], [53232], [53236], [53239], [53240], [53242], [53243], [53245], [53246], [53257], [53269], [53270], [53271], [53272], [53273], [53274], [53275], [53276], [53277], [53281], [53283], [53284], [53285], [53287], [53364], [53365], [54927], [54929], [54930], [54931], [54932], [54933], [54938], [54943], [54944], [54945], [54946], [54947], [54948], [54950], [54951], [54952], [54956], [54959], [54960], [54961], [54962], [54964], [54965], [54969], [54970], [54971], [54972], [54996], [55000], [55011], [55013], [55014], [55015], [55016], [55017], [55020], [55021], [55023], [55027], [55028], [55034], [55036], [55037], [55038]. Props jrf, aristath, poena, justinahinon, SergeyBiryukov. See #56788. git-svn-id: https://develop.svn.wordpress.org/trunk@55039 602fd350-edb4-49c9-b593-d223f7449a82
1 parent 199f332 commit 268eac2

File tree

1 file changed

+18
-18
lines changed

1 file changed

+18
-18
lines changed

tests/phpunit/tests/customize/manager.php

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -3351,33 +3351,33 @@ public function test_add_setting_honoring_dynamic() {
33513351
}
33523352

33533353
/**
3354-
* Return 'Test_Dynamic_Customize_Setting' in 'customize_dynamic_setting_class.
3354+
* Returns 'Test_Dynamic_Customize_Setting' in 'customize_dynamic_setting_class'.
33553355
*
3356-
* @param string $class Setting class.
3357-
* @param array $args Setting args.
3358-
* @param string $id Setting ID.
3359-
* @return string Setting class.
3356+
* @param string $setting_class Setting class.
3357+
* @param array $setting_args Setting args.
3358+
* @param string $setting_id Setting ID.
3359+
* @return string Setting class.
33603360
*/
3361-
public function return_dynamic_customize_setting_class( $class, $id, $args ) {
3362-
unset( $args );
3363-
if ( 0 === strpos( $id, 'dynamic' ) ) {
3364-
$class = 'Test_Dynamic_Customize_Setting';
3361+
public function return_dynamic_customize_setting_class( $setting_class, $setting_id, $setting_args ) {
3362+
unset( $setting_args );
3363+
if ( 0 === strpos( $setting_id, 'dynamic' ) ) {
3364+
$setting_class = 'Test_Dynamic_Customize_Setting';
33653365
}
3366-
return $class;
3366+
return $setting_class;
33673367
}
33683368

33693369
/**
3370-
* Return 'Test_Dynamic_Customize_Setting' in 'customize_dynamic_setting_class.
3370+
* Returns 'foo' in 'customize_dynamic_setting_args'.
33713371
*
3372-
* @param array $args Setting args.
3373-
* @param string $id Setting ID.
3374-
* @return string Setting args.
3372+
* @param array $setting_args Setting args.
3373+
* @param string $setting_id Setting ID.
3374+
* @return array Setting args.
33753375
*/
3376-
public function return_dynamic_customize_setting_args( $args, $id ) {
3377-
if ( 0 === strpos( $id, 'dynamic' ) ) {
3378-
$args['custom'] = 'foo';
3376+
public function return_dynamic_customize_setting_args( $setting_args, $setting_id ) {
3377+
if ( 0 === strpos( $setting_id, 'dynamic' ) ) {
3378+
$setting_args['custom'] = 'foo';
33793379
}
3380-
return $args;
3380+
return $setting_args;
33813381
}
33823382

33833383
/**

0 commit comments

Comments
 (0)