Replace wp_cache_add() with wp_cache_set() across query classes

Updated multiple query classes to use wp_cache_set() instead of wp_cache_add() for handling cache storage. This ensures that existing cache entries are overridden as intended, improving consistency and preventing potential caching issues.

Author: spacedmonkey

src/wp-includes/class-wp-comment-query.php

@@ -464,7 +464,7 @@ public function get_comments() {
 				'found_comments' => $this->found_comments,
 				'last_changed'   => $last_changed,
 			);
-			wp_cache_add( $cache_key, $cache_value, 'comment-queries' );
+			wp_cache_set( $cache_key, $cache_value, 'comment-queries' );
 		} else {
 			$comment_ids          = $cache_value['comment_ids'];
 			$this->found_comments = $cache_value['found_comments'];

src/wp-includes/class-wp-network-query.php

@@ -263,7 +263,7 @@ public function get_networks() {
 				'found_networks' => $this->found_networks,
 				'last_changed' => $last_changed,
 			);
-			wp_cache_add( $cache_key, $cache_value, 'network-queries' );
+			wp_cache_set( $cache_key, $cache_value, 'network-queries' );
 		} else {
 			$network_ids          = $cache_value['network_ids'];
 			$this->found_networks = $cache_value['found_networks'];

src/wp-includes/class-wp-query.php

@@ -2892,7 +2892,7 @@ public function get_posts() {
 					'comment_ids'  => $comment_ids,
 					'last_changed' => $last_changed,
 				);
-				wp_cache_add( $cache_key, $cache_value, 'comment-queries' );
+				wp_cache_set( $cache_key, $cache_value, 'comment-queries' );
 			} else {
 				$comment_ids = $cache_value['comment_ids'];
 			}
@@ -3508,7 +3508,7 @@ public function get_posts() {
 					'comment_ids'  => $comment_ids,
 					'last_changed' => $comment_last_changed,
 				);
-				wp_cache_add( $comment_cache_key, $cache_value, 'comment-queries' );
+				wp_cache_set( $comment_cache_key, $cache_value, 'comment-queries' );
 			} else {
 				$comment_ids = $cache_value['comment_ids'];
 			}

src/wp-includes/class-wp-site-query.php

@@ -371,7 +371,7 @@ public function get_sites() {
 				'found_sites'  => $this->found_sites,
 				'last_changed' => $last_changed,
 			);
-			wp_cache_add( $cache_key, $cache_value, 'site-queries' );
+			wp_cache_set( $cache_key, $cache_value, 'site-queries' );
 		} else {
 			$site_ids          = $cache_value['site_ids'];
 			$this->found_sites = $cache_value['found_sites'];

src/wp-includes/class-wp-user-query.php

@@ -898,7 +898,7 @@ public function query() {
 						'total_users'  => $this->total_users,
 						'last_changed' => $last_changed,
 					);
-					wp_cache_add( $cache_key, $cache_value, $cache_group );
+					wp_cache_set( $cache_key, $cache_value, $cache_group );
 				}
 			}
 		}