Coding Standards: Remove extra check in WP_Comment_Query::get_comment_ids().

SergeyBiryukov · SergeyBiryukov · commit 357d8ec846ee · 2025-06-07T15:07:55.000Z
The preceding `foreach` loop ensures that `$status_clauses` is a non-empty array. Follow-up to [30084]. Props justlevine. See #63268. git-svn-id: https://develop.svn.wordpress.org/trunk@60291 602fd350-edb4-49c9-b593-d223f7449a82
diff --git a/src/wp-includes/class-wp-comment-query.php b/src/wp-includes/class-wp-comment-query.php
@@ -579,9 +579,7 @@ protected function get_comment_ids() {
 				}
 			}
 
-			if ( ! empty( $status_clauses ) ) {
-				$approved_clauses[] = '( ' . implode( ' OR ', $status_clauses ) . ' )';
-			}
+			$approved_clauses[] = '( ' . implode( ' OR ', $status_clauses ) . ' )';
 		}
 
 		// User IDs or emails whose unapproved comments are included, regardless of $status.

Original file line number	Diff line number	Diff line change
`@@ -579,9 +579,7 @@ protected function get_comment_ids() {`
`579`	`579`	`}`
`580`	`580`	`}`
`581`	`581`
`582`		`- if ( ! empty( $status_clauses ) ) {`
`583`		`- $approved_clauses[] = '( ' . implode( ' OR ', $status_clauses ) . ' )';`
`584`		`- }`
	`582`	`+ $approved_clauses[] = '( ' . implode( ' OR ', $status_clauses ) . ' )';`
`585`	`583`	`}`
`586`	`584`
`587`	`585`	`// User IDs or emails whose unapproved comments are included, regardless of $status.`