Privacy: Set $request->confirm_key earlier so it can be reused in 2 places.

This commit updates the `wp_send_user_request()` function so that the updated confirmation key of the request is  available to both the confirmation URL and the subsequent filters (specifically `user_request_action_email_content`).

This maintains the existing behavior of generating a new key just-in-time before every user request email is sent.

Props birgire, dingo_d, garrett-eclipse, johnjamesjacoby.

Fixes #44940.

git-svn-id: https://develop.svn.wordpress.org/trunk@61137 602fd350-edb4-49c9-b593-d223f7449a82

Author: JJJ

src/wp-includes/user.php

@@ -4844,6 +4844,13 @@ function wp_send_user_request( $request_id ) {
 		$switched_locale = switch_to_locale( get_locale() );
 	}
 
+	/*
+	 * Generate the new user request key first, as it is used by both the $request
+	 * object and the confirm_url array.
+	 * See https://core.trac.wordpress.org/ticket/44940
+	 */
+	$request->confirm_key = wp_generate_user_request_key( $request_id );
+
 	$email_data = array(
 		'request'     => $request,
 		'email'       => $request->email,
@@ -4852,7 +4859,7 @@ function wp_send_user_request( $request_id ) {
 			array(
 				'action'      => 'confirmaction',
 				'request_id'  => $request_id,
-				'confirm_key' => wp_generate_user_request_key( $request_id ),
+				'confirm_key' => $request->confirm_key,
 			),
 			wp_login_url()
 		),