Skip to content

Commit 39ca910

Browse files
committed
Twenty Eleven: Fix post navigation to respect sort order.
Change the labels on post navigation links when the sort order is changed so the labels accurately reflect the target entries. Previously, if the sort order was reversed, 'Older' or 'Previous' links would navigate to newer entries and 'Newer' or 'Next' links would navigate to older entries. Props jikamens, dancameron, obenland, denis-de-bernardy, nacin, chriscct7, shreya0shrivastava, sirlouen, sabernhardt, shailu25, westonruter, joedolson. See #10219. git-svn-id: https://develop.svn.wordpress.org/trunk@61096 602fd350-edb4-49c9-b593-d223f7449a82
1 parent 0a7af8d commit 39ca910

File tree

1 file changed

+17
-4
lines changed

1 file changed

+17
-4
lines changed

src/wp-content/themes/twentyeleven/functions.php

Lines changed: 17 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -642,14 +642,27 @@ function twentyeleven_content_nav( $html_id ) {
642642
global $wp_query;
643643

644644
if ( $wp_query->max_num_pages > 1 ) :
645+
$order = get_query_var( 'order', 'DESC' );
646+
$is_desc = ( 'DESC' === $order );
647+
648+
$new_posts_text = __( 'Newer posts <span class="meta-nav">&rarr;</span>', 'twentyeleven' );
649+
$old_posts_text = __( '<span class="meta-nav">&larr;</span> Older posts', 'twentyeleven' );
650+
651+
$prev_link = $is_desc ? get_next_posts_link( $old_posts_text ) : get_previous_posts_link( $old_posts_text );
652+
$next_link = $is_desc ? get_previous_posts_link( $new_posts_text ) : get_next_posts_link( $new_posts_text );
645653
?>
646654
<nav id="<?php echo esc_attr( $html_id ); ?>">
647655
<h3 class="assistive-text"><?php _e( 'Post navigation', 'twentyeleven' ); ?></h3>
648-
<div class="nav-previous"><?php next_posts_link( __( '<span class="meta-nav">&larr;</span> Older posts', 'twentyeleven' ) ); ?></div>
649-
<div class="nav-next"><?php previous_posts_link( __( 'Newer posts <span class="meta-nav">&rarr;</span>', 'twentyeleven' ) ); ?></div>
650-
</nav><!-- #nav-above -->
656+
<?php if ( $prev_link ) : ?>
657+
<div class="nav-previous"><?php echo $prev_link; ?></div>
658+
<?php endif; ?>
659+
660+
<?php if ( $next_link ) : ?>
661+
<div class="nav-next"><?php echo $next_link; ?></div>
662+
<?php endif; ?>
663+
</nav><!-- #<?php echo esc_attr( $html_id ); ?> -->
651664
<?php
652-
endif;
665+
endif;
653666
}
654667
endif; // twentyeleven_content_nav()
655668

0 commit comments

Comments
 (0)