Skip to content

Commit 3b79c25

Browse files
desrosjdesrosj
committed
Grouped backports for the 6.5 branch.
- REST API: Increase the specificity of capability checks for collections when the `edit` context is in use. - Menus: Prevent HTML in menu item titles from being rendered unexpectedly. Merges [60814], [60815], [60816] to the 6.5 branch. Props andraganescu, desrosj, ehti, hurayraiit, iandunn, joehoyle, johnbillion, jorbin, mnelson4, noisysocks, peterwilsoncc, phillsav, rmccue, timothyblynjacobs, vortfu, westonruter , whyisjake, zieladam. git-svn-id: https://develop.svn.wordpress.org/branches/6.5@60821 602fd350-edb4-49c9-b593-d223f7449a82
1 parent 978249a commit 3b79c25

File tree

10 files changed

+145
-92
lines changed

10 files changed

+145
-92
lines changed

‎src/js/_enqueues/lib/nav-menu.js‎

Lines changed: 27 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1009,13 +1009,18 @@
10091009
}
10101010

10111011
if ( this.checked === true ) {
1012-
$( '#pending-menu-items-to-delete ul' ).append(
1013-
'<li data-menu-item-id="' + menuItemID + '">' +
1014-
'<span class="pending-menu-item-name">' + menuItemName + '</span> ' +
1015-
'<span class="pending-menu-item-type">(' + menuItemType + ')</span>' +
1016-
'<span class="separator"></span>' +
1017-
'</li>'
1018-
);
1012+
const $li = $( '<li>', { 'data-menu-item-id': menuItemID } );
1013+
$li.append( $( '<span>', {
1014+
'class': 'pending-menu-item-name',
1015+
text: menuItemName
1016+
} ) );
1017+
$li.append( ' ' );
1018+
$li.append( $( '<span>', {
1019+
'class': 'pending-menu-item-type',
1020+
text: '(' + menuItemType + ')',
1021+
} ) );
1022+
$li.append( $( '<span>', { 'class': 'separator' } ) );
1023+
$( '#pending-menu-items-to-delete ul' ).append( $li );
10191024
}
10201025

10211026
$( '#pending-menu-items-to-delete li .separator' ).html( ', ' );
@@ -1404,20 +1409,26 @@
14041409
},
14051410

14061411
eventOnClickMenuSave : function() {
1407-
var locs = '',
1408-
menuName = $('#menu-name'),
1409-
menuNameVal = menuName.val();
1412+
var menuName = $('#menu-name'),
1413+
menuNameVal = menuName.val();
14101414

14111415
// Cancel and warn if invalid menu name.
14121416
if ( ! menuNameVal || ! menuNameVal.replace( /\s+/, '' ) ) {
14131417
menuName.parent().addClass( 'form-invalid' );
14141418
return false;
14151419
}
14161420
// Copy menu theme locations.
1421+
// Note: This appears to be dead code since #nav-menu-theme-locations no longer exists, perhaps removed in r32842.
1422+
var $updateNavMenu = $('#update-nav-menu');
14171423
$('#nav-menu-theme-locations select').each(function() {
1418-
locs += '<input type="hidden" name="' + this.name + '" value="' + $(this).val() + '" />';
1424+
$updateNavMenu.append(
1425+
$( '<input>', {
1426+
type: 'hidden',
1427+
name: this.name,
1428+
value: $( this ).val(),
1429+
} )
1430+
);
14191431
});
1420-
$('#update-nav-menu').append( locs );
14211432
// Update menu item position data.
14221433
api.menuList.find('.menu-item-data-position').val( function(index) { return index + 1; } );
14231434
window.onbeforeunload = null;
@@ -1460,7 +1471,10 @@
14601471
$item;
14611472

14621473
if( ! $items.length ) {
1463-
$('.categorychecklist', panel).html( '<li><p>' + wp.i18n.__( 'No results found.' ) + '</p></li>' );
1474+
const li = $( '<li>' );
1475+
const p = $( '<p>', { text: wp.i18n.__( 'No results found.' ) } );
1476+
li.append( p );
1477+
$('.categorychecklist', panel).empty().append( li );
14641478
$( '.spinner', panel ).removeClass( 'is-active' );
14651479
wrapper.addClass( 'has-no-menu-item' );
14661480
return;

‎src/js/_enqueues/wp/customize/nav-menus.js‎

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -526,7 +526,13 @@
526526
return;
527527
}
528528

529-
this.currentMenuControl.addItemToMenu( menu_item.attributes );
529+
// Leave the title as empty to reuse the original title as a placeholder if set.
530+
var nav_menu_item = Object.assign( {}, menu_item.attributes );
531+
if ( nav_menu_item.title === nav_menu_item.original_title ) {
532+
nav_menu_item.title = '';
533+
}
534+
535+
this.currentMenuControl.addItemToMenu( nav_menu_item );
530536

531537
$( menuitemTpl ).find( '.menu-item-handle' ).addClass( 'item-added' );
532538
},
@@ -3033,7 +3039,6 @@
30333039
item,
30343040
{
30353041
nav_menu_term_id: menuControl.params.menu_id,
3036-
original_title: item.title,
30373042
position: position
30383043
}
30393044
);

‎src/wp-includes/class-wp-customize-nav-menus.php‎

Lines changed: 26 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -191,13 +191,15 @@ public function load_available_items_query( $object_type = 'post_type', $object_
191191
}
192192
} elseif ( 'post' !== $object_name && 0 === $page && $post_type->has_archive ) {
193193
// Add a post type archive link.
194+
$title = $post_type->labels->archives;
194195
$items[] = array(
195-
'id' => $object_name . '-archive',
196-
'title' => $post_type->labels->archives,
197-
'type' => 'post_type_archive',
198-
'type_label' => __( 'Post Type Archive' ),
199-
'object' => $object_name,
200-
'url' => get_post_type_archive_link( $object_name ),
196+
'id' => $object_name . '-archive',
197+
'title' => $title,
198+
'original_title' => $title,
199+
'type' => 'post_type_archive',
200+
'type_label' => __( 'Post Type Archive' ),
201+
'object' => $object_name,
202+
'url' => get_post_type_archive_link( $object_name ),
201203
);
202204
}
203205

@@ -244,14 +246,16 @@ public function load_available_items_query( $object_type = 'post_type', $object_
244246
$post_type_label = implode( ',', $post_states );
245247
}
246248

249+
$title = html_entity_decode( $post_title, ENT_QUOTES, get_bloginfo( 'charset' ) );
247250
$items[] = array(
248-
'id' => "post-{$post->ID}",
249-
'title' => html_entity_decode( $post_title, ENT_QUOTES, get_bloginfo( 'charset' ) ),
250-
'type' => 'post_type',
251-
'type_label' => $post_type_label,
252-
'object' => $post->post_type,
253-
'object_id' => (int) $post->ID,
254-
'url' => get_permalink( (int) $post->ID ),
251+
'id' => "post-{$post->ID}",
252+
'title' => $title,
253+
'original_title' => $title,
254+
'type' => 'post_type',
255+
'type_label' => $post_type_label,
256+
'object' => $post->post_type,
257+
'object_id' => (int) $post->ID,
258+
'url' => get_permalink( (int) $post->ID ),
255259
);
256260
}
257261
} elseif ( 'taxonomy' === $object_type ) {
@@ -276,14 +280,16 @@ public function load_available_items_query( $object_type = 'post_type', $object_
276280
}
277281

278282
foreach ( $terms as $term ) {
283+
$title = html_entity_decode( $term->name, ENT_QUOTES, get_bloginfo( 'charset' ) );
279284
$items[] = array(
280-
'id' => "term-{$term->term_id}",
281-
'title' => html_entity_decode( $term->name, ENT_QUOTES, get_bloginfo( 'charset' ) ),
282-
'type' => 'taxonomy',
283-
'type_label' => get_taxonomy( $term->taxonomy )->labels->singular_name,
284-
'object' => $term->taxonomy,
285-
'object_id' => (int) $term->term_id,
286-
'url' => get_term_link( (int) $term->term_id, $term->taxonomy ),
285+
'id' => "term-{$term->term_id}",
286+
'title' => $title,
287+
'original_title' => $title,
288+
'type' => 'taxonomy',
289+
'type_label' => get_taxonomy( $term->taxonomy )->labels->singular_name,
290+
'object' => $term->taxonomy,
291+
'object_id' => (int) $term->term_id,
292+
'url' => get_term_link( (int) $term->term_id, $term->taxonomy ),
287293
);
288294
}
289295
}

‎src/wp-includes/customize/class-wp-customize-nav-menu-item-setting.php‎

Lines changed: 28 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,6 @@ class WP_Customize_Nav_Menu_Item_Setting extends WP_Customize_Setting {
5656
'classes' => '',
5757
'xfn' => '',
5858
'status' => 'publish',
59-
'original_title' => '',
6059
'nav_menu_term_id' => 0, // This will be supplied as the $menu_id arg for wp_update_nav_menu_item().
6160
'_invalid' => false,
6261
);
@@ -210,6 +209,7 @@ public function flush_cached_value( $menu_id, $menu_item_id ) {
210209
* @return array|false Instance data array, or false if the item is marked for deletion.
211210
*/
212211
public function value() {
212+
$type_label = null;
213213
if ( $this->is_previewed && get_current_blog_id() === $this->_previewed_blog_id ) {
214214
$undefined = new stdClass(); // Symbol.
215215
$post_value = $this->post_value( $undefined );
@@ -219,9 +219,6 @@ public function value() {
219219
} else {
220220
$value = $post_value;
221221
}
222-
if ( ! empty( $value ) && empty( $value['original_title'] ) ) {
223-
$value['original_title'] = $this->get_original_title( (object) $value );
224-
}
225222
} elseif ( isset( $this->value ) ) {
226223
$value = $this->value;
227224
} else {
@@ -233,6 +230,9 @@ public function value() {
233230
if ( $post && self::POST_TYPE === $post->post_type ) {
234231
$is_title_empty = empty( $post->post_title );
235232
$value = (array) wp_setup_nav_menu_item( $post );
233+
if ( isset( $value['type_label'] ) ) {
234+
$type_label = $value['type_label'];
235+
}
236236
if ( $is_title_empty ) {
237237
$value['title'] = '';
238238
}
@@ -249,20 +249,39 @@ public function value() {
249249
$value = $this->value;
250250
}
251251

252-
if ( ! empty( $value ) && empty( $value['type_label'] ) ) {
253-
$value['type_label'] = $this->get_type_label( (object) $value );
252+
// These properties are read-only and are part of the setting for use in the Customizer UI.
253+
if ( is_array( $value ) ) {
254+
$value_obj = (object) $value;
255+
$value['type_label'] = isset( $type_label ) ? $type_label : $this->get_type_label( $value_obj );
256+
$value['original_title'] = $this->get_original_title( $value_obj );
254257
}
255258

256259
return $value;
257260
}
258261

262+
/**
263+
* Prepares the value for editing on the client.
264+
*
265+
* @since 6.8.3
266+
*
267+
* @return array|false Value prepared for the client.
268+
*/
269+
public function js_value() {
270+
$value = parent::js_value();
271+
if ( is_array( $value ) && isset( $value['original_title'] ) ) {
272+
// Decode entities for the sake of displaying the original title as a placeholder.
273+
$value['original_title'] = html_entity_decode( $value['original_title'], ENT_QUOTES, get_bloginfo( 'charset' ) );
274+
}
275+
return $value;
276+
}
277+
259278
/**
260279
* Get original title.
261280
*
262281
* @since 4.7.0
263282
*
264283
* @param object $item Nav menu item.
265-
* @return string The original title.
284+
* @return string The original title, without entity decoding.
266285
*/
267286
protected function get_original_title( $item ) {
268287
$original_title = '';
@@ -288,7 +307,6 @@ protected function get_original_title( $item ) {
288307
$original_title = $original_object->labels->archives;
289308
}
290309
}
291-
$original_title = html_entity_decode( $original_title, ENT_QUOTES, get_bloginfo( 'charset' ) );
292310
return $original_title;
293311
}
294312

@@ -346,10 +364,6 @@ protected function populate_value() {
346364
unset( $this->value['post_status'] );
347365
}
348366

349-
if ( ! isset( $this->value['original_title'] ) ) {
350-
$this->value['original_title'] = $this->get_original_title( (object) $this->value );
351-
}
352-
353367
if ( ! isset( $this->value['nav_menu_term_id'] ) && $this->post_id > 0 ) {
354368
$menus = wp_get_post_terms(
355369
$this->post_id,
@@ -594,11 +608,8 @@ public function value_as_wp_post_nav_menu_item() {
594608
$item->menu_order = $item->position;
595609
unset( $item->position );
596610

597-
if ( empty( $item->original_title ) ) {
598-
$item->original_title = $this->get_original_title( $item );
599-
}
600611
if ( empty( $item->title ) && ! empty( $item->original_title ) ) {
601-
$item->title = $item->original_title;
612+
$item->title = $item->original_title; // This is NOT entity-decoded. It comes from self::get_original_title().
602613
}
603614
if ( $item->title ) {
604615
$item->post_title = $item->title;
@@ -654,7 +665,7 @@ public function value_as_wp_post_nav_menu_item() {
654665
* @since 4.3.0
655666
* @since 5.9.0 Renamed `$menu_item_value` to `$value` for PHP 8 named parameter support.
656667
*
657-
* @param array $value The menu item value to sanitize.
668+
* @param array|false $value The menu item value to sanitize.
658669
* @return array|false|null|WP_Error Null or WP_Error if an input isn't valid. False if it is marked for deletion.
659670
* Otherwise the sanitized value.
660671
*/
@@ -711,8 +722,6 @@ public function sanitize( $value ) {
711722
$menu_item_value[ $key ] = implode( ' ', array_map( 'sanitize_html_class', $value ) );
712723
}
713724

714-
$menu_item_value['original_title'] = sanitize_text_field( $menu_item_value['original_title'] );
715-
716725
// Apply the same filters as when calling wp_insert_post().
717726

718727
/** This filter is documented in wp-includes/post.php */

‎src/wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php‎

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -378,7 +378,13 @@ public function get_items( $request ) {
378378
}
379379

380380
foreach ( $query_result as $post ) {
381-
if ( ! $this->check_read_permission( $post ) ) {
381+
if ( 'edit' === $request['context'] ) {
382+
$permission = $this->check_update_permission( $post );
383+
} else {
384+
$permission = $this->check_read_permission( $post );
385+
}
386+
387+
if ( ! $permission ) {
382388
continue;
383389
}
384390

‎src/wp-includes/rest-api/endpoints/class-wp-rest-terms-controller.php‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -340,6 +340,10 @@ public function get_items( $request ) {
340340
$response = array();
341341

342342
foreach ( $query_result as $term ) {
343+
if ( 'edit' === $request['context'] && ! current_user_can( 'edit_term', $term->term_id ) ) {
344+
continue;
345+
}
346+
343347
$data = $this->prepare_item_for_response( $term, $request );
344348
$response[] = $this->prepare_response_for_collection( $data );
345349
}

‎src/wp-includes/rest-api/endpoints/class-wp-rest-users-controller.php‎

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,7 @@ public function get_items_permissions_check( $request ) {
210210
if ( 'edit' === $request['context'] && ! current_user_can( 'list_users' ) ) {
211211
return new WP_Error(
212212
'rest_forbidden_context',
213-
__( 'Sorry, you are not allowed to list users.' ),
213+
__( 'Sorry, you are not allowed to edit users.' ),
214214
array( 'status' => rest_authorization_required_code() )
215215
);
216216
}
@@ -340,6 +340,10 @@ public function get_items( $request ) {
340340
$users = array();
341341

342342
foreach ( $query->results as $user ) {
343+
if ( 'edit' === $request['context'] && ! current_user_can( 'edit_user', $user->ID ) ) {
344+
continue;
345+
}
346+
343347
$data = $this->prepare_item_for_response( $user, $request );
344348
$users[] = $this->prepare_response_for_collection( $data );
345349
}
@@ -439,13 +443,15 @@ public function get_item_permissions_check( $request ) {
439443
return true;
440444
}
441445

442-
if ( 'edit' === $request['context'] && ! current_user_can( 'list_users' ) ) {
446+
if ( 'edit' === $request['context'] && ! current_user_can( 'edit_user', $user->ID ) ) {
443447
return new WP_Error(
444-
'rest_user_cannot_view',
445-
__( 'Sorry, you are not allowed to list users.' ),
448+
'rest_forbidden_context',
449+
__( 'Sorry, you are not allowed to edit this user.' ),
446450
array( 'status' => rest_authorization_required_code() )
447451
);
448-
} elseif ( ! count_user_posts( $user->ID, $types ) && ! current_user_can( 'edit_user', $user->ID ) && ! current_user_can( 'list_users' ) ) {
452+
}
453+
454+
if ( ! current_user_can( 'edit_user', $user->ID ) && ! current_user_can( 'list_users' ) && ! count_user_posts( $user->ID, $types ) ) {
449455
return new WP_Error(
450456
'rest_user_cannot_view',
451457
__( 'Sorry, you are not allowed to list users.' ),
@@ -1040,7 +1046,7 @@ public function prepare_item_for_response( $item, $request ) {
10401046
$data['slug'] = $user->user_nicename;
10411047
}
10421048

1043-
if ( in_array( 'roles', $fields, true ) ) {
1049+
if ( in_array( 'roles', $fields, true ) && ( current_user_can( 'list_users' ) || current_user_can( 'edit_user', $user->ID ) ) ) {
10441050
// Defensively call array_values() to ensure an array is returned.
10451051
$data['roles'] = array_values( $user->roles );
10461052
}

‎tests/phpunit/tests/customize/nav-menu-item-setting.php‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,6 @@ public function test_construct() {
8989
'classes' => '',
9090
'xfn' => '',
9191
'status' => 'publish',
92-
'original_title' => '',
9392
'nav_menu_term_id' => 0,
9493
'_invalid' => false,
9594
);
@@ -581,7 +580,7 @@ public function test_sanitize() {
581580
'classes' => 'hello inject',
582581
'xfn' => 'hello inject',
583582
'status' => 'draft',
584-
'original_title' => 'Hi',
583+
'original_title' => 'Hi<script>unfilteredHtml()</script>',
585584
'nav_menu_term_id' => 0,
586585
);
587586

0 commit comments

Comments
 (0)