Skip to content

Commit 4727f52

Browse files
johnbillionjohnbillion
committed
Quote all the GitHub file paths.
1 parent b5c6517 commit 4727f52

10 files changed

+29
-29
lines changed

‎.github/workflows/reusable-coding-standards-php.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ jobs:
6262
# http://man7.org/linux/man-pages/man1/date.1.html
6363
- name: "Get last Monday's date"
6464
id: get-date
65-
run: echo date="$(/bin/date -u --date='last Mon' "+%F")" >> $GITHUB_OUTPUT
65+
run: echo date="$(/bin/date -u --date='last Mon' "+%F")" >> "$GITHUB_OUTPUT"
6666

6767
- name: Cache PHPCS scan cache
6868
uses: actions/cache@6849a6489940f00c2f30c0fb92c6274307ccb58a # v4.1.2
@@ -80,7 +80,7 @@ jobs:
8080
custom-cache-suffix: ${{ steps.get-date.outputs.date }}
8181

8282
- name: Make Composer packages available globally
83-
run: echo "${PWD}/vendor/bin" >> $GITHUB_PATH
83+
run: echo "${PWD}/vendor/bin" >> "$GITHUB_PATH"
8484

8585
- name: Run PHPCS on all Core files
8686
id: phpcs-core

‎.github/workflows/reusable-end-to-end-tests.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,8 @@ jobs:
6767
steps:
6868
- name: Configure environment variables
6969
run: |
70-
echo PHP_FPM_UID="$(id -u)" >> $GITHUB_ENV
71-
echo PHP_FPM_GID="$(id -g)" >> $GITHUB_ENV
70+
echo PHP_FPM_UID="$(id -u)" >> "$GITHUB_PATH"
71+
echo PHP_FPM_GID="$(id -g)" >> "$GITHUB_ENV"
7272
7373
- name: Checkout repository
7474
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1

‎.github/workflows/reusable-performance.yml‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -111,8 +111,8 @@ jobs:
111111
steps:
112112
- name: Configure environment variables
113113
run: |
114-
echo PHP_FPM_UID="$(id -u)" >> $GITHUB_ENV
115-
echo PHP_FPM_GID="$(id -g)" >> $GITHUB_ENV
114+
echo PHP_FPM_UID="$(id -u)" >> "$GITHUB_ENV"
115+
echo PHP_FPM_GID="$(id -g)" >> "$GITHUB_ENV"
116116
117117
- name: Checkout repository
118118
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
@@ -124,7 +124,7 @@ jobs:
124124
# The `workflow_dispatch` event is the only one missing the needed SHA to target.
125125
- name: Retrieve previous commit SHA (if necessary)
126126
if: ${{ github.event_name == 'workflow_dispatch' }}
127-
run: echo TARGET_SHA="$(git rev-parse HEAD^1)" >> $GITHUB_ENV
127+
run: echo TARGET_SHA="$(git rev-parse HEAD^1)" >> "$GITHUB_ENV"
128128

129129
- name: Set up Node.js
130130
uses: actions/setup-node@39370e3970a6d050c480ffad4ff0ed4d3fdee5af # v4.1.0
@@ -302,7 +302,7 @@ jobs:
302302
run: node ./tests/performance/compare-results.js "${RUNNER_TEMP}/summary.md"
303303

304304
- name: Add workflow summary
305-
run: cat "${RUNNER_TEMP}/summary.md" >> $GITHUB_STEP_SUMMARY
305+
run: cat "${RUNNER_TEMP}/summary.md" >> "$GITHUB_STEP_SUMMARY"
306306

307307
- name: Set the base sha
308308
# Only needed when publishing results.

‎.github/workflows/reusable-php-compatibility.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ jobs:
6060
# http://man7.org/linux/man-pages/man1/date.1.html
6161
- name: "Get last Monday's date"
6262
id: get-date
63-
run: echo date="$(/bin/date -u --date='last Mon' "+%F")" >> $GITHUB_OUTPUT
63+
run: echo date="$(/bin/date -u --date='last Mon' "+%F")" >> "$GITHUB_OUTPUT"
6464

6565
- name: Cache PHP compatibility scan cache
6666
uses: actions/cache@6849a6489940f00c2f30c0fb92c6274307ccb58a # v4.1.2
@@ -76,7 +76,7 @@ jobs:
7676
custom-cache-suffix: ${{ steps.get-date.outputs.date }}
7777

7878
- name: Make Composer packages available globally
79-
run: echo "${PWD}/vendor/bin" >> $GITHUB_PATH
79+
run: echo "${PWD}/vendor/bin" >> "$GITHUB_PATH"
8080

8181
- name: Run PHP compatibility tests
8282
id: phpcs

‎.github/workflows/reusable-phpunit-tests-v1.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,8 +90,8 @@ jobs:
9090
steps:
9191
- name: Configure environment variables
9292
run: |
93-
echo PHP_FPM_UID="$(id -u)" >> $GITHUB_ENV
94-
echo PHP_FPM_GID="$(id -g)" >> $GITHUB_ENV
93+
echo PHP_FPM_UID="$(id -u)" >> "$GITHUB_ENV"
94+
echo PHP_FPM_GID="$(id -g)" >> "$GITHUB_ENV"
9595
9696
- name: Checkout repository
9797
uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7

‎.github/workflows/reusable-phpunit-tests-v2.yml‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -93,8 +93,8 @@ jobs:
9393
steps:
9494
- name: Configure environment variables
9595
run: |
96-
echo PHP_FPM_UID="$(id -u)" >> $GITHUB_ENV
97-
echo PHP_FPM_GID="$(id -g)" >> $GITHUB_ENV
96+
echo PHP_FPM_UID="$(id -u)" >> "$GITHUB_ENV"
97+
echo PHP_FPM_GID="$(id -g)" >> "$GITHUB_ENV"
9898
9999
- name: Checkout repository
100100
uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
@@ -113,7 +113,7 @@ jobs:
113113

114114
- name: Get composer cache directory
115115
id: composer-cache
116-
run: echo composer_dir="$(composer config cache-files-dir)" >> $GITHUB_OUTPUT
116+
run: echo composer_dir="$(composer config cache-files-dir)" >> "$GITHUB_OUTPUT"
117117

118118
- name: Cache Composer dependencies
119119
uses: actions/cache@6849a6489940f00c2f30c0fb92c6274307ccb58a # v4.1.2
@@ -132,7 +132,7 @@ jobs:
132132
# used for PHP 8 testing instead.
133133
if [ "${LOCAL_PHP}" == '8.0-fpm' ]; then
134134
docker compose run --rm php composer install --ignore-platform-reqs
135-
echo PHPUNIT_SCRIPT="php-composer" >> $GITHUB_ENV
135+
echo PHPUNIT_SCRIPT="php-composer" >> "$GITHUB_ENV"
136136
elif [ "${LOCAL_PHP}" == '7.1-fpm' ]; then
137137
docker compose run --rm php composer update
138138
git checkout -- composer.lock

‎.github/workflows/reusable-phpunit-tests-v3.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -116,8 +116,8 @@ jobs:
116116
steps:
117117
- name: Configure environment variables
118118
run: |
119-
echo PHP_FPM_UID="$(id -u)" >> $GITHUB_ENV
120-
echo PHP_FPM_GID="$(id -g)" >> $GITHUB_ENV
119+
echo PHP_FPM_UID="$(id -u)" >> "$GITHUB_ENV"
120+
echo PHP_FPM_GID="$(id -g)" >> "$GITHUB_ENV"
121121
122122
- name: Checkout repository
123123
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1

‎.github/workflows/reusable-support-json-reader-v1.yml‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -60,11 +60,11 @@ jobs:
6060
id: major-wp-version
6161
run: |
6262
if [ "${WP_VERSION}" ] && [ "${WP_VERSION}" != "nightly" ] && [ "${WP_VERSION}" != "latest" ] && [ "${WP_VERSION}" != "trunk" ]; then
63-
echo version="$(echo "${WP_VERSION}" | tr '.' '-' | cut -d '-' -f1-2)" >> $GITHUB_OUTPUT
63+
echo version="$(echo "${WP_VERSION}" | tr '.' '-' | cut -d '-' -f1-2)" >> "$GITHUB_OUTPUT"
6464
elif [ "${WP_VERSION}" ] && [ "${WP_VERSION}" != "trunk" ]; then
65-
echo version="${WP_VERSION}" >> $GITHUB_OUTPUT
65+
echo version="${WP_VERSION}" >> "$GITHUB_OUTPUT"
6666
else
67-
echo version="nightly" >> $GITHUB_OUTPUT
67+
echo version="nightly" >> "$GITHUB_OUTPUT"
6868
fi
6969
env:
7070
WP_VERSION: ${{ inputs.wp-version }}
@@ -100,9 +100,9 @@ jobs:
100100
id: php-versions
101101
run: |
102102
if [ "${WP_VERSION}" != "latest" ] && [ "${WP_VERSION}" != "nightly" ]; then
103-
echo versions="$(jq -r '.["${WP_VERSION}"] | @json' .version-support-php.json)" >> $GITHUB_OUTPUT # @TODO finalise
103+
echo versions="$(jq -r '.["${WP_VERSION}"] | @json' .version-support-php.json)" >> "$GITHUB_OUTPUT" # @TODO finalise
104104
else
105-
echo versions="$(jq -r '.[ (keys[-1]) ] | @json' .version-support-php.json)" >> $GITHUB_OUTPUT
105+
echo versions="$(jq -r '.[ (keys[-1]) ] | @json' .version-support-php.json)" >> "$GITHUB_OUTPUT"
106106
fi
107107
env:
108108
WP_VERSION: ${{ needs.major-wp-version.outputs.version }}
@@ -138,9 +138,9 @@ jobs:
138138
id: mysql-versions
139139
run: |
140140
if [ "${WP_VERSION}" != "latest" ] && [ "${WP_VERSION}" != "nightly" ]; then
141-
echo versions="$(jq -r '.["${WP_VERSION}"] | @json' .version-support-mysql.json)" >> $GITHUB_OUTPUT # @todo finalise
141+
echo versions="$(jq -r '.["${WP_VERSION}"] | @json' .version-support-mysql.json)" >> "$GITHUB_OUTPUT" # @todo finalise
142142
else
143-
echo versions="$(jq -r '.[ (keys[-1]) ] | @json' .version-support-mysql.json)" >> $GITHUB_OUTPUT
143+
echo versions="$(jq -r '.[ (keys[-1]) ] | @json' .version-support-mysql.json)" >> "$GITHUB_OUTPUT"
144144
fi
145145
env:
146146
WP_VERSION: ${{ needs.major-wp-version.outputs.version }}

‎.github/workflows/reusable-test-local-docker-environment-v1.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,8 +82,8 @@ jobs:
8282
steps:
8383
- name: Configure environment variables
8484
run: |
85-
echo PHP_FPM_UID="$(id -u)" >> $GITHUB_ENV
86-
echo PHP_FPM_GID="$(id -g)" >> $GITHUB_ENV
85+
echo PHP_FPM_UID="$(id -u)" >> "$GITHUB_ENV"
86+
echo PHP_FPM_GID="$(id -g)" >> "$GITHUB_ENV"
8787
8888
- name: Checkout repository
8989
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1

‎.github/workflows/slack-notifications.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ jobs:
146146
id: commit-message
147147
run: |
148148
COMMIT_MESSAGE="$(echo "${COMMIT_MSG_RAW}" | awk 'NR==1' | sed 's/`/\\`/g' | sed 's/\"/\\\\\\"/g' | sed 's/\$/\\$/g')"
149-
echo commit_message_escaped="${COMMIT_MESSAGE}" >> $GITHUB_OUTPUT
149+
echo commit_message_escaped="${COMMIT_MESSAGE}" >> "$GITHUB_OUTPUT"
150150
env:
151151
COMMIT_MSG_RAW: ${{ ( github.event_name == 'workflow_dispatch' || github.event_name == 'schedule' ) && fromJson( steps.current-commit-message.outputs.result ) || github.event.head_commit.message }}
152152

@@ -161,7 +161,7 @@ jobs:
161161
--arg commit_message "${COMMIT_MSG}" \
162162
# shellcheck disable=SC2016,SC2086
163163
'{workflow_name: $workflow_name, ref_name: $ref_name, run_url: $run_url, commit_message: $commit_message}'
164-
)" >> $GITHUB_OUTPUT
164+
)" >> "$GITHUB_OUTPUT"
165165
env:
166166
COMMIT_MSG: ${{ steps.commit-message.outputs.commit_message_escaped }}
167167

0 commit comments

Comments
 (0)