Remove instructions annotation and change default for destructive to `false

Author: gziolo

src/wp-includes/abilities-api/class-wp-ability.php

@@ -36,15 +36,13 @@ class WP_Ability {
 	 * @var array<string, (bool|string)>
 	 */
 	protected static $default_annotations = array(
-		// Instructions on how to use the ability.
-		'instructions' => '',
 		// If true, the ability does not modify its environment.
 		'readonly'     => false,
 		/*
 		 * If true, the ability may perform destructive updates to its environment.
 		 * If false, the ability performs only additive updates.
 		 */
-		'destructive'  => true,
+		'destructive'  => false,
 		/*
 		 * If true, calling the ability repeatedly with the same arguments will have no additional effect
 		 * on its environment.

tests/phpunit/tests/abilities-api/wpAbility.php

@@ -115,7 +115,6 @@ public function test_get_merged_annotations_from_meta() {
 			array_merge(
 				self::$test_ability_properties['meta']['annotations'],
 				array(
-					'instructions' => '',
 					'idempotent'   => false,
 				)
 			),
@@ -136,9 +135,8 @@ public function test_get_default_annotations_from_meta() {
 
 		$this->assertSame(
 			array(
-				'instructions' => '',
 				'readonly'     => false,
-				'destructive'  => true,
+				'destructive'  => false,
 				'idempotent'   => false,
 			),
 			$ability->get_meta_item( 'annotations' )
@@ -152,7 +150,6 @@ public function test_get_default_annotations_from_meta() {
 	 */
 	public function test_get_overridden_annotations_from_meta() {
 		$annotations = array(
-			'instructions' => 'Enjoy responsibly.',
 			'readonly'     => true,
 			'destructive'  => false,
 			'idempotent'   => false,

tests/phpunit/tests/abilities-api/wpRegisterAbility.php

@@ -165,7 +165,6 @@ public function test_register_valid_ability(): void {
 		$expected_annotations = array_merge(
 			self::$test_ability_args['meta']['annotations'],
 			array(
-				'instructions' => '',
 				'idempotent'   => false,
 			)
 		);