Privacy: Replace Policy Name with an auto increment to avoid internationalized plugin name issues.

This changeset replaces plugin sanitized names with an auto increment integer to fix an issue with accordions displaying privacy policies for plugins with special characters in their names.

Follow-up to [50161].

Props ecgan, sabernhardt, audrasjb.
Fixes #62713.




git-svn-id: https://develop.svn.wordpress.org/trunk@59732 602fd350-edb4-49c9-b593-d223f7449a82

Author: audrasjb

src/wp-admin/includes/class-wp-privacy-policy-content.php

@@ -381,7 +381,11 @@ public static function privacy_policy_guide() {
 		$content       = '';
 		$date_format   = __( 'F j, Y' );
 
+		$i = 0;
+
 		foreach ( $content_array as $section ) {
+			++$i;
+
 			$class   = '';
 			$meta    = '';
 			$removed = '';
@@ -409,19 +413,17 @@ public static function privacy_policy_guide() {
 			}
 
 			$plugin_name = esc_html( $section['plugin_name'] );
-
-			$sanitized_policy_name = sanitize_title_with_dashes( $plugin_name );
 			?>
 			<h4 class="privacy-settings-accordion-heading">
-			<button aria-expanded="false" class="privacy-settings-accordion-trigger" aria-controls="privacy-settings-accordion-block-<?php echo $sanitized_policy_name; ?>" type="button">
+				<button aria-expanded="false" class="privacy-settings-accordion-trigger" aria-controls="privacy-settings-accordion-block-<?php echo $i; ?>" type="button">
 				<span class="title"><?php echo $plugin_name; ?></span>
 				<?php if ( ! empty( $section['removed'] ) || ! empty( $section['updated'] ) ) : ?>
 				<span class="badge <?php echo $badge_class; ?>"> <?php echo $badge_title; ?></span>
 				<?php endif; ?>
 				<span class="icon"></span>
 			</button>
 			</h4>
-			<div id="privacy-settings-accordion-block-<?php echo $sanitized_policy_name; ?>" class="privacy-settings-accordion-panel privacy-text-box-body" hidden="hidden">
+			<div id="privacy-settings-accordion-block-<?php echo $i; ?>" class="privacy-settings-accordion-panel privacy-text-box-body" hidden="hidden">
 				<?php
 				echo $removed;
 				echo $section['policy_text'];