Skip to content

Commit 4e72f78

Browse files
committed
Build/Test Tools: Add additional details why MacOS jobs are separate.
This adds additional inline context as to why the MacOS job is separate from the Windows and Ubuntu ones in the Test npm workflow. While it is preferable to combine all of these to avoid repeated code, there is currently no way to determine the runner’s OS within the `if` workflow key. MacOS jobs use GitHub Action minutes at by a multiple of 10. Being more strict about when to run these jobs ensures minutes are not unintentionally consumed within private forks and mirrors. See https://docs.github.com/en/actions/learn-github-actions/contexts#context-availability for more details. See #56793. git-svn-id: https://develop.svn.wordpress.org/trunk@54852 602fd350-edb4-49c9-b593-d223f7449a82
1 parent 7fbcfef commit 4e72f78

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

.github/workflows/test-npm.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,10 @@ jobs:
104104
# This is separate from the job above in order to use stricter conditions about when to run.
105105
# This avoids unintentionally consuming excessive minutes, as MacOS jobs consume minutes at a 10x rate.
106106
#
107+
# The `matrix` and `runner` contexts are not available for use within `if` expressions. So there is
108+
# currently no way to determine the OS being used on a given job.
109+
# See https://docs.github.com/en/actions/learn-github-actions/contexts#context-availability.
110+
#
107111
# Performs the following steps:
108112
# - Checks out the repository.
109113
# - Sets up Node.js.

0 commit comments

Comments
 (0)