Menus: Fix searchability of post types which contain numeric characters.

The regular expression needs to correspond to how a post type slug is sanitized by `sanitize_key()` in `register_post_type()`.

Props kshaner, mindctrl, oglekler.
Fixes #63633.


git-svn-id: https://develop.svn.wordpress.org/trunk@60775 602fd350-edb4-49c9-b593-d223f7449a82

Author: westonruter

src/wp-admin/includes/nav-menu.php

@@ -80,7 +80,7 @@ function _wp_ajax_menu_quick_search( $request = array() ) {
 				}
 			}
 		}
-	} elseif ( preg_match( '/quick-search-(posttype|taxonomy)-([a-zA-Z_-]*\b)/', $type, $matches ) ) {
+	} elseif ( preg_match( '/quick-search-(posttype|taxonomy)-([a-zA-Z0-9_-]*\b)/', $type, $matches ) ) {
 		if ( 'posttype' === $matches[1] && get_post_type_object( $matches[2] ) ) {
 			$post_type_obj = _wp_nav_menu_meta_box_object( get_post_type_object( $matches[2] ) );
 			$args          = array_merge(

tests/phpunit/tests/menu/wpAjaxMenuQuickSearch.php

@@ -121,4 +121,36 @@ public function test_search_should_return_unassigned_term_items() {
 		$results = explode( "\n", trim( $output ) );
 		$this->assertCount( 1, $results );
 	}
+
+	/**
+	 * Test that search displays results for post types with numeric slugs
+	 *
+	 * @ticket 63633
+	 */
+	public function test_search_returns_post_types_with_numeric_slugs() {
+		register_post_type( 'wptests_123' );
+
+		self::factory()->post->create(
+			array(
+				'post_title'   => 'Post Title 123',
+				'post_type'    => 'wptests_123',
+				'post_status'  => 'publish',
+				'post_content' => 'FOO',
+			)
+		);
+
+		$request = array(
+			'type' => 'quick-search-posttype-wptests_123',
+			'q'    => 'FOO',
+		);
+
+		$output = get_echo( '_wp_ajax_menu_quick_search', array( $request ) );
+		$this->assertNotEmpty( $output );
+
+		$results = explode( "\n", trim( $output ) );
+		$this->assertCount( 1, $results );
+
+		$results_json = array_map( 'json_decode', $results );
+		$this->assertEquals( 'wptests_123', $results_json[0]->post_type );
+	}
 }