Skip to content

Commit 5ecf1f9

Browse files
committed
Merge remote-tracking branch 'upstream' into 6-9/dependency-updates
2 parents 323bd9f + ef32a8c commit 5ecf1f9

File tree

7 files changed

+43
-33
lines changed

7 files changed

+43
-33
lines changed

.github/workflows/pull-request-comments.yml

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -130,6 +130,20 @@ jobs:
130130
const fs = require( 'fs' );
131131
const issue_number = Number( fs.readFileSync( './NR' ) );
132132
133+
core.info( `Checking pull request #${issue_number}.` );
134+
135+
// Confirm that the pull request is still open before leaving a comment.
136+
const pr = await github.rest.pulls.get({
137+
owner: context.repo.owner,
138+
repo: context.repo.repo,
139+
pull_number: issue_number,
140+
});
141+
142+
if ( pr.data.state !== 'open' ) {
143+
core.info( 'The pull request has been closed. No comment will be left.' );
144+
return;
145+
}
146+
133147
// Comments are only added after the first successful build. Check for the presence of a comment and bail early.
134148
const commentInfo = {
135149
owner: context.repo.owner,
@@ -141,6 +155,7 @@ jobs:
141155
142156
for ( const currentComment of comments ) {
143157
if ( currentComment.user.type === 'Bot' && currentComment.body.includes( 'Test using WordPress Playground' ) ) {
158+
core.info( 'A comment with instructions to test within a Playground instance already exists.' );
144159
return;
145160
}
146161
};

Gruntfile.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1159,7 +1159,7 @@ module.exports = function(grunt) {
11591159
}
11601160

11611161
// Fetch a list of the files that Twemoji supplies.
1162-
query = 'query={repository(owner: "jdecked", name: "twemoji") {object(expression: "v16.0.1:assets/svg") {... on Tree {entries {name}}}}}';
1162+
query = 'query={repository(owner: "jdecked", name: "twemoji") {object(expression: "v17.0.1:assets/svg") {... on Tree {entries {name}}}}}';
11631163
files = spawn( 'gh', [ 'api', 'graphql', '-f', query] );
11641164

11651165
if ( 0 !== files.status ) {

src/js/_enqueues/lib/emoji-loader.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -271,20 +271,20 @@ function browserSupportsEmoji( context, type, emojiSetsRenderIdentically, emojiR
271271
return ! isIdentical;
272272
case 'emoji':
273273
/*
274-
* Does Emoji 16.0 cause the browser to go splat?
274+
* Is there a large, hairy, humanoid mythical creature living in the browser?
275275
*
276-
* To test for Emoji 16.0 support, try to render a new emoji: Splatter.
276+
* To test for Emoji 17.0 support, try to render a new emoji: Hairy Creature.
277277
*
278-
* The splatter emoji is a single code point emoji. Testing for browser support
279-
* required testing the center point of the emoji to see if it is empty.
278+
* The hairy creature emoji is a single code point emoji. Testing for browser
279+
* support required testing the center point of the emoji to see if it is empty.
280280
*
281-
* 0xD83E 0xDEDF (\uD83E\uDEDF) == 🫟 Splatter.
281+
* 0xD83E 0x1FAC8 (\uD83E\u1FAC8) == 🫈 Hairy creature.
282282
*
283283
* When updating this test, please ensure that the emoji is either a single code point
284284
* or switch to using the emojiSetsRenderIdentically function and testing with a zero-width
285285
* joiner vs a zero-width space.
286286
*/
287-
const notSupported = emojiRendersEmptyCenterPoint( context, '\uD83E\uDEDF' );
287+
const notSupported = emojiRendersEmptyCenterPoint( context, '\uD83E\u1FAC8' );
288288
return ! notSupported;
289289
}
290290

src/js/_enqueues/vendor/twemoji.js

Lines changed: 2 additions & 18 deletions
Large diffs are not rendered by default.

src/wp-admin/options-general.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -445,7 +445,8 @@ class="<?php echo esc_attr( $classes_for_button ); ?>"
445445
__( 'Standard time begins on: %s.' );
446446
printf(
447447
$message,
448-
'<code>' . wp_date( __( 'F j, Y' ) . ' ' . __( 'g:i a' ), $transitions[1]['ts'] ) . '</code>'
448+
/* translators: Localized date and time format, see https://www.php.net/manual/datetime.format.php */
449+
'<code>' . wp_date( __( 'F j, Y g:i a' ), $transitions[1]['ts'] ) . '</code>'
449450
);
450451
} else {
451452
_e( 'This timezone does not observe daylight saving time.' );

src/wp-includes/formatting.php

Lines changed: 5 additions & 5 deletions
Large diffs are not rendered by default.

tests/phpunit/tests/formatting/emoji.php

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@
66
*/
77
class Tests_Formatting_Emoji extends WP_UnitTestCase {
88

9-
private $png_cdn = 'https://s.w.org/images/core/emoji/16.0.1/72x72/';
10-
private $svg_cdn = 'https://s.w.org/images/core/emoji/16.0.1/svg/';
9+
private $png_cdn = 'https://s.w.org/images/core/emoji/17.0.1-1/72x72/';
10+
private $svg_cdn = 'https://s.w.org/images/core/emoji/17.0.1-1/svg/';
1111

1212
/**
1313
* @ticket 63842
@@ -157,6 +157,11 @@ public function data_wp_encode_emoji() {
157157
'🧚',
158158
'&#x1f9da;',
159159
),
160+
array(
161+
// Hairy creature (Unicode 17).
162+
'🫈',
163+
'&#x1fac8;',
164+
),
160165
);
161166
}
162167

@@ -192,6 +197,11 @@ public function data_wp_staticize_emoji() {
192197
'🧚',
193198
'<img src="' . $this->png_cdn . '1f9da.png" alt="🧚" class="wp-smiley" style="height: 1em; max-height: 1em;" />',
194199
),
200+
array(
201+
// Hairy creature (Unicode 17).
202+
'🫈',
203+
'<img src="' . $this->png_cdn . '1fac8.png" alt="🫈" class="wp-smiley" style="height: 1em; max-height: 1em;" />',
204+
),
195205
);
196206

197207
return $data;

0 commit comments

Comments
 (0)