Adjust logic to only impact notes; adjust tests

Author: adamsilverstein

src/wp-includes/rest-api/endpoints/class-wp-rest-comments-controller.php

@@ -1890,7 +1890,7 @@ protected function check_read_post_permission( $post, $request ) {
 	 * @return bool Whether the comment can be read.
 	 */
 	protected function check_read_permission( $comment, $request ) {
-		if ( 'comment' === $comment->comment_type && ! empty( $comment->comment_post_ID ) ) {
+		if ( 'note' !== $comment->comment_type && ! empty( $comment->comment_post_ID ) ) {
 			$post = get_post( $comment->comment_post_ID );
 			if ( $post ) {
 				if ( $this->check_read_post_permission( $post, $request ) && 1 === (int) $comment->comment_approved ) {

tests/phpunit/tests/rest-api/rest-comments-controller.php

@@ -4226,16 +4226,16 @@ public function test_get_items_type_arg_unauthenticated( $comment_type, $count )
 		$request->set_param( 'per_page', self::$per_page );
 
 		$response = rest_get_server()->dispatch( $request );
-		$this->assertEquals( 'comment' === $comment_type ? 200 : 401, $response->get_status() );
-		if ( 'comment' !== $comment_type ) {
+		$this->assertEquals( 'note' !== $comment_type ? 200 : 401, $response->get_status() );
+		if ( 'note' === $comment_type ) {
 			$this->assertErrorResponse( 'rest_forbidden_param', $response, 401 );
 		}
 
 		// Next, test getting the individual comments.
 		foreach( $comments as $comment ) {
 			$request  = new WP_REST_Request( 'GET', sprintf( '/wp/v2/comments/%d', $comment ) );
 			$response = rest_get_server()->dispatch( $request );
-			$this->assertEquals( 'comment' === $comment_type ? 200 : 401, $response->get_status() );
+			$this->assertEquals( 'note' !== $comment_type ? 200 : 401, $response->get_status() );
 		}
 	}