Upgrade/Install: Move Hello Dolly plugin to directory structure.

Changes the Hello Dolly plugin from a single file structure to a proper plugin directory structure, moving from `hello.php` to `hello-dolly/hello.php` to align with Plugin Handbook Best Practices.

- Adds proper `Text Domain: hello-dolly` header to Hello Dolly plugin
- Updates core files to remove special case handling for `hello.php`
- Updates plugin dependency system to handle new directory structure
- Adds upgrade routine to migrate active plugin references and keep plugin active
- Updates all tests to use new plugin path format `hello-dolly/hello.php`
- Updates build configuration and .gitignore for new directory structure
- Adds `hello.php` to old files list for cleanup during core updates
- Adds `plugins/hello-dolly/` to new bundled directories list

Props afragen, SergeyBiryukov, peterwilsoncc, SirLouen, matt, davidbaumwald, desrosj, hellofromtonya, justinahinon,audrasjb, oglekler, whyisjake.
Fixes #53323.



git-svn-id: https://develop.svn.wordpress.org/trunk@60666 602fd350-edb4-49c9-b593-d223f7449a82

Author: whyisjake

.gitignore

@@ -50,7 +50,8 @@ wp-tests-config.php
 /src/wp-content/fonts
 /src/wp-content/languages
 /src/wp-content/mu-plugins
-/src/wp-content/plugins
+/src/wp-content/plugins/*
+!/src/wp-content/plugins/hello-dolly
 /src/wp-content/themes/*
 !/src/wp-content/themes/twentyten
 !/src/wp-content/themes/twentyeleven

Gruntfile.js

@@ -28,7 +28,7 @@ module.exports = function(grunt) {
 			'wp-content/themes/index.php',
 			'wp-content/themes/twenty*/**',
 			'wp-content/plugins/index.php',
-			'wp-content/plugins/hello.php',
+			'wp-content/plugins/hello-dolly/**',
 			'wp-content/plugins/akismet/**',
 			'!wp-content/themes/twenty*/node_modules/**',
 		],

src/wp-admin/includes/plugin.php

@@ -153,8 +153,6 @@ function _get_plugin_data_markup_translate( $plugin_file, $plugin_data, $markup
 					load_plugin_textdomain( $textdomain, false, dirname( $plugin_file ) );
 				}
 			}
-		} elseif ( 'hello.php' === basename( $plugin_file ) ) {
-			$textdomain = 'default';
 		}
 		if ( $textdomain ) {
 			foreach ( array( 'Name', 'PluginURI', 'Description', 'Author', 'AuthorURI', 'Version' ) as $field ) {
@@ -1008,10 +1006,6 @@ function delete_plugins( $plugins, $deprecated = '' ) {
 
 		$plugin_slug = dirname( $plugin_file );
 
-		if ( 'hello.php' === $plugin_file ) {
-			$plugin_slug = 'hello-dolly';
-		}
-
 		// Remove language files, silently.
 		if ( '.' !== $plugin_slug && ! empty( $plugin_translations[ $plugin_slug ] ) ) {
 			$translations = $plugin_translations[ $plugin_slug ];

src/wp-admin/includes/update-core.php

@@ -841,6 +841,8 @@
 	'wp-includes/js/dist/undo-manager.min.js',
 	'wp-includes/js/dist/fields.min.js',
 	'wp-includes/js/dist/fields.js',
+	// 6.9
+	'wp-content/plugins/hello.php',
 );
 
 /**
@@ -973,6 +975,7 @@
 	'themes/twentytwentythree/' => '6.1',
 	'themes/twentytwentyfour/'  => '6.4',
 	'themes/twentytwentyfive/'  => '6.7',
+	'plugins/hello-dolly/'      => '6.9',
 );
 
 /**

src/wp-admin/includes/upgrade.php

@@ -880,6 +880,7 @@ function upgrade_all() {
 
 	if ( $wp_current_db_version < 58975 ) {
 		upgrade_670();
+		upgrade_690();
 	}
 
 	if ( $wp_current_db_version < 60421 ) {
@@ -2414,6 +2415,29 @@ function upgrade_650() {
 		wp_set_option_autoload_values( $autoload );
 	}
 }
+
+/**
+ * Executes changes made in WordPress 6.9.0.
+ *
+ * @ignore
+ * @since 6.9.0
+ *
+ * @global int $wp_current_db_version The old (current) database version.
+ */
+function upgrade_690() {
+	global $wp_current_db_version;
+
+	// Switch Hello Dolly from file to directory format. See #53323
+	$active_plugins = get_option( 'active_plugins' );
+	$old_plugin     = 'hello.php';
+	$new_plugin     = 'hello-dolly/hello.php';
+	$key            = array_search( $old_plugin, $active_plugins, true );
+
+	if ( $key ) {
+		$active_plugins[ $key ] = $new_plugin;
+		update_option( 'active_plugins', $active_plugins );
+	}
+}
 /**
  * Executes changes made in WordPress 6.7.0.
  *

src/wp-content/plugins/hello.php

@@ -10,6 +10,7 @@
 Author: Matt Mullenweg
 Version: 1.7.2
 Author URI: http://ma.tt/
+Text Domain: hello-dolly
 */
 
 // Do not load directly.

src/wp-includes/class-wp-plugin-dependencies.php

@@ -870,9 +870,6 @@ protected static function check_for_circular_dependencies( $dependents, $depende
 	 * @return string The plugin's slug.
 	 */
 	protected static function convert_to_slug( $plugin_file ) {
-		if ( 'hello.php' === $plugin_file ) {
-			return 'hello-dolly';
-		}
 		return str_contains( $plugin_file, '/' ) ? dirname( $plugin_file ) : str_replace( '.php', '', $plugin_file );
 	}
 }

tests/phpunit/tests/admin/includesPlugin.php

@@ -22,7 +22,7 @@ public static function wpTearDownAfterClass() {
 	}
 
 	public function test_get_plugin_data() {
-		$data = get_plugin_data( DIR_TESTDATA . '/plugins/hello.php' );
+		$data = get_plugin_data( DIR_TESTDATA . '/plugins/hello-dolly/hello.php' );
 
 		$default_headers = array(
 			'Name'        => 'Hello Dolly',
@@ -374,38 +374,38 @@ public function test_passing_float_as_position_does_not_override_int() {
 	}
 
 	public function test_is_plugin_active_true() {
-		activate_plugin( 'hello.php' );
-		$test = is_plugin_active( 'hello.php' );
+		activate_plugin( 'hello-dolly/hello.php' );
+		$test = is_plugin_active( 'hello-dolly/hello.php' );
 		$this->assertTrue( $test );
 
-		deactivate_plugins( 'hello.php' );
+		deactivate_plugins( 'hello-dolly/hello.php' );
 	}
 
 	public function test_is_plugin_active_false() {
-		deactivate_plugins( 'hello.php' );
-		$test = is_plugin_active( 'hello.php' );
+		deactivate_plugins( 'hello-dolly/hello.php' );
+		$test = is_plugin_active( 'hello-dolly/hello.php' );
 		$this->assertFalse( $test );
 	}
 
 	public function test_is_plugin_inactive_true() {
-		deactivate_plugins( 'hello.php' );
-		$test = is_plugin_inactive( 'hello.php' );
+		deactivate_plugins( 'hello-dolly/hello.php' );
+		$test = is_plugin_inactive( 'hello-dolly/hello.php' );
 		$this->assertTrue( $test );
 	}
 
 	public function test_is_plugin_inactive_false() {
-		activate_plugin( 'hello.php' );
-		$test = is_plugin_inactive( 'hello.php' );
+		activate_plugin( 'hello-dolly/hello.php' );
+		$test = is_plugin_inactive( 'hello-dolly/hello.php' );
 		$this->assertFalse( $test );
 
-		deactivate_plugins( 'hello.php' );
+		deactivate_plugins( 'hello-dolly/hello.php' );
 	}
 
 	/**
 	 * @covers ::get_plugin_files
 	 */
 	public function test_get_plugin_files_single() {
-		$name = 'hello.php';
+		$name = 'hello-dolly/hello.php';
 		$this->assertSame( array( $name ), get_plugin_files( $name ) );
 	}
 
@@ -550,7 +550,7 @@ public function test_get_dropins_not_empty() {
 	 * @covers ::is_network_only_plugin
 	 */
 	public function test_is_network_only_plugin_hello() {
-		$this->assertFalse( is_network_only_plugin( 'hello.php' ) );
+		$this->assertFalse( is_network_only_plugin( 'hello-dolly/hello.php' ) );
 	}
 
 	/**
@@ -570,7 +570,7 @@ public function test_is_network_only_plugin() {
 	 * @covers ::activate_plugins
 	 */
 	public function test_activate_plugins_single_no_array() {
-		$name = 'hello.php';
+		$name = 'hello-dolly/hello.php';
 		activate_plugins( $name );
 		$this->assertTrue( is_plugin_active( $name ) );
 		deactivate_plugins( $name );
@@ -580,7 +580,7 @@ public function test_activate_plugins_single_no_array() {
 	 * @covers ::activate_plugins
 	 */
 	public function test_activate_plugins_single_array() {
-		$name = 'hello.php';
+		$name = 'hello-dolly/hello.php';
 		activate_plugins( array( $name ) );
 		$this->assertTrue( is_plugin_active( $name ) );
 		deactivate_plugins( $name );

tests/phpunit/tests/admin/plugin-dependencies/hasDependents.php

@@ -53,6 +53,6 @@ public function test_should_return_false_when_a_plugin_has_no_dependents() {
 	 */
 	public function test_should_convert_hellophp_to_hello_dolly() {
 		$this->set_property_value( 'dependency_slugs', array( 'hello-dolly' ) );
-		$this->assertTrue( self::$instance::has_dependents( 'hello.php' ) );
+		$this->assertTrue( self::$instance::has_dependents( 'hello-dolly/hello.php' ) );
 	}
 }

tests/phpunit/tests/admin/plugin-dependencies/initialize.php

@@ -281,11 +281,7 @@ public function test_should_slugify_dependent_files() {
 		$expected_slugs = array();
 		foreach ( $plugins as $plugin_file => &$headers ) {
 			// Create the expected slugs.
-			if ( 'hello.php' === $plugin_file ) {
-				$slug = 'hello-dolly';
-			} else {
-				$slug = str_replace( '.php', '', explode( '/', $plugin_file )[0] );
-			}
+			$slug = str_replace( '.php', '', explode( '/', $plugin_file )[0] );
 
 			$expected_slugs[ $plugin_file ] = $slug;