Code Modernization: Update tests to use null coalescing operator in place of isset() in ternaries.

westonruter · westonruter · commit 745a5370d41c · 2026-01-03T06:15:57.000Z
Developed as a subset of #10654 Follow-up to [61404], [61403]. See #58874, #63430. git-svn-id: https://develop.svn.wordpress.org/trunk@61424 602fd350-edb4-49c9-b593-d223f7449a82
diff --git a/tests/phpunit/data/WPHTTP-testcase-redirection-script.php b/tests/phpunit/data/WPHTTP-testcase-redirection-script.php
@@ -54,7 +54,7 @@ function is_ssl() {
 
 if ( isset( $_GET['post-redirect-to-method'] ) ) {
 	$method = $_SERVER['REQUEST_METHOD'];
-	$response_code = isset( $_GET['response_code'] ) ? $_GET['response_code'] : 301;
+	$response_code = $_GET['response_code'] ?? 301;
 
 	if ( 'POST' == $method && ! isset( $_GET['redirection-performed'] ) ) {
 		header( "Location: $url?post-redirect-to-method=1&redirection-performed=1", true, $response_code );
@@ -123,8 +123,8 @@ function is_ssl() {
 }
 
 
-$rt = isset($_GET['rt']) ? $_GET['rt'] : 5;
-$r = isset($_GET['r']) ? $_GET['r'] : 0;
+$rt = $_GET['rt'] ?? 5;
+$r = $_GET['r'] ?? 0;
 
 if ( $r < $rt ) {
 	$code = isset($_GET['code']) ? (int)$_GET['code'] : 302;
diff --git a/tests/phpunit/includes/abstract-testcase.php b/tests/phpunit/includes/abstract-testcase.php
@@ -1313,7 +1313,7 @@ public function go_to( $url ) {
 		}
 		$parts = parse_url( $url );
 		if ( isset( $parts['scheme'] ) ) {
-			$req = isset( $parts['path'] ) ? $parts['path'] : '';
+			$req = $parts['path'] ?? '';
 			if ( isset( $parts['query'] ) ) {
 				$req .= '?' . $parts['query'];
 				// Parse the URL query vars into $_GET.
diff --git a/tests/phpunit/includes/factory/class-wp-unittest-factory-for-term.php b/tests/phpunit/includes/factory/class-wp-unittest-factory-for-term.php
@@ -109,7 +109,7 @@ public function create_and_get( $args = array(), $generation_definitions = null
 			return $term_id;
 		}
 
-		$taxonomy = isset( $args['taxonomy'] ) ? $args['taxonomy'] : $this->taxonomy;
+		$taxonomy = $args['taxonomy'] ?? $this->taxonomy;
 
 		return get_term( $term_id, $taxonomy );
 	}
diff --git a/tests/phpunit/includes/mock-fs.php b/tests/phpunit/includes/mock-fs.php
@@ -46,7 +46,7 @@ public function init( $paths = '', $home_dir = '/' ) {
 			'/' => $this->fs,
 		);
 		$this->cache  = array(); // Used by find_folder() and friends.
-		$this->cwd    = isset( $this->fs_map[ $home_dir ] ) ? $this->fs_map[ $home_dir ] : '/';
+		$this->cwd    = $this->fs_map[ $home_dir ] ?? '/';
 		$this->setfs( $paths );
 	}
 
@@ -79,7 +79,7 @@ public function setfs( $paths ) {
 	 * Locates a filesystem "node"
 	 */
 	private function locate_node( $path ) {
-		return isset( $this->fs_map[ $path ] ) ? $this->fs_map[ $path ] : false;
+		return $this->fs_map[ $path ] ?? false;
 	}
 
 	/**
diff --git a/tests/phpunit/tests/abilities-api/wpRegisterAbility.php b/tests/phpunit/tests/abilities-api/wpRegisterAbility.php
@@ -154,7 +154,7 @@ public function test_register_ability_no_init_action(): void {
 		global $wp_actions;
 
 		// Store the original action count.
-		$original_count = isset( $wp_actions['init'] ) ? $wp_actions['init'] : 0;
+		$original_count = $wp_actions['init'] ?? 0;
 
 		// Reset the action count to simulate it not being fired.
 		unset( $wp_actions['init'] );
@@ -450,7 +450,7 @@ public function test_unregister_ability_no_init_action(): void {
 		global $wp_actions;
 
 		// Store the original action count.
-		$original_count = isset( $wp_actions['init'] ) ? $wp_actions['init'] : 0;
+		$original_count = $wp_actions['init'] ?? 0;
 
 		// Reset the action count to simulate it not being fired.
 		unset( $wp_actions['init'] );
@@ -496,7 +496,7 @@ public function test_get_ability_no_init_action(): void {
 		global $wp_actions;
 
 		// Store the original action count.
-		$original_count = isset( $wp_actions['init'] ) ? $wp_actions['init'] : 0;
+		$original_count = $wp_actions['init'] ?? 0;
 
 		// Reset the action count to simulate it not being fired.
 		unset( $wp_actions['init'] );
@@ -559,7 +559,7 @@ public function test_has_ability_no_init_action(): void {
 		global $wp_actions;
 
 		// Store the original action count.
-		$original_count = isset( $wp_actions['init'] ) ? $wp_actions['init'] : 0;
+		$original_count = $wp_actions['init'] ?? 0;
 
 		// Reset the action count to simulate it not being fired.
 		unset( $wp_actions['init'] );
@@ -615,7 +615,7 @@ public function test_get_abilities_no_init_action(): void {
 		global $wp_actions;
 
 		// Store the original action count.
-		$original_count = isset( $wp_actions['init'] ) ? $wp_actions['init'] : 0;
+		$original_count = $wp_actions['init'] ?? 0;
 
 		// Reset the action count to simulate it not being fired.
 		unset( $wp_actions['init'] );
diff --git a/tests/phpunit/tests/abilities-api/wpRegisterAbilityCategory.php b/tests/phpunit/tests/abilities-api/wpRegisterAbilityCategory.php
@@ -82,7 +82,7 @@ public function test_register_ability_category_no_init_action(): void {
 		global $wp_actions;
 
 		// Store the original action count.
-		$original_count = isset( $wp_actions['init'] ) ? $wp_actions['init'] : 0;
+		$original_count = $wp_actions['init'] ?? 0;
 
 		// Reset the action count to simulate it not being fired.
 		unset( $wp_actions['init'] );
@@ -132,7 +132,7 @@ public function test_unregister_ability_category_no_init_action(): void {
 		global $wp_actions;
 
 		// Store the original action count.
-		$original_count = isset( $wp_actions['init'] ) ? $wp_actions['init'] : 0;
+		$original_count = $wp_actions['init'] ?? 0;
 
 		// Reset the action count to simulate it not being fired.
 		unset( $wp_actions['init'] );
@@ -194,7 +194,7 @@ public function test_has_ability_category_no_init_action(): void {
 		global $wp_actions;
 
 		// Store the original action count.
-		$original_count = isset( $wp_actions['init'] ) ? $wp_actions['init'] : 0;
+		$original_count = $wp_actions['init'] ?? 0;
 
 		// Reset the action count to simulate it not being fired.
 		unset( $wp_actions['init'] );
@@ -255,7 +255,7 @@ public function test_get_ability_category_no_init_action(): void {
 		global $wp_actions;
 
 		// Store the original action count.
-		$original_count = isset( $wp_actions['init'] ) ? $wp_actions['init'] : 0;
+		$original_count = $wp_actions['init'] ?? 0;
 
 		// Reset the action count to simulate it not being fired.
 		unset( $wp_actions['init'] );
@@ -328,7 +328,7 @@ public function test_get_ability_categories_no_init_action(): void {
 		global $wp_actions;
 
 		// Store the original action count.
-		$original_count = isset( $wp_actions['init'] ) ? $wp_actions['init'] : 0;
+		$original_count = $wp_actions['init'] ?? 0;
 
 		// Reset the action count to simulate it not being fired.
 		unset( $wp_actions['init'] );
diff --git a/tests/phpunit/tests/admin/wpPluginsListTable.php b/tests/phpunit/tests/admin/wpPluginsListTable.php
@@ -137,7 +137,7 @@ public function test_get_views_should_return_views_by_default() {
 	 * @param string $status The value for $_REQUEST['plugin_status'].
 	 */
 	public function test_construct_should_not_set_show_autoupdates_to_false_for_mustuse_and_dropins( $status ) {
-		$original_status           = isset( $_REQUEST['plugin_status'] ) ? $_REQUEST['plugin_status'] : null;
+		$original_status           = $_REQUEST['plugin_status'] ?? null;
 		$_REQUEST['plugin_status'] = $status;
 
 		// Enable plugin auto-updates.
diff --git a/tests/phpunit/tests/block-bindings/postMetaSource.php b/tests/phpunit/tests/block-bindings/postMetaSource.php
@@ -28,7 +28,7 @@ private function get_modified_post_content( $content ) {
 	 */
 	public static function wpSetUpBeforeClass( WP_UnitTest_Factory $factory ) {
 		self::$post               = $factory->post->create_and_get();
-		self::$wp_meta_keys_saved = isset( $GLOBALS['wp_meta_keys'] ) ? $GLOBALS['wp_meta_keys'] : array();
+		self::$wp_meta_keys_saved = $GLOBALS['wp_meta_keys'] ?? array();
 	}
 
 	/**
diff --git a/tests/phpunit/tests/cron.php b/tests/phpunit/tests/cron.php
@@ -460,7 +460,7 @@ public function filter_pre_schedule_event_filter( $result, $event ) {
 
 		$this->preflight_cron_array[ $event->timestamp ][ $event->hook ][ $key ] = array(
 			'schedule' => $event->schedule,
-			'interval' => isset( $event->interval ) ? $event->interval : 0,
+			'interval' => $event->interval ?? 0,
 			'args'     => $event->args,
 		);
 		uksort( $this->preflight_cron_array, 'strnatcasecmp' );
diff --git a/tests/phpunit/tests/dependencies/scripts.php b/tests/phpunit/tests/dependencies/scripts.php
@@ -37,9 +37,9 @@ class Tests_Dependencies_Scripts extends WP_UnitTestCase {
 
 	public function set_up() {
 		parent::set_up();
-		$this->old_wp_scripts          = isset( $GLOBALS['wp_scripts'] ) ? $GLOBALS['wp_scripts'] : null;
-		$this->old_wp_styles           = isset( $GLOBALS['wp_styles'] ) ? $GLOBALS['wp_styles'] : null;
-		$this->old_concatenate_scripts = isset( $GLOBALS['concatenate_scripts'] ) ? $GLOBALS['concatenate_scripts'] : null;
+		$this->old_wp_scripts          = $GLOBALS['wp_scripts'] ?? null;
+		$this->old_wp_styles           = $GLOBALS['wp_styles'] ?? null;
+		$this->old_concatenate_scripts = $GLOBALS['concatenate_scripts'] ?? null;
 		remove_action( 'wp_default_scripts', 'wp_default_scripts' );
 		remove_action( 'wp_default_scripts', 'wp_default_packages' );
 		$GLOBALS['wp_scripts']                  = new WP_Scripts();
diff --git a/tests/phpunit/tests/filesystem/wpFilesystemDirect/base.php b/tests/phpunit/tests/filesystem/wpFilesystemDirect/base.php
@@ -90,7 +90,7 @@ public function set_up() {
 			} elseif ( 'f' === $entry['type'] ) {
 				$this->create_file_if_needed(
 					$entry['path'],
-					isset( $entry['contents'] ) ? $entry['contents'] : ''
+					$entry['contents'] ?? ''
 				);
 			}
 		}
diff --git a/tests/phpunit/tests/fonts/font-library/wpRestFontFamiliesController.php b/tests/phpunit/tests/fonts/font-library/wpRestFontFamiliesController.php
@@ -1048,9 +1048,7 @@ protected function check_font_family_data( $data, $post_id, $links ) {
 			$expected = rest_url( 'wp/v2/font-families/' . $post->ID . '/font-faces/' . $font_face_ids[ $index ] );
 			$this->assertSame( $expected, $link['href'], 'The links for a font faces URL from the response data should match the REST endpoint.' );
 
-			$embeddable = isset( $link['attributes']['embeddable'] )
-				? $link['attributes']['embeddable']
-				: $link['embeddable'];
+			$embeddable = $link['attributes']['embeddable'] ?? $link['embeddable'];
 			$this->assertTrue( $embeddable, 'The embeddable should be true.' );
 		}
 	}
diff --git a/tests/phpunit/tests/general/wpResourceHints.php b/tests/phpunit/tests/general/wpResourceHints.php
@@ -12,8 +12,8 @@ class Tests_General_wpResourceHints extends WP_UnitTestCase {
 
 	public function set_up() {
 		parent::set_up();
-		$this->old_wp_scripts = isset( $GLOBALS['wp_scripts'] ) ? $GLOBALS['wp_scripts'] : null;
-		$this->old_wp_styles  = isset( $GLOBALS['wp_styles'] ) ? $GLOBALS['wp_styles'] : null;
+		$this->old_wp_scripts = $GLOBALS['wp_scripts'] ?? null;
+		$this->old_wp_styles  = $GLOBALS['wp_styles'] ?? null;
 
 		remove_action( 'wp_default_scripts', 'wp_default_scripts' );
 		remove_action( 'wp_default_styles', 'wp_default_styles' );
diff --git a/tests/phpunit/tests/interactivity-api/wpInteractivityAPI-wp-router-region.php b/tests/phpunit/tests/interactivity-api/wpInteractivityAPI-wp-router-region.php
@@ -45,7 +45,7 @@ public function set_up() {
 		$wp_filter['wp_footer']   = new WP_Hook();
 
 		// Removes all registered styles.
-		$this->original_wp_styles = isset( $GLOBALS['wp_styles'] ) ? $GLOBALS['wp_styles'] : null;
+		$this->original_wp_styles = $GLOBALS['wp_styles'] ?? null;
 		$GLOBALS['wp_styles']     = new WP_Styles();
 		remove_action( 'wp_default_styles', 'wp_default_styles' );
 		remove_action( 'wp_print_styles', 'print_emoji_styles' );
diff --git a/tests/phpunit/tests/l10n/loadScriptTextdomain.php b/tests/phpunit/tests/l10n/loadScriptTextdomain.php
@@ -20,7 +20,7 @@ class Tests_L10n_LoadScriptTextdomain extends WP_UnitTestCase {
 	 */
 	public function test_resolve_relative_path( $translation_path, $handle, $src, $textdomain, $filter = array() ) {
 		if ( ! empty( $filter ) ) {
-			add_filter( $filter[0], $filter[1], 10, isset( $filter[2] ) ? $filter[2] : 1 );
+			add_filter( $filter[0], $filter[1], 10, $filter[2] ?? 1 );
 		}
 		wp_enqueue_script( $handle, $src, array(), null );
 
diff --git a/tests/phpunit/tests/link/getAdjacentPost.php b/tests/phpunit/tests/link/getAdjacentPost.php
@@ -192,7 +192,7 @@ public function test_get_adjacent_post_excluded_terms() {
 		wp_set_post_terms( $p2, array( $t ), 'wptests_tax' );
 
 		// Fake current page.
-		$_post           = isset( $GLOBALS['post'] ) ? $GLOBALS['post'] : null;
+		$_post           = $GLOBALS['post'] ?? null;
 		$GLOBALS['post'] = get_post( $p1 );
 
 		$found = get_adjacent_post( false, array( $t ), true, 'wptests_tax' );
@@ -229,7 +229,7 @@ public function test_get_adjacent_post_excluded_terms_should_not_require_posts_t
 		wp_delete_object_term_relationships( $p3, 'category' );
 
 		// Fake current page.
-		$_post           = isset( $GLOBALS['post'] ) ? $GLOBALS['post'] : null;
+		$_post           = $GLOBALS['post'] ?? null;
 		$GLOBALS['post'] = get_post( $p1 );
 
 		$found = get_adjacent_post( false, array( $t ), true, 'wptests_tax' );
diff --git a/tests/phpunit/tests/oembed/controller.php b/tests/phpunit/tests/oembed/controller.php
@@ -93,7 +93,7 @@ public function mock_embed_request( $response, $parsed_args, $url ) {
 		unset( $response, $parsed_args );
 
 		$parsed_url = wp_parse_url( $url );
-		$query      = isset( $parsed_url['query'] ) ? $parsed_url['query'] : '';
+		$query      = $parsed_url['query'] ?? '';
 		parse_str( $query, $query_params );
 		$this->request_count += 1;
 
diff --git a/tests/phpunit/tests/post/thumbnails.php b/tests/phpunit/tests/post/thumbnails.php
@@ -287,7 +287,7 @@ public function test_the_post_thumbnail_url() {
 	 * @ticket 12922
 	 */
 	public function test__wp_preview_post_thumbnail_filter() {
-		$old_post = isset( $GLOBALS['post'] ) ? $GLOBALS['post'] : null;
+		$old_post = $GLOBALS['post'] ?? null;
 
 		$GLOBALS['post']           = self::$post;
 		$_REQUEST['_thumbnail_id'] = self::$attachment_id;
@@ -307,7 +307,7 @@ public function test__wp_preview_post_thumbnail_filter() {
 	 * @ticket 37697
 	 */
 	public function test__wp_preview_post_thumbnail_filter_secondary_post() {
-		$old_post = isset( $GLOBALS['post'] ) ? $GLOBALS['post'] : null;
+		$old_post = $GLOBALS['post'] ?? null;
 
 		$secondary_post = self::factory()->post->create(
 			array(
diff --git a/tests/phpunit/tests/rest-api/application-passwords.php b/tests/phpunit/tests/rest-api/application-passwords.php
@@ -154,7 +154,7 @@ public function test_update_application_password( array $update, array $existing
 		// Check updated only given values.
 		$updated_item = WP_Application_Passwords::get_user_application_password( self::$user_id, $uuid );
 		foreach ( $updated_item as $key => $update_value ) {
-			$expected_value = isset( $update[ $key ] ) ? $update[ $key ] : $original_item[ $key ];
+			$expected_value = $update[ $key ] ?? $original_item[ $key ];
 			$this->assertSame( $expected_value, $update_value );
 		}
 	}
diff --git a/tests/phpunit/tests/rest-api/rest-pattern-directory-controller.php b/tests/phpunit/tests/rest-api/rest-pattern-directory-controller.php
@@ -82,7 +82,7 @@ public function tear_down() {
 	 */
 	public function assertPatternMatchesSchema( $pattern ) {
 		$schema     = static::$controller->get_item_schema();
-		$pattern_id = isset( $pattern->id ) ? $pattern->id : '{pattern ID is missing}';
+		$pattern_id = $pattern->id ?? '{pattern ID is missing}';
 
 		$this->assertTrue(
 			rest_validate_value_from_schema( $pattern, $schema ),
diff --git a/tests/phpunit/tests/rest-api/rest-post-meta-fields.php b/tests/phpunit/tests/rest-api/rest-post-meta-fields.php
@@ -21,7 +21,7 @@ public static function wpSetUpBeforeClass( WP_UnitTest_Factory $factory ) {
 			)
 		);
 
-		self::$wp_meta_keys_saved = isset( $GLOBALS['wp_meta_keys'] ) ? $GLOBALS['wp_meta_keys'] : array();
+		self::$wp_meta_keys_saved = $GLOBALS['wp_meta_keys'] ?? array();
 		self::$post_id            = $factory->post->create();
 		self::$cpt_post_id        = $factory->post->create( array( 'post_type' => 'cpt' ) );
 	}
diff --git a/tests/phpunit/tests/rest-api/rest-term-meta-fields.php b/tests/phpunit/tests/rest-api/rest-term-meta-fields.php
@@ -21,7 +21,7 @@ public static function wpSetUpBeforeClass( WP_UnitTest_Factory $factory ) {
 			)
 		);
 
-		self::$wp_meta_keys_saved = isset( $GLOBALS['wp_meta_keys'] ) ? $GLOBALS['wp_meta_keys'] : array();
+		self::$wp_meta_keys_saved = $GLOBALS['wp_meta_keys'] ?? array();
 		self::$category_id        = $factory->category->create();
 		self::$customtax_term_id  = $factory->term->create( array( 'taxonomy' => 'customtax' ) );
 	}
diff --git a/tests/phpunit/tests/shortcode.php b/tests/phpunit/tests/shortcode.php
@@ -48,7 +48,7 @@ public function shortcode_test_shortcode_tag( $atts, $content = null, $tagname =
 
 	// [footag foo="bar"]
 	public function shortcode_footag( $atts ) {
-		$foo = isset( $atts['foo'] ) ? $atts['foo'] : '';
+		$foo = $atts['foo'] ?? '';
 		return "foo = $foo";
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -1313,7 +1313,7 @@ public function go_to( $url ) {`
`1313`	`1313`	`}`
`1314`	`1314`	`$parts = parse_url( $url );`
`1315`	`1315`	`if ( isset( $parts['scheme'] ) ) {`
`1316`		`- $req = isset( $parts['path'] ) ? $parts['path'] : '';`
	`1316`	`+ $req = $parts['path'] ?? '';`
`1317`	`1317`	`if ( isset( $parts['query'] ) ) {`
`1318`	`1318`	`$req .= '?' . $parts['query'];`
`1319`	`1319`	`// Parse the URL query vars into $_GET.`
Original file line number	Diff line number	Diff line change
`@@ -109,7 +109,7 @@ public function create_and_get( $args = array(), $generation_definitions = null`
`109`	`109`	`return $term_id;`
`110`	`110`	`}`
`111`	`111`
`112`		`- $taxonomy = isset( $args['taxonomy'] ) ? $args['taxonomy'] : $this->taxonomy;`
	`112`	`+ $taxonomy = $args['taxonomy'] ?? $this->taxonomy;`
`113`	`113`
`114`	`114`	`return get_term( $term_id, $taxonomy );`
`115`	`115`	`}`
Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ private function get_modified_post_content( $content ) {`
`28`	`28`	`*/`
`29`	`29`	`public static function wpSetUpBeforeClass( WP_UnitTest_Factory $factory ) {`
`30`	`30`	`self::$post = $factory->post->create_and_get();`
`31`		`- self::$wp_meta_keys_saved = isset( $GLOBALS['wp_meta_keys'] ) ? $GLOBALS['wp_meta_keys'] : array();`
	`31`	`+ self::$wp_meta_keys_saved = $GLOBALS['wp_meta_keys'] ?? array();`
`32`	`32`	`}`
`33`	`33`
`34`	`34`	`/**`