Updates WP_Query::parse_orderby to allow post_mime_type

Author: ramonjd

src/wp-includes/class-wp-query.php

@@ -1679,6 +1679,7 @@ protected function parse_search_order( &$q ) {
 	 * Converts the given orderby alias (if allowed) to a properly-prefixed value.
 	 *
 	 * @since 4.0.0
+	 * @since 6.9.0 Extends allowed_keys to support ordering by `post_mime_type`.
 	 *
 	 * @global wpdb $wpdb WordPress database abstraction object.
 	 *
@@ -1695,6 +1696,7 @@ protected function parse_orderby( $orderby ) {
 			'post_date',
 			'post_title',
 			'post_modified',
+			'post_mime_type',
 			'post_parent',
 			'post_type',
 			'name',
@@ -1748,6 +1750,7 @@ protected function parse_orderby( $orderby ) {
 			case 'post_author':
 			case 'post_date':
 			case 'post_title':
+			case 'post_mime_type':
 			case 'post_modified':
 			case 'post_parent':
 			case 'post_type':

src/wp-includes/rest-api/endpoints/class-wp-rest-attachments-controller.php

@@ -70,6 +70,7 @@ public function register_routes() {
 	 * prepares for WP_Query.
 	 *
 	 * @since 4.7.0
+	 * @since 6.9.0 Extends the `orderby` request argument to support `mime_type`.
 	 *
 	 * @param array           $prepared_args Optional. Array of prepared arguments. Default empty array.
 	 * @param WP_REST_Request $request       Optional. Request to prepare items for.
@@ -100,6 +101,17 @@ protected function prepare_items_query( $prepared_args = array(), $request = nul
 			add_filter( 'wp_allow_query_attachment_by_filename', '__return_true' );
 		}
 
+		// Map to proper WP_Query orderby param - this needs to happen AFTER parent class
+		if ( isset( $query_args['orderby'] ) && isset( $request['orderby'] ) ) {
+			$orderby_mappings = array(
+				'mime_type' => 'post_mime_type',
+			);
+
+			if ( isset( $orderby_mappings[ $request['orderby'] ] ) ) {
+				$query_args['orderby'] = $orderby_mappings[ $request['orderby'] ];
+			}
+		}
+
 		return $query_args;
 	}
 

tests/phpunit/tests/rest-api/rest-attachments-controller.php

@@ -2707,22 +2707,44 @@ public function test_get_items_orderby_mime_type() {
 			)
 		);
 
+		$avif_id = self::factory()->attachment->create_object(
+			self::$test_avif_file,
+			0,
+			array(
+				'post_mime_type' => 'video/avif',
+				'post_excerpt'   => 'A sample caption',
+			)
+		);
+
+		$svg_id = self::factory()->attachment->create_object(
+			self::$test_svg_file,
+			0,
+			array(
+				'post_mime_type' => 'image/svg+xml',
+				'post_excerpt'   => 'A sample caption',
+			)
+		);
+
 		$request = new WP_REST_Request( 'GET', '/wp/v2/media' );
+		$request->set_param( '_fields', 'id,mime_type' );
 
 		// Check ordering. Default ORDER is DESC.
 		$request->set_param( 'orderby', 'mime_type' );
 		$response = rest_get_server()->dispatch( $request );
 		$data     = $response->get_data();
-		$this->assertCount( 2, $data, 'Response count for orderby DESC mime_type is not 2' );
-		$this->assertSame( $png_id, $data[0]['id'], 'PNG ID not found in response for orderby DESC mime_type' );
-		$this->assertSame( $jpeg_id, $data[1]['id'], 'JPEG ID not found in response for orderby DESC mime_type' );
+		$this->assertCount( 4, $data, 'Response count for orderby DESC mime_type is not 4' );
+		// Check that ordering is working by verifying the mime types are in order
+		$mime_types    = array_column( $data, 'mime_type' );
+		$expected_desc = array( 'video/avif', 'image/svg+xml', 'image/png', 'image/jpeg' );
+		$this->assertSame( $expected_desc, $mime_types, 'MIME types not in expected DESC order' );
 
 		// ASC order.
 		$request->set_param( 'order', 'asc' );
 		$response = rest_get_server()->dispatch( $request );
 		$data     = $response->get_data();
-		$this->assertCount( 2, $data, 'Response count for orderby ASC mime_type is not 2' );
-		$this->assertSame( $jpeg_id, $data[0]['id'], 'JPEG ID not found in response for orderby ASC mime_type' );
-		$this->assertSame( $png_id, $data[1]['id'], 'PNG ID not found in response for orderby ASC mime_type' );
+
+		$mime_types   = array_column( $data, 'mime_type' );
+		$expected_asc = array( 'image/jpeg', 'image/png', 'image/svg+xml', 'video/avif' );
+		$this->assertSame( $expected_asc, $mime_types, 'MIME types not in expected ASC order' );
 	}
 }