REST API: Log doing_it_wrong notices to debug.log

Fixes #64260. The doing_it_wrong_trigger_error filter was preventing
all doing_it_wrong notices from being logged during REST requests.
This change ensures notices are written to debug.log while still
preventing trigger_error() from interfering with REST responses.

Author: claudiobat

src/wp-includes/rest-api.php

@@ -248,35 +248,6 @@ function rest_api_default_filters() {
 		add_filter( 'doing_it_wrong_trigger_error', 'rest_handle_doing_it_wrong_trigger_error', 10, 4 );
 	}
 
-	/**
-	 * Handles doing_it_wrong errors for REST API requests.
-	 *
-	 * Logs doing_it_wrong notices to the debug log during REST API requests
-	 * while preventing trigger_error() from interfering with JSON responses.
-	 *
-	 * @since 7.0.0
-	 *
-	 * @param bool   $trigger       Whether to trigger an error.
-	 * @param string $function_name The function that was called incorrectly.
-	 * @param string $message       A message explaining what was called incorrectly.
-	 * @param string $version       The version of WordPress where the message was added.
-	 * @return bool Always returns false to prevent trigger_error().
-	 */
-	function rest_handle_doing_it_wrong_trigger_error( $trigger, $function_name, $message, $version ) {
-		if ( defined( 'WP_DEBUG_LOG' ) && WP_DEBUG_LOG ) {
-			$log_message = sprintf(
-				'REST API - Doing it wrong: %s - %s',
-				$function_name,
-				$message
-			);
-			if ( $version ) {
-				$log_message .= sprintf( ' (This message was added in version %s.)', $version );
-			}
-			error_log( $log_message );
-		}
-		return false;
-	}
-
 	// Default serving.
 	add_filter( 'rest_pre_serve_request', 'rest_send_cors_headers' );
 	add_filter( 'rest_post_dispatch', 'rest_send_allow_header', 10, 3 );
@@ -286,6 +257,38 @@ function rest_handle_doing_it_wrong_trigger_error( $trigger, $function_name, $me
 	add_filter( 'rest_index', 'rest_add_application_passwords_to_index' );
 }
 
+/**
+ * Handles doing_it_wrong errors for REST API requests.
+ *
+ * Logs doing_it_wrong notices to the debug log during REST API requests
+ * while preventing trigger_error() from interfering with JSON responses.
+ *
+ * @since 6.x.0
+ *
+ * @param bool   $trigger       Whether to trigger an error.
+ * @param string $function_name The function that was called incorrectly.
+ * @param string $message       A message explaining what was called incorrectly.
+ * @param string $version       The version of WordPress where the message was added.
+ * @return bool Always returns false to prevent trigger_error().
+ */
+function rest_handle_doing_it_wrong_trigger_error( $trigger, $function_name, $message, $version ) {
+	// Only log when WordPress debugging and debug logging are enabled.
+	if ( defined( 'WP_DEBUG' ) && WP_DEBUG && defined( 'WP_DEBUG_LOG' ) && WP_DEBUG_LOG ) {
+		$log_message = sprintf(
+			'REST API: %1$s was called incorrectly. %2$s',
+			$function_name,
+			$message
+		);
+		if ( ! empty( $version ) ) {
+			$log_message .= sprintf( ' (This message was added in version %s.)', $version );
+		}
+		error_log( $log_message );
+	}
+
+	// Prevent PHP's trigger_error() to avoid corrupting JSON responses.
+	return false;
+}
+
 /**
  * Registers default REST API routes.
  *