Embeds: Correct error handling in _oembed_rest_pre_serve_request().

SergeyBiryukov · SergeyBiryukov · commit 9082d4bee3ca · 2025-07-09T18:33:47.000Z
Since the function is supposed to output a string and only return a boolean value, this commit ensures that an error message is properly displayed, bringing consistency with a similar fragment a few lines above. Follow-up to [35436]. Props abcd95, oglekler, SergeyBiryukov. Fixes #63652. git-svn-id: https://develop.svn.wordpress.org/trunk@60443 602fd350-edb4-49c9-b593-d223f7449a82
diff --git a/src/wp-includes/embed.php b/src/wp-includes/embed.php
@@ -791,7 +791,7 @@ function _oembed_rest_pre_serve_request( $served, $result, $request, $server ) {
 	// Bail if there's no XML.
 	if ( ! $result ) {
 		status_header( 501 );
-		return get_status_header_desc( 501 );
+		die( get_status_header_desc( 501 ) );
 	}
 
 	if ( ! headers_sent() ) {

Original file line number	Diff line number	Diff line change
`@@ -791,7 +791,7 @@ function _oembed_rest_pre_serve_request( $served, $result, $request, $server ) {`
`791`	`791`	`// Bail if there's no XML.`
`792`	`792`	`if ( ! $result ) {`
`793`	`793`	`status_header( 501 );`
`794`		`- return get_status_header_desc( 501 );`
	`794`	`+ die( get_status_header_desc( 501 ) );`
`795`	`795`	`}`
`796`	`796`
`797`	`797`	`if ( ! headers_sent() ) {`