PHPStan: restore and baseline inner function smells.

Author: justlevine

phpstan.neon.dist

@@ -22,19 +22,18 @@ parameters:
 	reportUnmatchedIgnoredErrors: true
 
 	ignoreErrors:
-		# Inner functions aren't supported:
-		- '#Inner named functions are not supported by PHPStan#'
-		# Inner functions within the importer:
-		- '#Function wxr_[a-z_]+ not found#'
+		# Level 0:
+		- # Inner functions arent supported by PHPstan.
+			message: '#Function wxr_[a-z_]+ not found#'
+			path: src/wp-admin/includes/export.php
 
 		# Level 1:
-
-		# These are too noisy at the moment.
-		- '#Variable \$[a-zA-Z0-9_]+ might not be defined\.#'
+		- These are too noisy at the moment.
+		  message: '#Variable \$[a-zA-Z0-9_]+ might not be defined\.#'
 
 		# Level 2:
-		# Callable-strings are used as callables in WordPress.
-		- '#Default value of the parameter .* is incompatible with type callable.*#'
+		- # Callable-strings are used as callables in WordPress.
+		  message: '#Default value of the parameter .* is incompatible with type callable.*#'
 
 		# Level 6:
 		- # WPCS syntax for iterable types is not supported.

tests/phpstan/baseline/level-0.php

@@ -7,6 +7,18 @@
 	'count' => 1,
 	'path' => __DIR__ . '/../../../src/wp-admin/includes/class-wp-filesystem-ssh2.php',
 ];
+$ignoreErrors[] = [
+	'message' => '#^Inner named functions are not supported by PHPStan\\. Consider refactoring to an anonymous function, class method, or a top\\-level\\-defined function\\. See issue \\#165 \\(https\\://github\\.com/phpstan/phpstan/issues/165\\) for more details\\.$#',
+	'identifier' => 'function.inner',
+	'count' => 13,
+	'path' => __DIR__ . '/../../../src/wp-admin/includes/export.php',
+];
+$ignoreErrors[] = [
+	'message' => '#^Inner named functions are not supported by PHPStan\\. Consider refactoring to an anonymous function, class method, or a top\\-level\\-defined function\\. See issue \\#165 \\(https\\://github\\.com/phpstan/phpstan/issues/165\\) for more details\\.$#',
+	'identifier' => 'function.inner',
+	'count' => 1,
+	'path' => __DIR__ . '/../../../src/wp-admin/includes/file.php',
+];
 $ignoreErrors[] = [
 	'message' => '#^Function get_file not found\\.$#',
 	'identifier' => 'function.notFound',
@@ -31,6 +43,12 @@
 	'count' => 1,
 	'path' => __DIR__ . '/../../../src/wp-admin/press-this.php',
 ];
+$ignoreErrors[] = [
+	'message' => '#^Inner named functions are not supported by PHPStan\\. Consider refactoring to an anonymous function, class method, or a top\\-level\\-defined function\\. See issue \\#165 \\(https\\://github\\.com/phpstan/phpstan/issues/165\\) for more details\\.$#',
+	'identifier' => 'function.inner',
+	'count' => 1,
+	'path' => __DIR__ . '/../../../src/wp-includes/canonical.php',
+];
 $ignoreErrors[] = [
 	'message' => '#^Method WP_Theme_JSON\\:\\:should_override_preset\\(\\) should return bool but return statement is missing\\.$#',
 	'identifier' => 'return.missing',