Coding Standards: Move specific sniff exclusions for PHPMailer to the config file.

This aims to make future updates of the library easier.

Follow-up to [48045], [51635].

See #63168.

git-svn-id: https://develop.svn.wordpress.org/trunk@60797 602fd350-edb4-49c9-b593-d223f7449a82

Author: SergeyBiryukov

phpcompat.xml.dist

@@ -76,6 +76,15 @@
 	#############################################################################
 	-->
 
+	<rule ref="PHPCompatibility.IniDirectives.RemovedIniDirectives.mbstring_func_overloadDeprecated">
+		<exclude-pattern>/PHPMailer/PHPMailer\.php$</exclude-pattern>
+	</rule>
+	<rule ref="PHPCompatibility.Constants.RemovedConstants.intl_idna_variant_2003Deprecated">
+		<exclude-pattern>/PHPMailer/PHPMailer\.php$</exclude-pattern>
+	</rule>
+	<rule ref="PHPCompatibility.ParameterValues.NewIDNVariantDefault.NotSet">
+		<exclude-pattern>/PHPMailer/PHPMailer\.php$</exclude-pattern>
+	</rule>
 	<rule ref="PHPCompatibility.FunctionUse.NewFunctions.sodium_crypto_sign_keypair_from_secretkey_and_publickeyFound">
 		<exclude-pattern>/sodium_compat/src/Compat\.php$</exclude-pattern>
 	</rule>

src/wp-includes/PHPMailer/PHPMailer.php

@@ -876,7 +876,7 @@ public function __destruct()
     private function mailPassthru($to, $subject, $body, $header, $params)
     {
         //Check overloading of mail function to avoid double-encoding
-        if ((int)ini_get('mbstring.func_overload') & 1) { // phpcs:ignore PHPCompatibility.IniDirectives.RemovedIniDirectives.mbstring_func_overloadDeprecated
+        if ((int)ini_get('mbstring.func_overload') & 1) {
             $subject = $this->secureHeader($subject);
         } else {
             $subject = $this->encodeHeader($this->secureHeader($subject));
@@ -1532,11 +1532,9 @@ public function punyencodeAddress($address)
                     );
                 } elseif (defined('INTL_IDNA_VARIANT_2003')) {
                     //Fall back to this old, deprecated/removed encoding
-                    // phpcs:ignore PHPCompatibility.Constants.RemovedConstants.intl_idna_variant_2003Deprecated
                     $punycode = idn_to_ascii($domain, $errorcode, \INTL_IDNA_VARIANT_2003);
                 } else {
                     //Fall back to a default we don't know about
-                    // phpcs:ignore PHPCompatibility.ParameterValues.NewIDNVariantDefault.NotSet
                     $punycode = idn_to_ascii($domain, $errorcode);
                 }
                 if (false !== $punycode) {