Commit 9b9049c
committed
CI/Build: Build Gutenberg before installing Core dependencies.
Because of a strange interaction with building Gutenberg from within the plugins directory, TypeScript was appearing to examine code for which it should have no access up the filesystem hierarchy.
This patch changes the order of building Gutenberg so that it occurs before those parent directories contain TypeScript code (by installing the `npm` dependencies) and thus frees up the builds.
This change should not serve as a workaround to avoid fixing the root issue, introduced in WordPress/gutenberg@8401993. Rather, it should be seen as at least a temporary way to remove the trigger of the problem during CI builds.
See also alternative work:
- To build Gutenberg outside of the plugin directory in https://github.com/WordPress/wordpress-develop/pull/10282/files.
- To patch the broken `@wordpress/blocks` types inside of `@wordpress/core-data`.
Developed in #10283
Props czarate, desrosj, dmsnell, ellatrix, jorbin, peterwilsoncc, ramonopoly, westonruter, youknowriad.
git-svn-id: https://develop.svn.wordpress.org/trunk@60985 602fd350-edb4-49c9-b593-d223f7449a821 parent f6cf8fa commit 9b9049c
1 file changed
+4
-4
lines changedLines changed: 4 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
37 | | - | |
38 | 37 | | |
39 | 38 | | |
| 39 | + | |
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
| |||
78 | 78 | | |
79 | 79 | | |
80 | 80 | | |
81 | | - | |
82 | | - | |
83 | | - | |
84 | 81 | | |
85 | 82 | | |
86 | 83 | | |
| |||
89 | 86 | | |
90 | 87 | | |
91 | 88 | | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
92 | 92 | | |
93 | 93 | | |
94 | 94 | | |
| |||
0 commit comments