Skip to content

Commit 9bef715

Browse files
johnbillionjohnbillion
committed
Remove testing on PHP 7.2 and 7.3.
1 parent ebe805a commit 9bef715

File tree

7 files changed

+13
-172
lines changed

7 files changed

+13
-172
lines changed

‎.github/workflows/phpunit-tests.yml‎

Lines changed: 5 additions & 71 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ jobs:
7373
matrix:
7474
event: ['${{ github.event_name }}']
7575
os: [ ubuntu-24.04 ]
76-
php: [ '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3', '8.4', '8.5' ]
76+
php: [ '7.4', '8.0', '8.1', '8.2', '8.3', '8.4', '8.5' ]
7777
db-image: [ 'mysql:5.7', 'mysql:8.0', 'mysql:8.4' ]
7878
tests-domain: [ 'example.org' ]
7979
multisite: [ false, true ]
@@ -82,18 +82,6 @@ jobs:
8282
exclude:
8383
# Trim the matrix on Pull Requests to reduce the number of concurrent jobs.
8484
# Each PHP version is tested againgst one version of MySQL.
85-
- event: pull_request
86-
php: '7.2'
87-
db-version: '8.0'
88-
- event: pull_request
89-
php: '7.2'
90-
db-version: '8.4'
91-
- event: pull_request
92-
php: '7.3'
93-
db-version: '5.7'
94-
- event: pull_request
95-
php: '7.3'
96-
db-version: '8.4'
9785
- event: pull_request
9886
php: '7.4'
9987
db-image: 'mysql:5.7'
@@ -202,7 +190,7 @@ jobs:
202190
matrix:
203191
event: ['${{ github.event_name }}']
204192
os: [ ubuntu-24.04 ]
205-
php: [ '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3', '8.4', '8.5' ]
193+
php: [ '7.4', '8.0', '8.1', '8.2', '8.3', '8.4', '8.5' ]
206194
db-image: [ 'mariadb:5.5', 'mariadb:10.3', 'mariadb:10.4', 'mariadb:10.5', 'mariadb:10.6', 'mariadb:10.11', 'mariadb:11.4', 'mariadb:11.8' ]
207195
multisite: [ false, true ]
208196
memcached: [ false ]
@@ -211,48 +199,6 @@ jobs:
211199
# Trim the matrix on Pull Requests to reduce the number of concurrent jobs.
212200
# Each PHP version is tested against one version of MariaDB.
213201
# Each MariaDB version is tested at least once.
214-
- event: pull_request
215-
php: '7.2'
216-
db-version: '10.3'
217-
- event: pull_request
218-
php: '7.2'
219-
db-version: '10.4'
220-
- event: pull_request
221-
php: '7.2'
222-
db-version: '10.5'
223-
- event: pull_request
224-
php: '7.2'
225-
db-version: '10.6'
226-
- event: pull_request
227-
php: '7.2'
228-
db-version: '10.11'
229-
- event: pull_request
230-
php: '7.2'
231-
db-version: '11.4'
232-
- event: pull_request
233-
php: '7.2'
234-
db-version: '11.8'
235-
- event: pull_request
236-
php: '7.3'
237-
db-version: '5.5'
238-
- event: pull_request
239-
php: '7.3'
240-
db-version: '10.4'
241-
- event: pull_request
242-
php: '7.3'
243-
db-version: '10.5'
244-
- event: pull_request
245-
php: '7.3'
246-
db-version: '10.6'
247-
- event: pull_request
248-
php: '7.3'
249-
db-version: '10.11'
250-
- event: pull_request
251-
php: '7.3'
252-
db-version: '11.4'
253-
- event: pull_request
254-
php: '7.3'
255-
db-version: '11.8'
256202
- event: pull_request
257203
php: '7.4'
258204
db-image: 'mariadb:5.5'
@@ -445,26 +391,14 @@ jobs:
445391
matrix:
446392
event: ['${{ github.event_name }}']
447393
os: [ ubuntu-24.04 ]
448-
php: [ '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3', '8.4', '8.5' ]
394+
php: [ '7.4', '8.0', '8.1', '8.2', '8.3', '8.4', '8.5' ]
449395
db-image: [ 'mysql:9.4', 'mariadb:12.0' ]
450396
multisite: [ false, true ]
451397
memcached: [ false ]
452398
db-innovation: [ true ]
453399

454400
exclude:
455-
# MySQL 9.0+ will not work on PHP <= 7.3 because mysql_native_password was removed. See https://core.trac.wordpress.org/ticket/61218.
456-
- php: '7.2'
457-
db-version: '9.4'
458-
- php: '7.3'
459-
db-version: '9.4'
460-
# Exclude version combinations that don't exist.
461-
- db-type: 'mariadb'
462-
db-version: '9.4'
463-
- db-type: 'mysql'
464-
db-version: '12.0'
465401
# On Pull requests, only test each innovation release once.
466-
- event: pull_request
467-
php: '7.3'
468402
- event: pull_request
469403
php: '7.4'
470404
- event: pull_request
@@ -508,7 +442,7 @@ jobs:
508442
strategy:
509443
fail-fast: false
510444
matrix:
511-
php: [ '7.2', '7.4', '8.0', '8.4' ]
445+
php: [ '7.4', '8.0', '8.4' ]
512446
db-image: [ 'mysql:8.4' ]
513447
phpunit-test-groups: [ 'html-api-html5lib-tests' ]
514448
# A matrix value is needed in the 'name' directive for proper grouping in the GitHub UI.
@@ -535,7 +469,7 @@ jobs:
535469
strategy:
536470
fail-fast: false
537471
matrix:
538-
php: [ '7.2', '8.4' ]
472+
php: [ '7.4', '8.4' ]
539473
db-image: [ 'mysql:8.4', 'mariadb:11.8', ]
540474
multisite: [ false ]
541475

‎.github/workflows/upgrade-develop-testing.yml‎

Lines changed: 3 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -63,19 +63,11 @@ jobs:
6363
fail-fast: false
6464
matrix:
6565
os: [ 'ubuntu-24.04' ]
66-
php: [ '7.2', '8.4' ]
66+
php: [ '7.4', '8.4' ]
6767
db-image: [ 'mysql:5.7', 'mysql:8.4' ]
68-
# WordPress 4.9 is the oldest version that supports PHP 7.2.
69-
wp: [ '4.9', '6.6', '6.7', '6.8' ]
68+
# WordPress 5.3 is the oldest version that supports PHP 7.4.
69+
wp: [ '5.3', '6.6', '6.7', '6.8' ]
7070
multisite: [ false, true ]
71-
72-
exclude:
73-
# The PHP <= 7.3/MySQL 8.4 jobs currently fail due to mysql_native_password being disabled by default. See https://core.trac.wordpress.org/ticket/61218.
74-
- php: '7.2'
75-
db-version: '8.4'
76-
# WordPress 4.9 does not support PHP 8.4.
77-
- php: '8.4'
78-
wp: '4.9'
7971
with:
8072
os: ${{ matrix.os }}
8173
php: ${{ matrix.php }}
@@ -98,14 +90,8 @@ jobs:
9890
os: [ 'ubuntu-24.04' ]
9991
php: [ '7.2', '8.4' ]
10092
db-image: [ 'mysql:8.4' ]
101-
# WordPress 4.9 is the oldest version that supports PHP 7.2.
10293
wp: [ '6.7', '6.8' ]
10394
multisite: [ false, true ]
104-
105-
exclude:
106-
# The PHP <= 7.3/MySQL 8.4 jobs currently fail due to mysql_native_password being disabled by default. See https://core.trac.wordpress.org/ticket/61218.
107-
- php: '7.2'
108-
db-version: '8.4'
10995
with:
11096
os: ${{ matrix.os }}
11197
php: ${{ matrix.php }}

‎.github/workflows/upgrade-testing.yml‎

Lines changed: 5 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -68,22 +68,10 @@ jobs:
6868
fail-fast: false
6969
matrix:
7070
os: [ 'ubuntu-24.04' ]
71-
php: [ '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3', '8.4', '8.5' ]
71+
php: [ '7.4', '8.0', '8.1', '8.2', '8.3', '8.4', '8.5' ]
7272
db-image: [ 'mysql:5.7', 'mysql:8.0', 'mysql:8.4', 'mysql:9.4' ]
7373
wp: [ '6.7', '6.8' ]
7474
multisite: [ false, true ]
75-
76-
exclude:
77-
# The PHP <= 7.3/MySQL 8.4 jobs currently fail due to mysql_native_password being disabled by default. See https://core.trac.wordpress.org/ticket/61218.
78-
- php: '7.2'
79-
db-version: '8.4'
80-
- php: '7.3'
81-
db-version: '8.4'
82-
# MySQL 9.0+ will not work on PHP 7.2 & 7.3. See https://core.trac.wordpress.org/ticket/61218.
83-
- php: '7.2'
84-
db-version: '9.4'
85-
- php: '7.3'
86-
db-version: '9.4'
8775
with:
8876
os: ${{ matrix.os }}
8977
php: ${{ matrix.php }}
@@ -103,15 +91,10 @@ jobs:
10391
fail-fast: false
10492
matrix:
10593
os: [ 'ubuntu-24.04' ]
106-
php: [ '7.2', '7.4', '8.0', '8.4' ]
94+
php: [ '7.4', '8.0', '8.4' ]
10795
db-image: [ 'mysql:5.7', 'mysql:8.4' ]
10896
wp: [ '6.0', '6.3', '6.4', '6.5' ]
10997
multisite: [ false, true ]
110-
111-
exclude:
112-
# The PHP <= 7.3/MySQL 8.4 jobs currently fail due to mysql_native_password being disabled by default. See https://core.trac.wordpress.org/ticket/61218.
113-
- php: '7.2'
114-
db-version: '8.4'
11598
with:
11699
os: ${{ matrix.os }}
117100
php: ${{ matrix.php }}
@@ -131,15 +114,10 @@ jobs:
131114
fail-fast: false
132115
matrix:
133116
os: [ 'ubuntu-24.04' ]
134-
php: [ '7.2', '7.4' ]
117+
php: [ '7.4' ]
135118
db-image: [ 'mysql:5.7', 'mysql:8.4' ]
136-
wp: [ '5.0', '5.1', '5.3', '5.4', '5.5', '5.6', '5.9' ]
119+
wp: [ '5.3', '5.4', '5.5', '5.6', '5.9' ]
137120
multisite: [ false, true ]
138-
139-
exclude:
140-
# The PHP <= 7.3/MySQL 8.4 jobs currently fail due to mysql_native_password being disabled by default. See https://core.trac.wordpress.org/ticket/61218.
141-
- php: '7.2'
142-
db-version: '8.4'
143121
with:
144122
os: ${{ matrix.os }}
145123
php: ${{ matrix.php }}
@@ -191,22 +169,10 @@ jobs:
191169
fail-fast: false
192170
matrix:
193171
os: [ 'ubuntu-24.04' ]
194-
php: [ '7.2', '7.3', '7.4' ]
172+
php: [ '7.4' ]
195173
db-image: [ 'mysql:5.7', 'mysql:8.0', 'mysql:8.4', 'mysql:9.4' ]
196174
wp: [ '4.7' ]
197175
multisite: [ false, true ]
198-
199-
exclude:
200-
# The PHP <= 7.3/MySQL 8.4 jobs currently fail due to mysql_native_password being disabled by default. See https://core.trac.wordpress.org/ticket/61218.
201-
- php: '7.2'
202-
db-version: '8.4'
203-
- php: '7.3'
204-
db-version: '8.4'
205-
# MySQL 9.0+ will not work on PHP 7.2 & 7.3. See https://core.trac.wordpress.org/ticket/61218.
206-
- php: '7.2'
207-
db-version: '9.4'
208-
- php: '7.3'
209-
db-version: '9.4'
210176
with:
211177
os: ${{ matrix.os }}
212178
php: ${{ matrix.php }}

‎docker-compose.yml‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -79,9 +79,6 @@ services:
7979
- ./tools/local-env/mysql-init.sql:/docker-entrypoint-initdb.d/mysql-init.sql
8080
- mysql:/var/lib/mysql
8181

82-
# For compatibility with PHP versions that don't support the caching_sha2_password auth plugin used in MySQL 8.0.
83-
command: ${LOCAL_DB_AUTH_OPTION-}
84-
8582
healthcheck:
8683
test: [
8784
'CMD-SHELL',

‎tools/local-env/scripts/install.js‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,6 @@ const local_env_utils = require( './utils' );
99

1010
dotenvExpand.expand( dotenv.config() );
1111

12-
// Determine if a non-default database authentication plugin needs to be used.
13-
local_env_utils.determine_auth_option();
14-
1512
// Create wp-config.php.
1613
wp_cli( `config create --dbname=wordpress_develop --dbuser=root --dbpass=password --dbhost=mysql --force --config-file="wp-config.php"` );
1714

‎tools/local-env/scripts/start.js‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,6 @@ dotenvExpand.expand( dotenv.config() );
1515

1616
const composeFiles = local_env_utils.get_compose_files();
1717

18-
// Determine if a non-default database authentication plugin needs to be used.
19-
local_env_utils.determine_auth_option();
20-
2118
// Check if the Docker service is running.
2219
try {
2320
execSync( 'docker info' );

‎tools/local-env/scripts/utils.js‎

Lines changed: 0 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,6 @@ const local_env_utils = {
1010
*
1111
* By default, only the standard docker-compose.yml file will be used.
1212
*
13-
* When PHP 7.2 or 7.3 is used in combination with MySQL 8.4, an override file will also be returned to ensure
14-
* that the mysql_native_password plugin authentication plugin is on and available for use.
15-
*
1613
* @return {string[]} Compose files.
1714
*/
1815
get_compose_files: function() {
@@ -22,42 +19,9 @@ const local_env_utils = {
2219
composeFiles.push( 'docker-compose.override.yml' );
2320
}
2421

25-
if ( process.env.LOCAL_DB_TYPE !== 'mysql' ) {
26-
return composeFiles;
27-
}
28-
29-
if ( process.env.LOCAL_PHP !== '7.2-fpm' && process.env.LOCAL_PHP !== '7.3-fpm' ) {
30-
return composeFiles;
31-
}
32-
33-
// PHP 7.2/7.3 in combination with MySQL 8.4 requires additional configuration to function properly.
34-
if ( process.env.LOCAL_DB_VERSION === '8.4' ) {
35-
composeFiles.push( 'tools/local-env/old-php-mysql-84.override.yml' );
36-
}
37-
3822
return composeFiles;
3923
},
4024

41-
/**
42-
* Determines the option to pass for proper authentication plugin configuration given the specified PHP version,
43-
* database type, and database version.
44-
*/
45-
determine_auth_option: function() {
46-
if ( process.env.LOCAL_DB_TYPE !== 'mysql' ) {
47-
return;
48-
}
49-
50-
if ( process.env.LOCAL_PHP !== '7.2-fpm' && process.env.LOCAL_PHP !== '7.3-fpm' ) {
51-
return;
52-
}
53-
54-
// MySQL 8.4 removed --default-authentication-plugin in favor of --authentication-policy.
55-
if ( process.env.LOCAL_DB_VERSION === '8.4' ) {
56-
process.env.LOCAL_DB_AUTH_OPTION = '--authentication-policy=mysql_native_password';
57-
} else {
58-
process.env.LOCAL_DB_AUTH_OPTION = '--default-authentication-plugin=mysql_native_password';
59-
}
60-
}
6125
};
6226

6327
module.exports = local_env_utils;

0 commit comments

Comments
 (0)