HTML API: Code improvements following [58472].

audrasjb · audrasjb · commit 9e94297d20b2 · 2024-06-24T14:55:32.000Z
Props xknown, jorbin. Unprops audrasjb. git-svn-id: https://develop.svn.wordpress.org/trunk@58473 602fd350-edb4-49c9-b593-d223f7449a82
diff --git a/src/wp-includes/html-api/class-wp-html-tag-processor.php b/src/wp-includes/html-api/class-wp-html-tag-processor.php
@@ -2980,8 +2980,8 @@ public function set_attribute( $name, $value ) {
 			 *
 			 * @see https://html.spec.whatwg.org/#attributes-3
 			 */
-			$escaped_new_value = esc_attr( $value );
-			$updated_attribute = wp_kses_one_attr( "{$comparable_name}=\"{$escaped_new_value}\"", $tag_name );
+			$escaped_new_value = in_array( $comparable_name, wp_kses_uri_attributes() ) ? esc_url( $value ) : esc_attr( $value );
+			$updated_attribute = "{$name}=\"{$escaped_new_value}\"";
 		}
 
 		/*

Original file line number	Diff line number	Diff line change
`@@ -2980,8 +2980,8 @@ public function set_attribute( $name, $value ) {`
`2980`	`2980`	`*`
`2981`	`2981`	`* @see https://html.spec.whatwg.org/#attributes-3`
`2982`	`2982`	`*/`
`2983`		`- $escaped_new_value = esc_attr( $value );`
`2984`		`- $updated_attribute = wp_kses_one_attr( "{$comparable_name}=\"{$escaped_new_value}\"", $tag_name );`
	`2983`	`+ $escaped_new_value = in_array( $comparable_name, wp_kses_uri_attributes() ) ? esc_url( $value ) : esc_attr( $value );`
	`2984`	`+ $updated_attribute = "{$name}=\"{$escaped_new_value}\"";`
`2985`	`2985`	`}`
`2986`	`2986`
`2987`	`2987`	`/*`