General: Prevent Media & Theme modals from events on modified arrow keys.

Change the left and right arrow key navigation used in the Theme and Media modal interfaces so the events don't fire when `shift` or `ctrl` are also pressed.

Includes tests.

Props praful2111, hiteshtalpada, joemcgill, sandeepdahiya, abcd95, joedolson.
Fixes #63126.

git-svn-id: https://develop.svn.wordpress.org/trunk@60516 602fd350-edb4-49c9-b593-d223f7449a82

Author: joedolson

src/js/_enqueues/wp/theme.js

@@ -1011,6 +1011,12 @@ themes.view.Preview = themes.view.Details.extend({
 			this.undelegateEvents();
 			this.close();
 		}
+
+		// Return if Ctrl + Shift or Shift key pressed
+		if ( event.shiftKey || ( event.ctrlKey && event.shiftKey ) ) {
+			return;
+		}
+
 		// The right arrow key, next theme.
 		if ( event.keyCode === 39 ) {
 			_.once( this.nextTheme() );
@@ -1115,6 +1121,11 @@ themes.view.Themes = wp.Backbone.View.extend({
 				return;
 			}
 
+			// Return if Ctrl + Shift or Shift key pressed
+			if ( event.shiftKey || ( event.ctrlKey && event.shiftKey ) ) {
+				return;
+			}
+
 			// Pressing the right arrow key fires a theme:next event.
 			if ( event.keyCode === 39 ) {
 				self.overlay.nextTheme();

src/js/media/views/frame/edit-attachments.js

@@ -255,6 +255,11 @@ EditAttachments = MediaFrame.extend(/** @lends wp.media.view.MediaFrame.EditAtta
 			return;
 		}
 
+		// Return if Ctrl + Shift or Shift key pressed
+		if ( event.shiftKey || ( event.ctrlKey && event.shiftKey ) ) {
+			return;
+		}
+
 		// The right arrow key.
 		if ( 39 === event.keyCode ) {
 			this.nextMediaItem();

tests/qunit/index.html

@@ -147,6 +147,7 @@
 
 		<!-- Unit tests -->
 		<script src="wp-admin/js/password-strength-meter.js"></script>
+		<script src="wp-admin/js/theme.js"></script>
 		<script src="wp-admin/js/customize-base.js"></script>
 		<script src="wp-admin/js/customize-header.js"></script>
 		<script src="wp-admin/js/dashboard.js"></script>