Skip to content

Commit ab98006

Browse files
committed
refactor: replace deprecated 'keyCode' with 'key' in key event handling
1 parent 632ead6 commit ab98006

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

src/wp-content/themes/twentyfourteen/js/slider.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -73,12 +73,12 @@
7373
// KEYBOARD
7474
if ( $( slider.containerSelector ).length === 1 ) {
7575
$( document ).bind( 'keyup', function( event ) {
76-
var keycode = event.keyCode,
76+
var keycode = event.key,
7777
target = false;
78-
if ( ! slider.animating && ( keycode === 39 || keycode === 37 ) ) {
79-
if ( keycode === 39 ) {
78+
if ( ! slider.animating && ( keycode === 'ArrowRight' || keycode === 'ArrowLeft' ) ) {
79+
if ( keycode === 'ArrowRight' ) {
8080
target = slider.getTarget( 'next' );
81-
} else if ( keycode === 37 ) {
81+
} else if ( keycode === 'ArrowLeft' ) {
8282
target = slider.getTarget( 'prev' );
8383
}
8484

src/wp-content/themes/twentytwenty/assets/js/index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ twentytwenty.coverModals = {
157157
// Close modal on escape key press.
158158
closeOnEscape: function() {
159159
document.addEventListener( 'keydown', function( event ) {
160-
if ( event.keyCode === 27 ) {
160+
if ( event.key === 'Escape' ) {
161161
event.preventDefault();
162162
document.querySelectorAll( '.cover-modal.active' ).forEach( function( element ) {
163163
this.untoggleModal( element );
@@ -401,7 +401,7 @@ twentytwenty.modalMenu = {
401401
lastEl = elements[ elements.length - 1 ];
402402
firstEl = elements[0];
403403
activeEl = _doc.activeElement;
404-
tabKey = event.keyCode === 9;
404+
tabKey = event.key === 'Tab';
405405
shiftKey = event.shiftKey;
406406

407407
if ( ! shiftKey && tabKey && lastEl === activeEl ) {

src/wp-content/themes/twentytwentyone/assets/js/primary-navigation.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -149,9 +149,9 @@ function twentytwentyoneExpandSubMenu( el ) { // jshint ignore:line
149149
selectors = 'input, a, button';
150150
elements = modal.querySelectorAll( selectors );
151151
elements = Array.prototype.slice.call( elements );
152-
tabKey = event.keyCode === 9;
152+
tabKey = event.key === 'Tab';
153153
shiftKey = event.shiftKey;
154-
escKey = event.keyCode === 27;
154+
escKey = event.key === 'Escape';
155155
activeEl = document.activeElement; // eslint-disable-line @wordpress/no-global-active-element
156156
lastEl = elements[ elements.length - 1 ];
157157
firstEl = elements[0];

0 commit comments

Comments
 (0)