Skip to content

Commit b082308

Browse files
committed
Build/Test Tools: Avoid starting the database twice.
The database container is started when the `services` are initially set up. Having a separate step for this sometimes introduces unexpected failures for an unknown reason. Props johnbillion. See #62221. git-svn-id: https://develop.svn.wordpress.org/trunk@59402 602fd350-edb4-49c9-b593-d223f7449a82
1 parent a27e6a8 commit b082308

File tree

2 files changed

+0
-11
lines changed

2 files changed

+0
-11
lines changed

.github/workflows/install-testing.yml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,6 @@ jobs:
9696
#
9797
# Performs the following steps:
9898
# - Sets up PHP.
99-
# - Starts the database server.
10099
# - Downloads the specified version of WordPress.
101100
# - Creates a `wp-config.php` file.
102101
# - Installs WordPress.
@@ -157,10 +156,6 @@ jobs:
157156
coverage: none
158157
tools: wp-cli${{ contains( fromJSON('["5.4", "5.5"]'), matrix.php ) && ':2.4.0' || '' }}
159158

160-
- name: Start the database server
161-
run: |
162-
sudo systemctl start ${{ matrix.db-type }}
163-
164159
- name: Download WordPress
165160
run: wp core download ${{ inputs.wp-version && format( '--version={0}', inputs.wp-version ) || '--version=nightly' }}
166161

.github/workflows/reusable-upgrade-testing.yml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ jobs:
4242
#
4343
# Performs the following steps:
4444
# - Sets up PHP.
45-
# - Starts the database server.
4645
# - Downloads the specified version of WordPress.
4746
# - Creates a `wp-config.php` file.
4847
# - Installs WordPress.
@@ -68,7 +67,6 @@ jobs:
6867
--entrypoint sh ${{ inputs.db-type }}:${{ inputs.db-version }}
6968
-c "exec docker-entrypoint.sh mysqld${{ inputs.db-type == 'mysql' && contains( fromJSON('["7.2", "7.3"]'), inputs.php ) && ' --default-authentication-plugin=mysql_native_password' || '' }}"
7069
71-
7270
steps:
7371
- name: Set up PHP ${{ inputs.php }}
7472
uses: shivammathur/setup-php@c541c155eee45413f5b09a52248675b1a2575231 # v2.31.1
@@ -77,10 +75,6 @@ jobs:
7775
coverage: none
7876
tools: wp-cli
7977

80-
- name: Start the database server
81-
run: |
82-
sudo systemctl start ${{ inputs.db-type }}
83-
8478
- name: Download WordPress ${{ inputs.wp }}
8579
run: wp core download --version=${{ inputs.wp }}
8680

0 commit comments

Comments
 (0)