Skip to content

Commit becfe55

Browse files
committed
Build/Test Tools: Configure PHPUnit to fail on risky tests.
There should be no need for a risky test to go unseen. It usually signifies a problem in the associated test that needs to be addressed. See #63167, #63932 git-svn-id: https://develop.svn.wordpress.org/trunk@60737 602fd350-edb4-49c9-b593-d223f7449a82
1 parent 9ca38ce commit becfe55

File tree

3 files changed

+5
-1
lines changed

3 files changed

+5
-1
lines changed

.github/workflows/phpunit-tests.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,10 @@ on:
3030
- 'Gruntfile.js'
3131
# These files configure Composer. Changes could affect the outcome.
3232
- 'composer.*'
33-
# This files affect the phpunit tests. Changes could affect the outcome.
33+
# These files affect the phpunit tests. Changes could affect the outcome.
3434
- 'tests/phpunit/**'
35+
- 'tests/phpunit/multisite.xml'
36+
- 'phpunit.xml.dist'
3537
# Confirm any changes to relevant workflow files.
3638
- '.github/workflows/phpunit-tests.yml'
3739
- '.github/workflows/reusable-phpunit-tests-*.yml'

phpunit.xml.dist

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
colors="true"
77
beStrictAboutTestsThatDoNotTestAnything="true"
88
beStrictAboutOutputDuringTests="true"
9+
failOnRisky="true"
910
convertErrorsToExceptions="true"
1011
convertWarningsToExceptions="true"
1112
convertNoticesToExceptions="true"

tests/phpunit/multisite.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
colors="true"
77
beStrictAboutTestsThatDoNotTestAnything="true"
88
beStrictAboutOutputDuringTests="true"
9+
failOnRisky="true"
910
convertErrorsToExceptions="true"
1011
convertWarningsToExceptions="true"
1112
convertNoticesToExceptions="true"

0 commit comments

Comments
 (0)